Hi Kai-Heng, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.16 next-20220113] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/net-phy-marvell-Us... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git fb3b0673b7d5b477ed104949450cd511337ba3c6 config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220114/202201141429.5HZ7UZB6-lk...) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 82c8aca93488730ce8f66101e0f3538f14b551dd) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/83e7c70ef5632f6b94caf8221a20db088... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Kai-Heng-Feng/net-phy-marvell-Use-BIT-macro-for-flags/20220114-120936 git checkout 83e7c70ef5632f6b94caf8221a20db0881ee6ce2 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/phy/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): if (priv->led_def_config == -1) ~~~~~~~~~~~~~~~~~~~~ ^ ~~ 1 warning generated. vim +755 drivers/net/phy/marvell.c 749 750 static void marvell_config_led(struct phy_device *phydev) 751 { 752 struct marvell_priv *priv = phydev->priv; 753 int err; 754 756 return; 757 758 if (priv->led_def_config) 759 goto write; 760 761 if (phydev->dev_flags & MARVELL_PHY_USE_PRESET_LED) { 762 priv->led_def_config = phy_read_paged(phydev, MII_MARVELL_LED_PAGE, 763 MII_PHY_LED_CTRL); 764 if (priv->led_def_config < 0) { 765 priv->led_def_config = -1; 766 return; 767 } 768 } else { 769 switch (MARVELL_PHY_FAMILY_ID(phydev->phy_id)) { 770 /* Default PHY LED config: LED[0] .. Link, LED[1] .. Activity */ 771 case MARVELL_PHY_FAMILY_ID(MARVELL_PHY_ID_88E1121R): 772 case MARVELL_PHY_FAMILY_ID(MARVELL_PHY_ID_88E1318S): 773 priv->led_def_config = MII_88E1121_PHY_LED_DEF; 774 break; 775 /* Default PHY LED config: 776 * LED[0] .. 1000Mbps Link 777 * LED[1] .. 100Mbps Link 778 * LED[2] .. Blink, Activity 779 */ 780 case MARVELL_PHY_FAMILY_ID(MARVELL_PHY_ID_88E1510): 781 if (phydev->dev_flags & MARVELL_PHY_LED0_LINK_LED1_ACTIVE) 782 priv->led_def_config = MII_88E1510_PHY_LED0_LINK_LED1_ACTIVE; 783 else 784 priv->led_def_config = MII_88E1510_PHY_LED_DEF; 785 break; 786 default: 787 priv->led_def_config = -1; 788 return; 789 } 790 } 791 792 write: 793 err = phy_write_paged(phydev, MII_MARVELL_LED_PAGE, MII_PHY_LED_CTRL, 794 priv->led_def_config); 795 if (err < 0) 796 phydev_warn(phydev, "Fail to config marvell phy LED.\n"); 797 } 798 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org