Hi Alim, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20220121] [also build test WARNING on v5.16] [cannot apply to clk/clk-next robh/for-next pinctrl-samsung/for-next v5.16 v5.16-rc8 v5.16-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Alim-Akhtar/dt-bindings-add-vend... base: c94951012a748a0f8ed77cd8fc25640c6fe198f9 config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20220122/202201220550.FSQ6N02X-lk...) compiler: mips-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/69b6b21ebabb149c1c07d83376e9c08a5... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Alim-Akhtar/dt-bindings-add-vendor-prefix-for-Tesla/20220122-022924 git checkout 69b6b21ebabb149c1c07d83376e9c08a582c6423 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/clk/samsung/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): 150 | PLL_35XX_RATE(24 * MHZ, 2400000000, 200, 2, 0), | ^~~~~~~~~~~~~ In file included from include/linux/bits.h:22, from include/linux/bitops.h:6, from include/linux/of.h:15, from include/linux/clk-provider.h:9, from drivers/clk/samsung/clk-fsd.c:11: 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ drivers/clk/samsung/clk-pll.h:48:9: note: in expansion of macro 'BUILD_BUG_ON_ZERO' 48 | BUILD_BUG_ON_ZERO(PLL_RATE(_fin, _m, _p, _s, _k, _ks) != (_fout))) | ^~~~~~~~~~~~~~~~~ drivers/clk/samsung/clk-pll.h:52:33: note: in expansion of macro 'PLL_VALID_RATE' 52 | .rate = PLL_VALID_RATE(_fin, _rate, \ | ^~~~~~~~~~~~~~ drivers/clk/samsung/clk-fsd.c:150:9: note: in expansion of macro 'PLL_35XX_RATE' 150 | PLL_35XX_RATE(24 * MHZ, 2400000000, 200, 2, 0), | ^~~~~~~~~~~~~ drivers/clk/samsung/clk-fsd.c:154:9: warning: this decimal constant is unsigned only in ISO C90 154 | PLL_35XX_RATE(24 * MHZ, 2400000000, 200, 2, 0), | ^~~~~~~~~~~~~ In file included from include/linux/bits.h:22, from include/linux/bitops.h:6, from include/linux/of.h:15, from include/linux/clk-provider.h:9, from drivers/clk/samsung/clk-fsd.c:11: 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ drivers/clk/samsung/clk-pll.h:48:9: note: in expansion of macro 'BUILD_BUG_ON_ZERO' 48 | BUILD_BUG_ON_ZERO(PLL_RATE(_fin, _m, _p, _s, _k, _ks) != (_fout))) | ^~~~~~~~~~~~~~~~~ drivers/clk/samsung/clk-pll.h:52:33: note: in expansion of macro 'PLL_VALID_RATE' 52 | .rate = PLL_VALID_RATE(_fin, _rate, \ | ^~~~~~~~~~~~~~ drivers/clk/samsung/clk-fsd.c:154:9: note: in expansion of macro 'PLL_35XX_RATE' 154 | PLL_35XX_RATE(24 * MHZ, 2400000000, 200, 2, 0), | ^~~~~~~~~~~~~ vim +150 drivers/clk/samsung/clk-fsd.c 148 149 static const struct samsung_pll_rate_table pll_shared1_rate_table[] __initconst = { 151 }; 152 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org