[frank-w-bpi-r2-4.14:5.17-r2pro-hdmiv5-gpu 109/109] sound/soc/generic/simple-card.c:661:17: error: ISO C90 forbids mixed declarations and code
12:03 a.m.
tree: https://github.com/frank-w/BPI-R2-4.14 5.17-r2pro-hdmiv5-gpu
head: 1699cddf654f06e318ea18f3cc11d29bb0e0d135
commit: 1699cddf654f06e318ea18f3cc11d29bb0e0d135 [109/109] debug for headphone soundcard
config: parisc-randconfig-r011-20220213
(https://download.01.org/0day-ci/archive/20220213/202202132134.TWs7ySpP-lk...)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/frank-w/BPI-R2-4.14/commit/1699cddf654f06e318ea18f3cc1...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.17-r2pro-hdmiv5-gpu
git checkout 1699cddf654f06e318ea18f3cc11d29bb0e0d135
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=parisc SHELL=/bin/bash sound/soc/generic/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
sound/soc/generic/simple-card.c: In function 'asoc_simple_probe':
> sound/soc/generic/simple-card.c:661:17: error: ISO C90 forbids
mixed declarations and code [-Werror=declaration-after-statement]
661 |
struct asoc_simple_card_info *cinfo;
| ^~~~~~
cc1: all warnings being treated as errors
vim +661 sound/soc/generic/simple-card.c
8d1bd113a19440 Katsuhiro Suzuki 2018-06-11 613
b0a821daf0d04e Amir Goldstein 2019-05-16 614 static int asoc_simple_probe(struct
platform_device *pdev)
f2390880ec0264 Kuninori Morimoto 2012-04-08 615 {
e59289cda8dec0 Kuninori Morimoto 2019-03-20 616 struct asoc_simple_priv *priv;
f89983ef61677a Kuninori Morimoto 2012-12-25 617 struct device *dev =
&pdev->dev;
dcee9bfe890451 Kuninori Morimoto 2017-03-15 618 struct device_node *np =
dev->of_node;
5be509576cf634 Kuninori Morimoto 2017-03-15 619 struct snd_soc_card *card;
ec1af6c64db94e Thierry Reding 2021-04-19 620 struct link_info *li;
65a5056b21202e Kuninori Morimoto 2019-03-20 621 int ret;
1699cddf654f06 Frank Wunderlich 2022-02-13 622 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
0dd4fc3c2f663b Xiubo Li 2014-09-10 623 /* Allocate the private data and the
DAI link array */
b0133d9c4d7600 Kuninori Morimoto 2016-08-26 624 priv = devm_kzalloc(dev,
sizeof(*priv), GFP_KERNEL);
ca65b492c7a265 Jean-Francois Moine 2014-01-15 625 if (!priv)
ca919fe4b972b9 Xiubo Li 2014-01-14 626 return -ENOMEM;
ca919fe4b972b9 Xiubo Li 2014-01-14 627
d947cdfd4be29c Kuninori Morimoto 2018-12-20 628 card = simple_priv_to_card(priv);
d947cdfd4be29c Kuninori Morimoto 2018-12-20 629 card->owner = THIS_MODULE;
d947cdfd4be29c Kuninori Morimoto 2018-12-20 630 card->dev = dev;
2d01a84605a55c Kuninori Morimoto 2018-12-20 631 card->probe = simple_soc_probe;
907f0a3051869a Guido Günther 2021-06-22 632 card->driver_name =
"simple-card";
d947cdfd4be29c Kuninori Morimoto 2018-12-20 633
ec1af6c64db94e Thierry Reding 2021-04-19 634 li = devm_kzalloc(dev, sizeof(*li),
GFP_KERNEL);
ec1af6c64db94e Thierry Reding 2021-04-19 635 if (!li)
ec1af6c64db94e Thierry Reding 2021-04-19 636 return -ENOMEM;
ec1af6c64db94e Thierry Reding 2021-04-19 637
ec1af6c64db94e Thierry Reding 2021-04-19 638 ret = simple_get_dais_count(priv,
li);
1699cddf654f06 Frank Wunderlich 2022-02-13 639 dev_err(dev,"DEBUG: Passed %s %d
ret:%d\n",__FUNCTION__,__LINE__,ret);
0f687d826736a5 Thierry Reding 2021-04-16 640 if (ret < 0)
0f687d826736a5 Thierry Reding 2021-04-16 641 return ret;
0f687d826736a5 Thierry Reding 2021-04-16 642
ec1af6c64db94e Thierry Reding 2021-04-19 643 if (!li->link)
da215354eb55c3 Kuninori Morimoto 2018-12-14 644 return -EINVAL;
da215354eb55c3 Kuninori Morimoto 2018-12-14 645
ec1af6c64db94e Thierry Reding 2021-04-19 646 ret = asoc_simple_init_priv(priv,
li);
1699cddf654f06 Frank Wunderlich 2022-02-13 647 dev_err(dev,"DEBUG: Passed %s %d
ret:%d\n",__FUNCTION__,__LINE__,ret);
65a5056b21202e Kuninori Morimoto 2019-03-20 648 if (ret < 0)
65a5056b21202e Kuninori Morimoto 2019-03-20 649 return ret;
1699cddf654f06 Frank Wunderlich 2022-02-13 650 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
201a0eac7fe5e7 Jean-Francois Moine 2014-01-15 651 if (np &&
of_device_is_available(np)) {
1699cddf654f06 Frank Wunderlich 2022-02-13 652 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
ec1af6c64db94e Thierry Reding 2021-04-19 653 ret = simple_parse_of(priv, li);
fa558c2801fc17 Kuninori Morimoto 2013-11-20 654 if (ret < 0) {
7a0299e13bc740 Kuninori Morimoto 2021-12-14 655 dev_err_probe(dev, ret, "parse
error\n");
e512e001dafa54 Jean-Francois Moine 2014-03-11 656 goto err;
fa558c2801fc17 Kuninori Morimoto 2013-11-20 657 }
6a91a17bd7b92b Jean-Francois Moine 2014-03-20 658
fa558c2801fc17 Kuninori Morimoto 2013-11-20 659 } else {
1699cddf654f06 Frank Wunderlich 2022-02-13 660 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
ca65b492c7a265 Jean-Francois Moine 2014-01-15 @661 struct asoc_simple_card_info
*cinfo;
f107294c6422e7 Kuninori Morimoto 2019-06-06 662 struct snd_soc_dai_link_component
*cpus;
710af9196ce614 Kuninori Morimoto 2018-08-31 663 struct snd_soc_dai_link_component
*codecs;
e58f41e41185c6 Kuninori Morimoto 2018-08-31 664 struct snd_soc_dai_link_component
*platform;
65a5056b21202e Kuninori Morimoto 2019-03-20 665 struct snd_soc_dai_link *dai_link =
priv->dai_link;
65a5056b21202e Kuninori Morimoto 2019-03-20 666 struct simple_dai_props *dai_props =
priv->dai_props;
65a5056b21202e Kuninori Morimoto 2019-03-20 667
ca65b492c7a265 Jean-Francois Moine 2014-01-15 668 cinfo = dev->platform_data;
ca65b492c7a265 Jean-Francois Moine 2014-01-15 669 if (!cinfo) {
f89983ef61677a Kuninori Morimoto 2012-12-25 670 dev_err(dev, "no info for
asoc-simple-card\n");
f2390880ec0264 Kuninori Morimoto 2012-04-08 671 return -EINVAL;
f2390880ec0264 Kuninori Morimoto 2012-04-08 672 }
1699cddf654f06 Frank Wunderlich 2022-02-13 673 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
f2390880ec0264 Kuninori Morimoto 2012-04-08 674 if (!cinfo->name ||
fa558c2801fc17 Kuninori Morimoto 2013-11-20 675 !cinfo->codec_dai.name ||
7722f830a45f7f Jean-Francois Moine 2014-01-15 676 !cinfo->codec ||
7722f830a45f7f Jean-Francois Moine 2014-01-15 677 !cinfo->platform ||
7722f830a45f7f Jean-Francois Moine 2014-01-15 678 !cinfo->cpu_dai.name) {
f89983ef61677a Kuninori Morimoto 2012-12-25 679 dev_err(dev, "insufficient
asoc_simple_card_info settings\n");
f2390880ec0264 Kuninori Morimoto 2012-04-08 680 return -EINVAL;
f2390880ec0264 Kuninori Morimoto 2012-04-08 681 }
2bee991460a838 Jean-Francois Moine 2014-01-15 682
f107294c6422e7 Kuninori Morimoto 2019-06-06 683 cpus = dai_link->cpus;
f107294c6422e7 Kuninori Morimoto 2019-06-06 684 cpus->dai_name =
cinfo->cpu_dai.name;
f107294c6422e7 Kuninori Morimoto 2019-06-06 685
710af9196ce614 Kuninori Morimoto 2018-08-31 686 codecs = dai_link->codecs;
710af9196ce614 Kuninori Morimoto 2018-08-31 687 codecs->name = cinfo->codec;
710af9196ce614 Kuninori Morimoto 2018-08-31 688 codecs->dai_name =
cinfo->codec_dai.name;
710af9196ce614 Kuninori Morimoto 2018-08-31 689
910fdcabedd235 Kuninori Morimoto 2019-01-21 690 platform = dai_link->platforms;
e58f41e41185c6 Kuninori Morimoto 2018-08-31 691 platform->name =
cinfo->platform;
e58f41e41185c6 Kuninori Morimoto 2018-08-31 692
5be509576cf634 Kuninori Morimoto 2017-03-15 693 card->name = (cinfo->card) ?
cinfo->card : cinfo->name;
5ca8ba4180a6f6 Jean-Francois Moine 2014-01-15 694 dai_link->name =
cinfo->name;
5ca8ba4180a6f6 Jean-Francois Moine 2014-01-15 695 dai_link->stream_name =
cinfo->name;
1efb53a220b78f Lars-Peter Clausen 2015-03-24 696 dai_link->dai_fmt =
cinfo->daifmt;
ad934ca8010843 Kuninori Morimoto 2019-03-20 697 dai_link->init =
asoc_simple_dai_init;
65a5056b21202e Kuninori Morimoto 2019-03-20 698 memcpy(dai_props->cpu_dai,
&cinfo->cpu_dai,
65a5056b21202e Kuninori Morimoto 2019-03-20 699 sizeof(*dai_props->cpu_dai));
65a5056b21202e Kuninori Morimoto 2019-03-20 700 memcpy(dai_props->codec_dai,
&cinfo->codec_dai,
65a5056b21202e Kuninori Morimoto 2019-03-20 701
sizeof(*dai_props->codec_dai));
7722f830a45f7f Jean-Francois Moine 2014-01-15 702 }
1699cddf654f06 Frank Wunderlich 2022-02-13 703 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
5be509576cf634 Kuninori Morimoto 2017-03-15 704 snd_soc_card_set_drvdata(card,
priv);
1699cddf654f06 Frank Wunderlich 2022-02-13 705 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
0580dde5943868 Kuninori Morimoto 2019-03-20 706 asoc_simple_debug_info(priv);
1699cddf654f06 Frank Wunderlich 2022-02-13 707 dev_err(dev,"DEBUG: Passed %s
%d\n",__FUNCTION__,__LINE__);
5be509576cf634 Kuninori Morimoto 2017-03-15 708 ret = devm_snd_soc_register_card(dev,
card);
1699cddf654f06 Frank Wunderlich 2022-02-13 709 dev_err(dev,"DEBUG: Passed %s %d
ret:%d\n",__FUNCTION__,__LINE__,ret);
c6d112e442fed7 Kuninori Morimoto 2017-05-19 710 if (ret < 0)
c6d112e442fed7 Kuninori Morimoto 2017-05-19 711 goto err;
c6d112e442fed7 Kuninori Morimoto 2017-05-19 712
ec1af6c64db94e Thierry Reding 2021-04-19 713 devm_kfree(dev, li);
c6d112e442fed7 Kuninori Morimoto 2017-05-19 714 return 0;
e512e001dafa54 Jean-Francois Moine 2014-03-11 715 err:
ad11e59f52d6fc Kuninori Morimoto 2019-03-20 716 asoc_simple_clean_reference(card);
387f5823f40044 Kuninori Morimoto 2016-08-26 717
e512e001dafa54 Jean-Francois Moine 2014-03-11 718 return ret;
f2390880ec0264 Kuninori Morimoto 2012-04-08 719 }
f2390880ec0264 Kuninori Morimoto 2012-04-08 720
:::::: The code at line 661 was first introduced by commit
:::::: ca65b492c7a265b220f763fd68bf87391213248f ASoC: simple-card: simplify code
:::::: TO: Jean-Francois Moine <moinejf(a)free.fr>
:::::: CC: Mark Brown <broonie(a)linaro.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
219
days inactive
219
days old
0 comments
1 participants
participants (1)
-
kernel test robot