Hi Robert, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on robh/for-next linus/master v5.11-rc7 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Robert-Foss/Add-support-for-the-... base: git://linuxtv.org/media_tree.git master config: mips-randconfig-r036-20210209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/f4da8d1038a233c7c82c8fe394cfe8617... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Robert-Foss/Add-support-for-the-SDM845-Camera-Subsystem/20210206-071553 git checkout f4da8d1038a233c7c82c8fe394cfe861745e807f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): struct csiphy_reg_t *r = &lane_regs_sdm845[l][i]; ^ ~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SSB_EMBEDDED Depends on SSB && SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE Selected by - BCM47XX_SSB && BCM47XX vim +307 drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c 298 299 static void csiphy_gen2_config_lanes(struct csiphy_device *csiphy, 300 u8 settle_cnt) 301 { 302 int i, l; 303 u32 val; 304 305 for (l = 0; l < 5; l++) { 306 for (i = 0; i < 14; i++) { 308 309 switch (r->csiphy_param_type) { 310 case CSIPHY_SETTLE_CNT_LOWER_BYTE: 311 val = settle_cnt & 0xff; 312 break; 313 case CSIPHY_DNP_PARAMS: 314 continue; 315 default: 316 val = r->reg_data; 317 break; 318 } 319 writel_relaxed(val, csiphy->base + r->reg_addr); 320 } 321 } 322 } 323 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org