Re: [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has no member named 'capacity'

Tuesday, 11 August 2020

On 08/10, Niklas Cassel wrote:
...
 On Tue, Jul 21, 2020 at 12:57:36PM -0700, Jaegeuk Kim wrote:
 > On 07/21, Aravind Ramesh wrote:
 > > Hello Jaegeuk,
 > > The patch that adds the capacity struct member has been merged to linux-block
tree's for-next branch.
 > > So either:
 > > 1. f2fs-dev branch has to carry the same patch, from here:
 > >
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log...
 > > I had mentioned this is the cover letter of this patch.
 > > 2. linux-block pull request has to be merged before f2fs pull request to Linus
 > > 3. Or this f2fs patch has to wait until next merge window (the one after kernel
5.9 merge window)
 > 
 > Yeah, indeed. Let me queue this patch and try upstream later till block has it.

 Hello Jaegeuk,

 Just curious, where is this queued?

 I can't find it on any of your branches on this git:
 https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git

 FWIW, commit 82394db7383d ("block: add capacity field to zone descriptors")
 is now in Torvald's tree.

 Which merge window did you intend for this patch? 5.9 or 5.10? 
It was in
https://github.com/jaegeuk/f2fs/commit/550451dc977aeb0000104eb9777fd1dca0...,
and will be moved into kernel.org once pull request for 4.9 was applied.
I think we can merge it in 5.10.

Thanks,

> 
> 
> Kind regards,
> Niklas
> 
> > 
> > Thanks,
> > 
> > > 
> > > Thanks
> > > Aravind
> > > 
> > > > -----Original Message-----
> > > > From: kernel test robot <lkp(a)intel.com&gt;
> > > > Sent: Tuesday, July 21, 2020 12:43 PM
> > > > To: Aravind Ramesh <Aravind.Ramesh(a)wdc.com&gt;
> > > > Cc: kbuild-all(a)lists.01.org; linux-f2fs-devel(a)lists.sourceforge.net;
Jaegeuk Kim
> > > > <jaegeuk(a)kernel.org&gt;; Damien Le Moal
<Damien.LeMoal(a)wdc.com&gt;; Niklas Cassel
> > > > <Niklas.Cassel(a)wdc.com&gt;; Chao Yu <yuchao0(a)huawei.com&gt;;
Chao Yu
> > > > <chao(a)kernel.org&gt;
> > > > Subject: [f2fs:dev-test 37/38] fs/f2fs/super.c:3058:48: error:
'struct blk_zone' has
> > > > no member named 'capacity'
> > > > 
> > > > tree:  
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
> > > > head:   439633ba3673a5d8983529426df144c64a23d181
> > > > commit: d787c5eec8b58bb47d4bf750758e0e87d667bf56 [37/38] f2fs:
support
> > > > zone capacity less than zone size
> > > > config: nds32-allyesconfig (attached as .config)
> > > > compiler: nds32le-linux-gcc (GCC) 9.3.0
> > > > reproduce (this is a W=1 build):
> > > >         wget https://raw.githubusercontent.com/intel/lkp-
> > > > tests/master/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         git checkout d787c5eec8b58bb47d4bf750758e0e87d667bf56
> > > >         # save the attached .config to linux build tree
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
make.cross
> > > > ARCH=nds32
> > > > 
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp(a)intel.com&gt;
> > > > 
> > > > All errors (new ones prefixed by >>):
> > > > 
> > > >    fs/f2fs/super.c: In function 'f2fs_report_zone_cb':
> > > > >> fs/f2fs/super.c:3058:48: error: 'struct blk_zone' has
no member named 'capacity'
> > > >     3058 |  rz_args->dev->zone_capacity_blocks[idx] =
zone->capacity >>
> > > >          |                                                ^~
> > > >    fs/f2fs/super.c:3060:23: error: 'struct blk_zone' has no
member named 'capacity'
> > > >     3060 |  if (zone->len != zone->capacity &&
!rz_args->zone_cap_mismatch)
> > > >          |                       ^~
> > > > 
> > > > vim +3058 fs/f2fs/super.c
> > > > 
> > > >   3048
> > > >   3049	static int f2fs_report_zone_cb(struct blk_zone *zone, unsigned
int idx,
> > > >   3050				      void *data)
> > > >   3051	{
> > > >   3052		struct f2fs_report_zones_args *rz_args = data;
> > > >   3053
> > > >   3054		if (zone->type == BLK_ZONE_TYPE_CONVENTIONAL)
> > > >   3055			return 0;
> > > >   3056
> > > >   3057		set_bit(idx, rz_args->dev->blkz_seq);
> > > > > 3058		rz_args->dev->zone_capacity_blocks[idx] =
zone->capacity >>
> > > >   3059
> > > > 	F2FS_LOG_SECTORS_PER_BLOCK;
> > > >   3060		if (zone->len != zone->capacity &&
!rz_args->zone_cap_mismatch)
> > > >   3061			rz_args->zone_cap_mismatch = true;
> > > >   3062
> > > >   3063		return 0;
> > > >   3064	}
> > > >   3065
> > > > 
> > > > ---
> > > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019