Hi Baoquan, I love your patch! Yet something to improve: [auto build test ERROR on s390/features] [also build test ERROR on linux/master linus/master v5.16-rc1 next-20211117] [cannot apply to kvms390/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Baoquan-He/s390-kexec-check-the-... base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d5463ab680d37f95b493b71c487a51c03... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Baoquan-He/s390-kexec-check-the-return-value-of-ipl_report_finish/20211116-112827 git checkout d5463ab680d37f95b493b71c487a51c039dfe845 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): arch/s390/kernel/machine_kexec_file.c: In function 'arch_kimage_file_post_load_cleanup': >> arch/s390/kernel/machine_kexec_file.c:332:9: error: implicit declaration of function 'kvfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] 332 | kvfree(image->arch.ipl_buf); | ^~~~~~ | vfree

On Thu, Nov 18, 2021 at 03:13:27PM +0800, Baoquan He wrote: > On 11/18/21 at 05:46am, kernel test robot wrote: > > arch/s390/kernel/machine_kexec_file.c: In function 'arch_kimage_file_post_load_cleanup': > > >> arch/s390/kernel/machine_kexec_file.c:332:9: error: implicit declaration of function 'kvfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > > 332 | kvfree(image->arch.ipl_buf); > > | ^~~~~~ > > | vfree > > OK, kvfree is not wrong, seems vfree is more appropriate since it's > clear the ipl_buf is allocated with zvalloc() in ipl_report_finish(). > > Hi Heiko, > > Could you help modify the code in your tree or append below patch to > mute the lkp complaint? Sorry for the inconvenience. ... > arch/s390/kernel/machine_kexec_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kernel/machine_kexec_file.c b/arch/s390/kernel/machine_kexec_file.c > index 7f51837e9bc2..351a7ff69a43 100644 > --- a/arch/s390/kernel/machine_kexec_file.c > +++ b/arch/s390/kernel/machine_kexec_file.c > @@ -329,7 +329,7 @@ int arch_kexec_apply_relocations_add(struct purgatory_info *pi, > > int arch_kimage_file_post_load_cleanup(struct kimage *image) > { > - kvfree(image->arch.ipl_buf); > + vfree(image->arch.ipl_buf); The problem reported above indicates that slab.h was not included. With your patch, while it fixes the problem for this particular configuration, this requires vmalloc.h to be included.

I'll merge your patch and add the missing include as well.