Hi Qi, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on linus/master] [also build test ERROR on v5.13-rc6 next-20210616] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Qi-Liu/Add-support-for-Ultrasoc-... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 94f0b2d4a1d0c52035aef425da5e022bd2cb1c71 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/34aa8589f94ed20eca533ed8463184bb3... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qi-Liu/Add-support-for-Ultrasoc-Trace-Module/20210616-151905 git checkout 34aa8589f94ed20eca533ed8463184bb3194f80d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c: In function 'axi_com_enable_hw': 42 | val = readl(drvdata->base + AXIC_US_CTL); | ^~~~~ 44 | writel(val, drvdata->base + AXIC_US_CTL); | ^~~~~~ In file included from include/linux/device.h:32, from include/linux/acpi.h:15, from drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:30: drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c: At top level: 263 | module_init(__driver##_init); \ | ^~~~~~~~~~~ include/linux/platform_device.h:257:2: note: in expansion of macro 'module_driver' 257 | module_driver(__platform_driver, platform_driver_register, \ | ^~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:1: note: in expansion of macro 'module_platform_driver' 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~~~~~~~~~ 263 | module_init(__driver##_init); \ | ^~~~~~~~~~~ include/linux/platform_device.h:257:2: note: in expansion of macro 'module_driver' 257 | module_driver(__platform_driver, platform_driver_register, \ | ^~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:1: note: in expansion of macro 'module_platform_driver' 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/device.h:32, from include/linux/acpi.h:15, from drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:30: include/linux/device/driver.h:268:1: warning: data definition has no type or storage class 268 | module_exit(__driver##_exit); | ^~~~~~~~~~~ include/linux/platform_device.h:257:2: note: in expansion of macro 'module_driver' 257 | module_driver(__platform_driver, platform_driver_register, \ | ^~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:1: note: in expansion of macro 'module_platform_driver' 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~~~~~~~~~ 268 | module_exit(__driver##_exit); | ^~~~~~~~~~~ include/linux/platform_device.h:257:2: note: in expansion of macro 'module_driver' 257 | module_driver(__platform_driver, platform_driver_register, \ | ^~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:1: note: in expansion of macro 'module_platform_driver' 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~~~~~~~~~ >> drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:331:20: error: expected declaration specifiers or '...' before string constant 331 | MODULE_DESCRIPTION("Ultrasoc AXI COM driver"); | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:332:16: error: expected declaration specifiers or '...' before string constant 332 | MODULE_LICENSE("Dual MIT/GPL"); | ^~~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:333:15: error: expected declaration specifiers or '...' before string constant 333 | MODULE_AUTHOR("Jonathan Zhou <jonathan.zhouwen(a)huawei.com&gt;&quot;); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:334:15: error: expected declaration specifiers or '...' before string constant 334 | MODULE_AUTHOR("Qi Liu <liuqi115(a)huawei.com&gt;&quot;); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/device.h:32, from include/linux/acpi.h:15, from drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:30: drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:24: warning: 'axi_com_driver_exit' defined but not used [-Wunused-function] 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~ include/linux/device/driver.h:264:20: note: in definition of macro 'module_driver' 264 | static void __exit __driver##_exit(void) \ | ^~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:1: note: in expansion of macro 'module_platform_driver' 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~~~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:24: warning: 'axi_com_driver_init' defined but not used [-Wunused-function] 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~ include/linux/device/driver.h:259:19: note: in definition of macro 'module_driver' 259 | static int __init __driver##_init(void) \ | ^~~~~~~~ drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c:329:1: note: in expansion of macro 'module_platform_driver' 329 | module_platform_driver(axi_com_driver); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/readl +42 drivers/hwtracing/ultrasoc/ultrasoc-axi-com.c 37 38 static void axi_com_enable_hw(struct axi_com_drv_data *drvdata) 39 { 40 u32 val; 41 43 val |= AXIC_US_CTL_EN; 45 46 val = readl(drvdata->base + AXIC_DS_CTL); 47 val |= AXIC_DS_CTL_EN; 48 writel(val, drvdata->base + AXIC_DS_CTL); 49 } 50 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org