Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-d... base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dcc82bb0727c08f93a91fa7532b950bafa2598f2 config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c:18: 720 | dsa_build_ndo_op(ndo_do_ioctl, struct ifreq *, ifr, int, cmd); | ^~~~~~~~~~~~~~~~ include/net/dsa.h:721:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] 721 | dsa_build_ndo_op(ndo_get_phys_port_name, char *, name, size_t, len); | ^~~~~~~~~~~~~~~~ vim +/inline +720 include/net/dsa.h 719 721 dsa_build_ndo_op(ndo_get_phys_port_name, char *, name, size_t, len); 722 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org