tree:
https://github.com/intel/linux-intel-lts.git 4.19/android_q
head: ee112de3f23d279394b5b043f3ee07b4987cc50b
commit: c097da3ba72ef8284568d3909582d38755dbcada [19663/22905] ASoC: Intel: Skylake:
remove fmt_idx and res_idx from mconfig
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/intel/linux-intel-lts/commit/c097da3ba72ef8284568d3909...
git remote add intel-lts
https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-lts 4.19/android_q
git checkout c097da3ba72ef8284568d3909582d38755dbcada
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
sound/soc/intel/skylake/skl-messages.c: In function 'skl_bind_modules':
> sound/soc/intel/skylake/skl-messages.c:2474:21: warning: variable
'module' set but not used [-Wunused-but-set-variable]
2474 | struct
skl_module *module;
| ^~~~~~
vim +/module +2474 sound/soc/intel/skylake/skl-messages.c
7d3a0a74b16aeed Praveen Diwakar 2017-03-08 2455
beb73b266a75602 Jeeja KP 2015-08-01 2456 /*
beb73b266a75602 Jeeja KP 2015-08-01 2457 * Once a module is instantiated it
need to be 'bind' with other modules in
beb73b266a75602 Jeeja KP 2015-08-01 2458 * the pipeline. For binding we need
to find the module pins which are bind
beb73b266a75602 Jeeja KP 2015-08-01 2459 * together
beb73b266a75602 Jeeja KP 2015-08-01 2460 * This function finds the pins and
then sends bund_unbind IPC message to
beb73b266a75602 Jeeja KP 2015-08-01 2461 * DSP using IPC helper
beb73b266a75602 Jeeja KP 2015-08-01 2462 */
beb73b266a75602 Jeeja KP 2015-08-01 2463 int skl_bind_modules(struct skl_sst
*ctx,
beb73b266a75602 Jeeja KP 2015-08-01 2464 struct skl_module_cfg *src_mcfg,
beb73b266a75602 Jeeja KP 2015-08-01 2465 struct skl_module_cfg *dst_mcfg)
beb73b266a75602 Jeeja KP 2015-08-01 2466 {
38a770859e10f56 Pradeep Tewani 2017-09-01 2467 int ret = 0;
beb73b266a75602 Jeeja KP 2015-08-01 2468 struct skl_ipc_bind_unbind_msg msg;
f6fa56e22559ade Ramesh Babu 2017-08-23 2469 int in_max =
dst_mcfg->module->max_input_pins;
f6fa56e22559ade Ramesh Babu 2017-08-23 2470 int out_max =
src_mcfg->module->max_output_pins;
beb73b266a75602 Jeeja KP 2015-08-01 2471 int src_index, dst_index;
38a770859e10f56 Pradeep Tewani 2017-09-01 2472 struct skl_module_fmt *format;
38a770859e10f56 Pradeep Tewani 2017-09-01 2473 struct skl_cpr_pin_fmt pin_fmt;
38a770859e10f56 Pradeep Tewani 2017-09-01 @2474 struct skl_module *module;
38a770859e10f56 Pradeep Tewani 2017-09-01 2475 struct skl_module_iface *fmt;
beb73b266a75602 Jeeja KP 2015-08-01 2476
beb73b266a75602 Jeeja KP 2015-08-01 2477 skl_dump_bind_info(ctx, src_mcfg,
dst_mcfg);
beb73b266a75602 Jeeja KP 2015-08-01 2478
0c684c48257bc60 Jeeja KP 2016-02-03 2479 if (src_mcfg->m_state <
SKL_MODULE_INIT_DONE ||
beb73b266a75602 Jeeja KP 2015-08-01 2480 dst_mcfg->m_state <
SKL_MODULE_INIT_DONE)
beb73b266a75602 Jeeja KP 2015-08-01 2481 return 0;
beb73b266a75602 Jeeja KP 2015-08-01 2482
4f7457089df2984 Jeeja KP 2015-10-27 2483 src_index =
skl_alloc_queue(src_mcfg->m_out_pin, dst_mcfg, out_max);
beb73b266a75602 Jeeja KP 2015-08-01 2484 if (src_index < 0)
beb73b266a75602 Jeeja KP 2015-08-01 2485 return -EINVAL;
beb73b266a75602 Jeeja KP 2015-08-01 2486
4f7457089df2984 Jeeja KP 2015-10-27 2487 msg.src_queue = src_index;
4f7457089df2984 Jeeja KP 2015-10-27 2488 dst_index =
skl_alloc_queue(dst_mcfg->m_in_pin, src_mcfg, in_max);
beb73b266a75602 Jeeja KP 2015-08-01 2489 if (dst_index < 0) {
beb73b266a75602 Jeeja KP 2015-08-01 2490
skl_free_queue(src_mcfg->m_out_pin, src_index);
beb73b266a75602 Jeeja KP 2015-08-01 2491 return -EINVAL;
beb73b266a75602 Jeeja KP 2015-08-01 2492 }
beb73b266a75602 Jeeja KP 2015-08-01 2493
38a770859e10f56 Pradeep Tewani 2017-09-01 2494 /*
38a770859e10f56 Pradeep Tewani 2017-09-01 2495 * Copier module requires the
separate large_config_set_ipc to
38a770859e10f56 Pradeep Tewani 2017-09-01 2496 * configure the pins other than 0
38a770859e10f56 Pradeep Tewani 2017-09-01 2497 */
38a770859e10f56 Pradeep Tewani 2017-09-01 2498 if (src_mcfg->m_type ==
SKL_MODULE_TYPE_COPIER && src_index > 0) {
38a770859e10f56 Pradeep Tewani 2017-09-01 2499 pin_fmt.sink_id = src_index;
38a770859e10f56 Pradeep Tewani 2017-09-01 2500 module = src_mcfg->module;
c097da3ba72ef82 Gustaw Lewandowski 2020-01-06 2501 fmt =
skl_get_module_iface(src_mcfg);
38a770859e10f56 Pradeep Tewani 2017-09-01 2502
38a770859e10f56 Pradeep Tewani 2017-09-01 2503 /* Input fmt is same as that of src
module input cfg */
38a770859e10f56 Pradeep Tewani 2017-09-01 2504 format =
&fmt->inputs[0].fmt;
38a770859e10f56 Pradeep Tewani 2017-09-01 2505
fill_pin_params(&(pin_fmt.src_fmt), format);
38a770859e10f56 Pradeep Tewani 2017-09-01 2506
38a770859e10f56 Pradeep Tewani 2017-09-01 2507 format =
&fmt->outputs[src_index].fmt;
38a770859e10f56 Pradeep Tewani 2017-09-01 2508
fill_pin_params(&(pin_fmt.dst_fmt), format);
38a770859e10f56 Pradeep Tewani 2017-09-01 2509 ret = skl_set_module_params(ctx,
(void *)&pin_fmt,
38a770859e10f56 Pradeep Tewani 2017-09-01 2510 sizeof(struct skl_cpr_pin_fmt),
38a770859e10f56 Pradeep Tewani 2017-09-01 2511 CPR_SINK_FMT_PARAM_ID,
src_mcfg);
38a770859e10f56 Pradeep Tewani 2017-09-01 2512
38a770859e10f56 Pradeep Tewani 2017-09-01 2513 if (ret < 0)
38a770859e10f56 Pradeep Tewani 2017-09-01 2514 goto out;
38a770859e10f56 Pradeep Tewani 2017-09-01 2515 }
38a770859e10f56 Pradeep Tewani 2017-09-01 2516
4f7457089df2984 Jeeja KP 2015-10-27 2517 msg.dst_queue = dst_index;
beb73b266a75602 Jeeja KP 2015-08-01 2518
beb73b266a75602 Jeeja KP 2015-08-01 2519 dev_dbg(ctx->dev, "src queue
= %d dst queue =%d\n",
beb73b266a75602 Jeeja KP 2015-08-01 2520 msg.src_queue, msg.dst_queue);
beb73b266a75602 Jeeja KP 2015-08-01 2521
7d3a0a74b16aeed Praveen Diwakar 2017-03-08 2522
skl_module_format_mismatch_detection(ctx, src_mcfg, dst_mcfg,
7d3a0a74b16aeed Praveen Diwakar 2017-03-08 2523 src_index, dst_index);
7d3a0a74b16aeed Praveen Diwakar 2017-03-08 2524
beb73b266a75602 Jeeja KP 2015-08-01 2525 msg.module_id =
src_mcfg->id.module_id;
ef2a352cfb2a536 Dharageswari R 2016-09-22 2526 msg.instance_id =
src_mcfg->id.pvt_id;
beb73b266a75602 Jeeja KP 2015-08-01 2527 msg.dst_module_id =
dst_mcfg->id.module_id;
ef2a352cfb2a536 Dharageswari R 2016-09-22 2528 msg.dst_instance_id =
dst_mcfg->id.pvt_id;
beb73b266a75602 Jeeja KP 2015-08-01 2529 msg.bind = true;
beb73b266a75602 Jeeja KP 2015-08-01 2530
beb73b266a75602 Jeeja KP 2015-08-01 2531 ret =
skl_ipc_bind_unbind(&ctx->ipc, &msg);
beb73b266a75602 Jeeja KP 2015-08-01 2532
beb73b266a75602 Jeeja KP 2015-08-01 2533 if (!ret) {
beb73b266a75602 Jeeja KP 2015-08-01 2534 src_mcfg->m_state =
SKL_MODULE_BIND_DONE;
4f7457089df2984 Jeeja KP 2015-10-27 2535
src_mcfg->m_out_pin[src_index].pin_state = SKL_PIN_BIND_DONE;
4f7457089df2984 Jeeja KP 2015-10-27 2536
dst_mcfg->m_in_pin[dst_index].pin_state = SKL_PIN_BIND_DONE;
38a770859e10f56 Pradeep Tewani 2017-09-01 2537 return ret;
38a770859e10f56 Pradeep Tewani 2017-09-01 2538 }
38a770859e10f56 Pradeep Tewani 2017-09-01 2539 out:
beb73b266a75602 Jeeja KP 2015-08-01 2540 /* error case , if IPC fails, clear
the queue index */
beb73b266a75602 Jeeja KP 2015-08-01 2541
skl_free_queue(src_mcfg->m_out_pin, src_index);
beb73b266a75602 Jeeja KP 2015-08-01 2542
skl_free_queue(dst_mcfg->m_in_pin, dst_index);
beb73b266a75602 Jeeja KP 2015-08-01 2543
beb73b266a75602 Jeeja KP 2015-08-01 2544 return ret;
beb73b266a75602 Jeeja KP 2015-08-01 2545 }
c9b1e834bc8deca Jeeja KP 2015-08-01 2546
:::::: The code at line 2474 was first introduced by commit
:::::: 38a770859e10f566c434ae0d3f380954280f262b ASoC: Intel: Skylake: Add IPC to configure
the copier secondary pins
:::::: TO: Pradeep Tewani <pradeep.d.tewani(a)intel.com>
:::::: CC: Mark Brown <broonie(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org