Hi Herrington, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9-rc5 next-20200918] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Herrington/ptp-mark-symbols-stat... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 10b82d5176488acee2820e5a2cf0f2ec5c3488b6 config: x86_64-randconfig-a002-20200917 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 0ff28fa6a75617d61b1aeea77463d6a1684c3c89) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from drivers/ptp/ptp_chardev.c:16: In file included from drivers/ptp/ptp_private.h:16: void pch_ch_control_write(struct pci_dev *pdev, u32 val); ^ include/linux/ptp_clock_kernel.h:311:30: warning: declaration of 'struct pci_dev' will not be visible outside of this function [-Wvisibility] u32 pch_ch_event_read(struct pci_dev *pdev); ^ include/linux/ptp_clock_kernel.h:312:32: warning: declaration of 'struct pci_dev' will not be visible outside of this function [-Wvisibility] void pch_ch_event_write(struct pci_dev *pdev, u32 val); ^ include/linux/ptp_clock_kernel.h:313:33: warning: declaration of 'struct pci_dev' will not be visible outside of this function [-Wvisibility] u32 pch_src_uuid_lo_read(struct pci_dev *pdev); ^ include/linux/ptp_clock_kernel.h:314:33: warning: declaration of 'struct pci_dev' will not be visible outside of this function [-Wvisibility] u32 pch_src_uuid_hi_read(struct pci_dev *pdev); ^ include/linux/ptp_clock_kernel.h:315:29: warning: declaration of 'struct pci_dev' will not be visible outside of this function [-Wvisibility] u64 pch_rx_snap_read(struct pci_dev *pdev); ^ include/linux/ptp_clock_kernel.h:316:29: warning: declaration of 'struct pci_dev' will not be visible outside of this function [-Wvisibility] u64 pch_tx_snap_read(struct pci_dev *pdev); ^ include/linux/ptp_clock_kernel.h:317:46: warning: declaration of 'struct pci_dev' will not be visible outside of this function [-Wvisibility] int pch_set_station_address(u8 *addr, struct pci_dev *pdev); ^ 8 warnings generated. # https://github.com/0day-ci/linux/commit/d5fd7587ec0ce30118654a4b5c38a41a1... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Herrington/ptp-mark-symbols-static-where-possible/20200918-181139 git checkout d5fd7587ec0ce30118654a4b5c38a41a19ea5920 vim +310 include/linux/ptp_clock_kernel.h 309 311 u32 pch_ch_event_read(struct pci_dev *pdev); 312 void pch_ch_event_write(struct pci_dev *pdev, u32 val); 313 u32 pch_src_uuid_lo_read(struct pci_dev *pdev); 314 u32 pch_src_uuid_hi_read(struct pci_dev *pdev); 315 u64 pch_rx_snap_read(struct pci_dev *pdev); 316 u64 pch_tx_snap_read(struct pci_dev *pdev); 317 int pch_set_station_address(u8 *addr, struct pci_dev *pdev); 318 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org