Hi Eugene, I love your patch! Perhaps something to improve: [auto build test WARNING on groeck-staging/hwmon-next] [also build test WARNING on next-20211217] [cannot apply to linus/master v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Eugene-Shalygin/hwmon-asus-ec-se... base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20211218/202112180502.QgAc0Kak-lk...) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/f18e6c103f89584b0027d079425d8e868... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Eugene-Shalygin/hwmon-asus-ec-sensors-add-driver-for-ASUS-EC/20211218-014433 git checkout f18e6c103f89584b0027d079425d8e868a535a6d # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/hwmon/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): * Arbitrary set max. allowed bank number. Required for sorting banks and drivers/hwmon/asus-ec-sensors.c:133: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * All the known sensors for ASUS EC controllers vim +45 drivers/hwmon/asus-ec-sensors.c 43 44 /** 46 * currently is overkill with just 2 banks used at max, but for the sake 47 * of alignment let's set it to a higher value. 48 */ 49 #define ASUS_EC_MAX_BANK 3 50 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org