Hi "Liam, I love your patch! Yet something to improve: [auto build test ERROR on efi/next] [also build test ERROR on linus/master v5.10-rc7] [cannot apply to tip/x86/core hnaz-linux-mm/master next-20201211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Liam-R-Howlett/RFC-mm-Introducin... base: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next config: i386-randconfig-s001-20201210 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/linux/commit/991a17ff32a6bc9549655cd0aea43c386... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Liam-R-Howlett/RFC-mm-Introducing-the-Maple-Tree/20201211-011029 git checkout 991a17ff32a6bc9549655cd0aea43c386fdea1c6 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from include/linux/mm_types.h:11, from include/linux/mmzone.h:21, from include/linux/gfp.h:6, from include/linux/slab.h:15, from include/linux/crypto.h:20, from arch/x86/kernel/asm-offsets.c:9: 79 | unsigned long pivot[MAPLE_RANGE64_SLOTS - 1]; | ^~~~~~~~~~~~~~~~~~~ 85 | unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1]; | ^~~~~~~~~~~~~~~~~~~~ 91 | #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1) | ^~~~~~~~~~~~~~~~ include/linux/maple_tree.h:96:27: note: in expansion of macro 'MAPLE_ALLOC_SLOTS' 96 | struct maple_alloc *slot[MAPLE_ALLOC_SLOTS]; | ^~~~~~~~~~~~~~~~~ -- In file included from include/linux/mm_types.h:11, from include/linux/mmzone.h:21, from include/linux/gfp.h:6, from include/linux/slab.h:15, from include/linux/crypto.h:20, from arch/x86/kernel/asm-offsets.c:9: 79 | unsigned long pivot[MAPLE_RANGE64_SLOTS - 1]; | ^~~~~~~~~~~~~~~~~~~ 85 | unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1]; | ^~~~~~~~~~~~~~~~~~~~ 91 | #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1) | ^~~~~~~~~~~~~~~~ include/linux/maple_tree.h:96:27: note: in expansion of macro 'MAPLE_ALLOC_SLOTS' 96 | struct maple_alloc *slot[MAPLE_ALLOC_SLOTS]; | ^~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1200: prepare0] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- In file included from include/linux/mm_types.h:11, from include/linux/mmzone.h:21, from include/linux/gfp.h:6, from include/linux/slab.h:15, from include/linux/crypto.h:20, from arch/x86/kernel/asm-offsets.c:9: 79 | unsigned long pivot[MAPLE_RANGE64_SLOTS - 1]; | ^~~~~~~~~~~~~~~~~~~ 85 | unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1]; | ^~~~~~~~~~~~~~~~~~~~ 91 | #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1) | ^~~~~~~~~~~~~~~~ include/linux/maple_tree.h:96:27: note: in expansion of macro 'MAPLE_ALLOC_SLOTS' 96 | struct maple_alloc *slot[MAPLE_ALLOC_SLOTS]; | ^~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1200: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/MAPLE_RANGE64_SLOTS +79 include/linux/maple_tree.h d79b3ea66666bc9 Liam R. Howlett 2020-12-10 40 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 41 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 42 /** d79b3ea66666bc9 Liam R. Howlett 2020-12-10 43 * maple_tree node explained d79b3ea66666bc9 Liam R. Howlett 2020-12-10 44 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 45 * Each node type has a number of slots for entries and a number of slots for d79b3ea66666bc9 Liam R. Howlett 2020-12-10 46 * pivots. In the case of dense nodes, the pivots are implied by the position d79b3ea66666bc9 Liam R. Howlett 2020-12-10 47 * and are simply the slot index + the minimum of the node. d79b3ea66666bc9 Liam R. Howlett 2020-12-10 48 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 49 * In regular B-Tree terms, pivots are called keys. The term pivot is used to d79b3ea66666bc9 Liam R. Howlett 2020-12-10 50 * indicate that the tree is specifying ranges, Pivots may appear in the d79b3ea66666bc9 Liam R. Howlett 2020-12-10 51 * subtree with an entry attached to the value where as keys are unique to a d79b3ea66666bc9 Liam R. Howlett 2020-12-10 52 * specific position of a B-tree. Pivot values are inclusive of the slot with d79b3ea66666bc9 Liam R. Howlett 2020-12-10 53 * the same index. d79b3ea66666bc9 Liam R. Howlett 2020-12-10 54 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 55 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 56 * The following illustrates the layout of a range64 nodes slots and pivots. d79b3ea66666bc9 Liam R. Howlett 2020-12-10 57 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 58 * _________________________________ d79b3ea66666bc9 Liam R. Howlett 2020-12-10 59 * Slots -> | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | d79b3ea66666bc9 Liam R. Howlett 2020-12-10 60 * ┬ ┬ ┬ ┬ ┬ ┬ ┬ ┬ ┬ d79b3ea66666bc9 Liam R. Howlett 2020-12-10 61 * │ │ │ │ │ │ │ │ └─ Implied maximum d79b3ea66666bc9 Liam R. Howlett 2020-12-10 62 * │ │ │ │ │ │ │ └─ Pivot 6 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 63 * │ │ │ │ │ │ └─ Pivot 5 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 64 * │ │ │ │ │ └─ Pivot 4 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 65 * │ │ │ │ └─ Pivot 3 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 66 * │ │ │ └─ Pivot 2 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 67 * │ │ └─ Pivot 1 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 68 * │ └─ Pivot 0 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 69 * └─ Implied minimum d79b3ea66666bc9 Liam R. Howlett 2020-12-10 70 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 71 * Slot contents: d79b3ea66666bc9 Liam R. Howlett 2020-12-10 72 * Internal (non-leaf) nodes contain pointers to other nodes. d79b3ea66666bc9 Liam R. Howlett 2020-12-10 73 * Leaf nodes contain entries. d79b3ea66666bc9 Liam R. Howlett 2020-12-10 74 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 75 * d79b3ea66666bc9 Liam R. Howlett 2020-12-10 76 */ d79b3ea66666bc9 Liam R. Howlett 2020-12-10 77 struct maple_range_64 { d79b3ea66666bc9 Liam R. Howlett 2020-12-10 78 struct maple_pnode *parent; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 @79 unsigned long pivot[MAPLE_RANGE64_SLOTS - 1]; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 80 void __rcu *slot[MAPLE_RANGE64_SLOTS]; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 81 }; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 82 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 83 struct maple_arange_64 { d79b3ea66666bc9 Liam R. Howlett 2020-12-10 84 struct maple_pnode *parent; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 @85 unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1]; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 86 void __rcu *slot[MAPLE_ARANGE64_SLOTS]; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 87 unsigned long gap[MAPLE_ARANGE64_SLOTS]; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 88 unsigned char meta; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 89 }; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 90 d79b3ea66666bc9 Liam R. Howlett 2020-12-10 @91 #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1) d79b3ea66666bc9 Liam R. Howlett 2020-12-10 92 struct maple_alloc { d79b3ea66666bc9 Liam R. Howlett 2020-12-10 93 unsigned long total; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 94 unsigned char node_count; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 95 unsigned int request_count; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 96 struct maple_alloc *slot[MAPLE_ALLOC_SLOTS]; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 97 }; d79b3ea66666bc9 Liam R. Howlett 2020-12-10 98 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org