Hi Luca,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master linus/master v5.11-rc7]
[cannot apply to next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Luca-Coelho/iwlwifi-updates-inte...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-ne...
master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/477683319e91793d94debf7f0c0019a31...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Luca-Coelho/iwlwifi-updates-intended-for-v5-12-2021-02-10-part-2/20210210-233911
git checkout 477683319e91793d94debf7f0c0019a31e6cde3f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
> drivers/net/wireless/intel/iwlwifi/fw/pnvm.c:228:28: warning:
"LINUX_VERSION_IS_GEQ" is not defined, evaluates to 0 [-Wundef]
228 |
#if defined(CONFIG_EFI) && LINUX_VERSION_IS_GEQ(5,4,0)
| ^~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/intel/iwlwifi/fw/pnvm.c:228:48: error:
missing binary operator before token "("
228 | #if
defined(CONFIG_EFI) && LINUX_VERSION_IS_GEQ(5,4,0)
| ^
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS &&
STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390
&& !MICROBLAZE && !ARM && !ARC && !X86
vim +228 drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
222
223 /*
224 * This is known to be broken on v4.19 and to work on v5.4. Until we
225 * figure out why this is the case and how to make it work, simply
226 * disable the feature in old kernels.
227 */
228 #if defined(CONFIG_EFI) && LINUX_VERSION_IS_GEQ(5,4,0)
229
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org