tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending-ath11k head: 727f4796623292eb33ce560a3e25ba0040d17871 commit: 75a016fcc8f79a7d650462c69bb28aa886b4f09e [316/345] ath11k: cleanup and rename ath11k_send_crash_inject_cmd() If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; New smatch warnings: drivers/net/wireless/ath/ath11k/debug.c:575 ath11k_write_simulate_fw_crash() error: we previously assumed 'ar' could be null (see line 549) Old smatch warnings: drivers/net/wireless/ath/ath11k/debug.c:566 ath11k_write_simulate_fw_crash() error: uninitialized symbol 'radioup'. # https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=... git remote add ath6kl https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git git remote update ath6kl git checkout 75a016fcc8f79a7d650462c69bb28aa886b4f09e vim +/ar +575 drivers/net/wireless/ath/ath11k/debug.c 258bbf525e652e Kalle Valo 2019-02-05 535 static ssize_t ath11k_write_simulate_fw_crash(struct file *file, 258bbf525e652e Kalle Valo 2019-02-05 536 const char __user *user_buf, 258bbf525e652e Kalle Valo 2019-02-05 537 size_t count, loff_t *ppos) 258bbf525e652e Kalle Valo 2019-02-05 538 { d25cb35c6f10ac Sathishkumar Muruganandam 2019-02-13 539 struct ath11k_base *ab = file->private_data; 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 540 struct ath11k_pdev *pdev; d25cb35c6f10ac Sathishkumar Muruganandam 2019-02-13 541 struct ath11k *ar = ab->pdevs[0].ar; 258bbf525e652e Kalle Valo 2019-02-05 542 char buf[32] = {0}; 258bbf525e652e Kalle Valo 2019-02-05 543 ssize_t rc; 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 544 int i, ret, radioup; ^^^^^^^ The real bug is that this isn't initialized. 258bbf525e652e Kalle Valo 2019-02-05 545 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 546 for (i = 0; i < ab->num_radios; i++) { 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 547 pdev = &ab->pdevs[i]; 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 548 ar = pdev->ar; 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 @549 if (ar && ar->state == ATH11K_STATE_ON) { 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 550 radioup = 1; 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 551 break; 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 552 } 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 553 } 258bbf525e652e Kalle Valo 2019-02-05 554 /* filter partial writes and invalid commands */ 258bbf525e652e Kalle Valo 2019-02-05 555 if (*ppos != 0 || count >= sizeof(buf) || count == 0) 258bbf525e652e Kalle Valo 2019-02-05 556 return -EINVAL; 258bbf525e652e Kalle Valo 2019-02-05 557 258bbf525e652e Kalle Valo 2019-02-05 558 rc = simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, user_buf, count); 258bbf525e652e Kalle Valo 2019-02-05 559 if (rc < 0) 258bbf525e652e Kalle Valo 2019-02-05 560 return rc; 258bbf525e652e Kalle Valo 2019-02-05 561 258bbf525e652e Kalle Valo 2019-02-05 562 /* drop the possible '\n' from the end */ 258bbf525e652e Kalle Valo 2019-02-05 563 if (buf[*ppos - 1] == '\n') 258bbf525e652e Kalle Valo 2019-02-05 564 buf[*ppos - 1] = '\0'; 258bbf525e652e Kalle Valo 2019-02-05 565 5cf3588467b76d Pradeep Kumar Chitrapu 2019-03-15 566 if (radioup == 0) { ^^^^^^^^^^^^ So this is meaningless. Why not check if (i == ab->num_radios) instead? 258bbf525e652e Kalle Valo 2019-02-05 567 ret = -ENETDOWN; 258bbf525e652e Kalle Valo 2019-02-05 568 goto exit; 258bbf525e652e Kalle Valo 2019-02-05 569 } 258bbf525e652e Kalle Valo 2019-02-05 570 258bbf525e652e Kalle Valo 2019-02-05 571 if (!strcmp(buf, "assert")) { d25cb35c6f10ac Sathishkumar Muruganandam 2019-02-13 572 ath11k_info(ab, "simulating firmware assert crash\n"); 75a016fcc8f79a Kalle Valo 2019-08-09 573 ret = ath11k_wmi_force_fw_hang_cmd(ar, 75a016fcc8f79a Kalle Valo 2019-08-09 574 ATH11K_WMI_FW_HANG_ASSERT_TYPE, 75a016fcc8f79a Kalle Valo 2019-08-09 @575 ATH11K_WMI_FW_HANG_DELAY); 258bbf525e652e Kalle Valo 2019-02-05 576 } else { 258bbf525e652e Kalle Valo 2019-02-05 577 ret = -EINVAL; 258bbf525e652e Kalle Valo 2019-02-05 578 goto exit; 258bbf525e652e Kalle Valo 2019-02-05 579 } 258bbf525e652e Kalle Valo 2019-02-05 580 258bbf525e652e Kalle Valo 2019-02-05 581 if (ret) { d25cb35c6f10ac Sathishkumar Muruganandam 2019-02-13 582 ath11k_warn(ab, "failed to simulate firmware crash: %d\n", ret); 258bbf525e652e Kalle Valo 2019-02-05 583 goto exit; 258bbf525e652e Kalle Valo 2019-02-05 584 } 258bbf525e652e Kalle Valo 2019-02-05 585 258bbf525e652e Kalle Valo 2019-02-05 586 ret = count; 258bbf525e652e Kalle Valo 2019-02-05 587 258bbf525e652e Kalle Valo 2019-02-05 588 exit: 258bbf525e652e Kalle Valo 2019-02-05 589 return ret; 258bbf525e652e Kalle Valo 2019-02-05 590 } --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation