Hi Sergey,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.9-rc4 next-20200911]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Sergey-Senozhatsky/media-v4l2-re...
base:
git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-a004-20200911 (attached as .config)
compiler: clang version 12.0.0 (
https://github.com/llvm/llvm-project
0448d11a06b451a63a8f60408fec613ad24801ba)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/media/dvb-core/dvb_vb2.c:345:57: error: too many
arguments to function call, expected 3, have 4
ret =
vb2_core_reqbufs(&ctx->vb_q, VB2_MEMORY_MMAP, 0, &req->count);
~~~~~~~~~~~~~~~~ ^~~~~~~~~~~
include/media/videobuf2-core.h:770:5: note: 'vb2_core_reqbufs' declared here
int vb2_core_reqbufs(struct vb2_queue *q, enum vb2_memory memory,
^
1 error generated.
#
https://github.com/0day-ci/linux/commit/ef3d23bb3087aac00acdc21e175566608...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Sergey-Senozhatsky/media-v4l2-remove-V4L2-FLAG-MEMORY-NON-CONSISTENT-flag/20200911-110822
git checkout ef3d23bb3087aac00acdc21e175566608466f139
vim +345 drivers/media/dvb-core/dvb_vb2.c
57868acc369ab73 Satendra Singh Thakur 2017-12-18 332
57868acc369ab73 Satendra Singh Thakur 2017-12-18 333 int dvb_vb2_reqbufs(struct
dvb_vb2_ctx *ctx, struct dmx_requestbuffers *req)
57868acc369ab73 Satendra Singh Thakur 2017-12-18 334 {
57868acc369ab73 Satendra Singh Thakur 2017-12-18 335 int ret;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 336
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 337 /* Adjust size to a sane value */
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 338 if (req->size >
DVB_V2_MAX_SIZE)
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 339 req->size = DVB_V2_MAX_SIZE;
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 340
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 341 /* FIXME: round req->size to a
188 or 204 multiple */
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 342
57868acc369ab73 Satendra Singh Thakur 2017-12-18 343 ctx->buf_siz = req->size;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 344 ctx->buf_cnt = req->count;
7b4b45555c79db0 Sergey Senozhatsky 2020-05-14 @345 ret =
vb2_core_reqbufs(&ctx->vb_q, VB2_MEMORY_MMAP, 0, &req->count);
57868acc369ab73 Satendra Singh Thakur 2017-12-18 346 if (ret) {
57868acc369ab73 Satendra Singh Thakur 2017-12-18 347 ctx->state =
DVB_VB2_STATE_NONE;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 348 dprintk(1, "[%s] count=%d
size=%d errno=%d\n", ctx->name,
57868acc369ab73 Satendra Singh Thakur 2017-12-18 349 ctx->buf_cnt,
ctx->buf_siz, ret);
57868acc369ab73 Satendra Singh Thakur 2017-12-18 350 return ret;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 351 }
57868acc369ab73 Satendra Singh Thakur 2017-12-18 352 ctx->state |=
DVB_VB2_STATE_REQBUFS;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 353 dprintk(3, "[%s] count=%d
size=%d\n", ctx->name,
57868acc369ab73 Satendra Singh Thakur 2017-12-18 354 ctx->buf_cnt,
ctx->buf_siz);
57868acc369ab73 Satendra Singh Thakur 2017-12-18 355
57868acc369ab73 Satendra Singh Thakur 2017-12-18 356 return 0;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 357 }
57868acc369ab73 Satendra Singh Thakur 2017-12-18 358
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org