Re: [PATCH] dmaengine: dw-edma: Fix linked list physical address calculation on non-64 bits architectures
3:07 a.m.
Hi Gustavo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on v5.8 next-20200813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Gustavo-Pimentel/dmaengine-dw-ed...
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: x86_64-randconfig-m001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
drivers/dma/dw-edma/dw-edma-v0-core.c:233 dw_edma_v0_core_write_chunk() warn: inconsistent
indenting
drivers/dma/dw-edma/dw-edma-v0-core.c:266 dw_edma_v0_core_start() warn: inconsistent
indenting
vim +233 drivers/dma/dw-edma/dw-edma-v0-core.c
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 191
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 192 static void
dw_edma_v0_core_write_chunk(struct dw_edma_chunk *chunk)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 193 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 194 struct dw_edma_burst *child;
756c3ef93492af Arnd Bergmann 2019-07-22 195 struct dw_edma_v0_lli __iomem *lli;
756c3ef93492af Arnd Bergmann 2019-07-22 196 struct dw_edma_v0_llp __iomem *llp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 197 u32 control = 0, i = 0;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 198 int j;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 199
756c3ef93492af Arnd Bergmann 2019-07-22 200 lli = chunk->ll_region.vaddr;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 201
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 202 if (chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 203 control = DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 204
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 205 j = chunk->bursts_alloc;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 206 list_for_each_entry(child,
&chunk->burst->list, list) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 207 j--;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 208 if (!j)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 209 control |= (DW_EDMA_V0_LIE |
DW_EDMA_V0_RIE);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 210
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 211 /* Channel control */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 212 SET_LL(&lli[i].control, control);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 213 /* Transfer size */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 214 SET_LL(&lli[i].transfer_size,
child->sz);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 215 /* SAR - low, high */
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 216 SET_LL(&lli[i].sar_low,
lower_32_bits(child->sar));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 217 SET_LL(&lli[i].sar_high,
upper_32_bits(child->sar));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 218 /* DAR - low, high */
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 219 SET_LL(&lli[i].dar_low,
lower_32_bits(child->dar));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 220 SET_LL(&lli[i].dar_high,
upper_32_bits(child->dar));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 221 i++;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 222 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 223
756c3ef93492af Arnd Bergmann 2019-07-22 224 llp = (void __iomem *)&lli[i];
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 225 control = DW_EDMA_V0_LLP |
DW_EDMA_V0_TCB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 226 if (!chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 227 control |= DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 228
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 229 /* Channel control */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 230 SET_LL(&llp->control, control);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 231 /* Linked list - low, high */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 232 #ifdef CONFIG_PHYS_ADDR_T_64BIT
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 @233 SET_LL(&llp->llp_low,
lower_32_bits(chunk->ll_region.paddr));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 234 SET_LL(&llp->llp_high,
upper_32_bits(chunk->ll_region.paddr));
c6442f1a5db52e Gustavo Pimentel 2020-08-13 235 #else /* CONFIG_PHYS_ADDR_T_64BIT */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 236 SET_LL(&llp->llp_low,
chunk->ll_region.paddr);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 237 SET_LL(&llp->llp_high, 0x0);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 238 #endif /* CONFIG_PHYS_ADDR_T_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 239 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 240
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 241 void dw_edma_v0_core_start(struct
dw_edma_chunk *chunk, bool first)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 242 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 243 struct dw_edma_chan *chan =
chunk->chan;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 244 struct dw_edma *dw =
chan->chip->dw;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 245 u32 tmp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 246
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 247 dw_edma_v0_core_write_chunk(chunk);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 248
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 249 if (first) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 250 /* Enable engine */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 251 SET_RW(dw, chan->dir, engine_en,
BIT(0));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 252 /* Interrupt unmask - done, abort */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 253 tmp = GET_RW(dw, chan->dir,
int_mask);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 254 tmp &=
~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 255 tmp &=
~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 256 SET_RW(dw, chan->dir, int_mask,
tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 257 /* Linked list error */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 258 tmp = GET_RW(dw, chan->dir,
linked_list_err_en);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 259 tmp |=
FIELD_PREP(EDMA_V0_LINKED_LIST_ERR_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 260 SET_RW(dw, chan->dir,
linked_list_err_en, tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 261 /* Channel control */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 262 SET_CH(dw, chan->dir, chan->id,
ch_control1,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 263 (DW_EDMA_V0_CCS |
DW_EDMA_V0_LLE));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 264 /* Linked list - low, high */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 265 #ifdef CONFIG_PHYS_ADDR_T_64BIT
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 @266 SET_CH(dw, chan->dir, chan->id,
llp_low,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 267
lower_32_bits(chunk->ll_region.paddr));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 268 SET_CH(dw, chan->dir, chan->id,
llp_high,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 269
upper_32_bits(chunk->ll_region.paddr));
c6442f1a5db52e Gustavo Pimentel 2020-08-13 270 #else /* CONFIG_PHYS_ADDR_T_64BIT */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 271 SET_CH(dw, chan->dir, chan->id,
llp_low,
c6442f1a5db52e Gustavo Pimentel 2020-08-13 272 chunk->ll_region.paddr);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 273 SET_CH(dw, chan->dir, chan->id,
llp_high, 0x0);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 274 #endif /* CONFIG_PHYS_ADDR_T_64BIT*/
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 275 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 276 /* Doorbell */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 277 SET_RW(dw, chan->dir, doorbell,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 278
FIELD_PREP(EDMA_V0_DOORBELL_CH_MASK, chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 279 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 280
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
768
days inactive
768
days old
0 comments
1 participants
participants (1)
-
kernel test robot