[android-goldfish:android-3.18 17430/19089] sound/pci/hda/hda_intel.c:2008:8: error: 'power_save' undeclared - kbuild-all

Saturday, 13 November 2021

tree:   https://android.googlesource.com/kernel/goldfish android-3.18
head:   839523fca2efc7b0ccdc24fba1b28c4a67bc1c7d
commit: 43d4b9958d3eb75bcce2502455e5f599dda27e07 [17430/19089] ALSA: hda: Add a power_save
blacklist
config: alpha-randconfig-r015-20211019 (attached as .config)
compiler: alpha-linux-gcc (GCC) 5.5.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add android-goldfish https://android.googlesource.com/kernel/goldfish
        git fetch --no-tags android-goldfish android-3.18
        git checkout 43d4b9958d3eb75bcce2502455e5f599dda27e07
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-5.5.0 make.cross O=build_dir
ARCH=alpha SHELL=/bin/bash sound/pci/hda/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

All error/warnings (new ones prefixed by >>):

   In file included from sound/pci/hda/hda_codec.h:26:0,
                    from sound/pci/hda/hda_intel.c:63:
   include/sound/pcm.h: In function 'snd_pcm_chmap_substream':
   include/sound/pcm.h:1243:17: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
      if (s->number == idx)
                    ^
   sound/pci/hda/hda_intel.c: In function 'azx_get_delay_from_lpib':
   sound/pci/hda/hda_intel.c:531:12: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
     if (delay >= azx_dev->period_bytes) {
               ^
   sound/pci/hda/hda_intel.c: In function 'azx_probe_continue':
...
> sound/pci/hda/hda_intel.c:2008:8: error: 'power_save'
undeclared (first use in this function)      val = power_save;
           ^
   sound/pci/hda/hda_intel.c:2008:8: note: each undeclared identifier is reported only
once for each function it appears in
...
> sound/pci/hda/hda_intel.c:1935:6: warning: variable 'val'
set but not used [-Wunused-but-set-variable]      int val;
         ^

vim +/power_save +2008 sound/pci/hda/hda_intel.c

  1929	
  1930	static int azx_probe_continue(struct azx *chip)
  1931	{
  1932		struct hda_intel *hda = container_of(chip, struct hda_intel, chip);
  1933		struct pci_dev *pci = chip->pci;
  1934		int dev = chip->dev_index;
...
 1935		int val;   1936		int err;
  1937	
  1938		/* Request power well for Haswell HDA controller and codec */
  1939		if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL) {
  1940	#ifdef CONFIG_SND_HDA_I915
  1941			err = hda_i915_init();
  1942			if (err < 0) {
  1943				dev_err(chip->card->dev,
  1944					"Error request power-well from i915\n");
  1945				goto out_free;
  1946			}
  1947			err = hda_display_power(true);
  1948			if (err < 0) {
  1949				dev_err(chip->card->dev,
  1950					"Cannot turn on display power on i915\n");
  1951				goto out_free;
  1952			}
  1953	#endif
  1954		}
  1955	
  1956		err = azx_first_init(chip);
  1957		if (err < 0)
  1958			goto out_free;
  1959	
  1960	#ifdef CONFIG_SND_HDA_INPUT_BEEP
  1961		chip->beep_mode = beep_mode[dev];
  1962	#endif
  1963	
  1964		/* create codec instances */
  1965		err = azx_codec_create(chip, model[dev],
  1966				       azx_max_codecs[chip->driver_type],
  1967				       power_save_addr);
  1968	
  1969		if (err < 0)
  1970			goto out_free;
  1971	#ifdef CONFIG_SND_HDA_PATCH_LOADER
  1972		if (chip->fw) {
  1973			err = snd_hda_load_patch(chip->bus, chip->fw->size,
  1974						 chip->fw->data);
  1975			if (err < 0)
  1976				goto out_free;
  1977	#ifndef CONFIG_PM
  1978			release_firmware(chip->fw); /* no longer needed */
  1979			chip->fw = NULL;
  1980	#endif
  1981		}
  1982	#endif
  1983		if ((probe_only[dev] & 1) == 0) {
  1984			err = azx_codec_configure(chip);
  1985			if (err < 0)
  1986				goto out_free;
  1987		}
  1988	
  1989		/* create PCM streams */
  1990		err = snd_hda_build_pcms(chip->bus);
  1991		if (err < 0)
  1992			goto out_free;
  1993	
  1994		/* create mixer controls */
  1995		err = azx_mixer_create(chip);
  1996		if (err < 0)
  1997			goto out_free;
  1998	
  1999		err = snd_card_register(chip->card);
  2000		if (err < 0)
  2001			goto out_free;
  2002	
  2003		chip->running = 1;
  2004		power_down_all_codecs(chip);
  2005		azx_notifier_register(chip);
  2006		azx_add_card_list(chip);
  2007	
...
 2008		val = power_save;   2009	#ifdef CONFIG_PM
  2010		if (val == -1) {
  2011			const struct snd_pci_quirk *q;
  2012	
  2013			val = CONFIG_SND_HDA_POWER_SAVE_DEFAULT;
  2014			q = snd_pci_quirk_lookup(chip->pci, power_save_blacklist);
  2015			if (q && val) {
  2016				dev_info(chip->card->dev, "device %04x:%04x is on the power_save
blacklist, forcing power_save to 0\n",
  2017					 q->subvendor, q->subdevice);
  2018				val = 0;
  2019			}
  2020		}
  2021	#endif /* CONFIG_PM */
  2022		if ((chip->driver_caps & AZX_DCAPS_PM_RUNTIME) ||
hda->use_vga_switcheroo)
  2023			pm_runtime_put_noidle(&pci->dev);
  2024	
  2025	out_free:
  2026		if (err < 0)
  2027			hda->init_failed = 1;
  2028		complete_all(&hda->probe_wait);
  2029		return err;
  2030	}
  2031	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org