Hi Dafna, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v5.7-rc5 next-20200512] [cannot apply to staging/staging-testing] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Dafna-Hirschfeld/media-staging-r... base: git://linuxtv.org/media_tree.git master config: nios2-allyesconfig (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=nios2 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from drivers/staging/media/rkisp1/rkisp1-capture.c:21: 308 | irqreturn_t rkisp1_isp_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-common.h:309:1: error: unknown type name 'irqreturn_t' 309 | irqreturn_t rkisp1_mipi_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-common.h:310:1: error: unknown type name 'irqreturn_t' 310 | irqreturn_t rkisp1_capture_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ 652 | irqreturn_t rkisp1_capture_isr(struct rkisp1_device *rkisp1) | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-capture.c: In function 'rkisp1_capture_isr': 659 | return IRQ_NONE; | ^~~~~~~~ drivers/staging/media/rkisp1/rkisp1-capture.c:659:10: note: each undeclared identifier is reported only once for each function it appears in 689 | return IRQ_HANDLED; | ^~~~~~~~~~~ 690 | } | ^ -- In file included from drivers/staging/media/rkisp1/rkisp1-common.c:10: 308 | irqreturn_t rkisp1_isp_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-common.h:309:1: error: unknown type name 'irqreturn_t' 309 | irqreturn_t rkisp1_mipi_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-common.h:310:1: error: unknown type name 'irqreturn_t' 310 | irqreturn_t rkisp1_capture_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ -- In file included from drivers/staging/media/rkisp1/rkisp1-isp.c:19: 308 | irqreturn_t rkisp1_isp_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-common.h:309:1: error: unknown type name 'irqreturn_t' 309 | irqreturn_t rkisp1_mipi_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-common.h:310:1: error: unknown type name 'irqreturn_t' 310 | irqreturn_t rkisp1_capture_isr(struct rkisp1_device *rkisp1); | ^~~~~~~~~~~ 1049 | irqreturn_t rkisp1_mipi_isr(struct rkisp1_device *rkisp1) | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-isp.c: In function 'rkisp1_mipi_isr': 1055 | return IRQ_NONE; | ^~~~~~~~ drivers/staging/media/rkisp1/rkisp1-isp.c:1055:10: note: each undeclared identifier is reported only once for each function it appears in 1091 | return IRQ_HANDLED; | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-isp.c: At top level: drivers/staging/media/rkisp1/rkisp1-isp.c:1111:1: error: unknown type name 'irqreturn_t' 1111 | irqreturn_t rkisp1_isp_isr(struct rkisp1_device *rkisp1) | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-isp.c: In function 'rkisp1_isp_isr': drivers/staging/media/rkisp1/rkisp1-isp.c:1117:10: error: 'IRQ_NONE' undeclared (first use in this function) 1117 | return IRQ_NONE; | ^~~~~~~~ drivers/staging/media/rkisp1/rkisp1-isp.c:1154:9: error: 'IRQ_HANDLED' undeclared (first use in this function) 1154 | return IRQ_HANDLED; | ^~~~~~~~~~~ drivers/staging/media/rkisp1/rkisp1-isp.c: In function 'rkisp1_mipi_isr': 1092 | } | ^ drivers/staging/media/rkisp1/rkisp1-isp.c: In function 'rkisp1_isp_isr': drivers/staging/media/rkisp1/rkisp1-isp.c:1155:1: warning: control reaches end of non-void function [-Wreturn-type] 1155 | } | ^ vim +/irqreturn_t +308 drivers/staging/media/rkisp1/rkisp1-common.h 307 309 irqreturn_t rkisp1_mipi_isr(struct rkisp1_device *rkisp1); 310 irqreturn_t rkisp1_capture_isr(struct rkisp1_device *rkisp1); 311 void rkisp1_stats_isr(struct rkisp1_stats *stats, u32 isp_ris); 312 void rkisp1_params_isr(struct rkisp1_device *rkisp1, u32 isp_mis); 313 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org