Hi Sven,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.8-rc2 next-20200623]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Sven-Van-Asbroeck/address-romfs-...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
5e857ce6eae7ca21b2055cca4885545e29228fe2
config: i386-randconfig-r015-20200623 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld: fs/romfs/super.o: in function `romfs_largest_blocksize':
> fs/romfs/super.c:505: undefined reference to `__moddi3'
vim +505 fs/romfs/super.c
494
495 /*
496 * pick the largest blocksize which the underlying block device
497 * is a multiple of. Or fall back to legacy (ROMBSIZE).
498 */
499 static int romfs_largest_blocksize(struct super_block *sb)
500 {
501 loff_t device_sz = i_size_read(sb->s_bdev->bd_inode);
502 int blksz;
503
504 for (blksz = PAGE_SIZE; blksz > ROMBSIZE; blksz >>= 1)
505 if ((device_sz % blksz) == 0)
506 break;
507
508 return blksz;
509 }
510
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org