Hi Lee, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on wireless-drivers/master v5.10-rc7] [cannot apply to ath6kl/ath-next next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Lee-Jones/Rid-W-1-warnings-in-Wi... base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-ne... master config: x86_64-randconfig-a016-20200709 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2e11c85c85de08cf0fe31c86b3695dfe1... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Lee-Jones/Rid-W-1-warnings-in-Wireless/20201126-213522 git checkout 2e11c85c85de08cf0fe31c86b3695dfe1f2d13e3 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): ld: drivers/net/wireless/realtek/rtw88/rtw8723de.o:drivers/net/wireless/realtek/rtw88/pci.h:217: multiple definition of `rtw_pm_ops'; drivers/net/wireless/realtek/rtw88/rtw8822be.o:drivers/net/wireless/realtek/rtw88/pci.h:217: first defined here ld: drivers/net/wireless/realtek/rtw88/pci.o:drivers/net/wireless/realtek/rtw88/pci.h:217: multiple definition of `rtw_pm_ops'; drivers/net/wireless/realtek/rtw88/rtw8822be.o:drivers/net/wireless/realtek/rtw88/pci.h:217: first defined here --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org