Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on crypto/master soc/for-next linus/master v5.13-rc1 next-20210511] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Linus-Walleij/crypto-ixp4xx-conv... base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/34e7de59a25815f4769a4f0879c30d5ea... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Linus-Walleij/crypto-ixp4xx-convert-to-platform-driver/20210511-053835 git checkout 34e7de59a25815f4769a4f0879c30d5ea700b1a1 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `ixp_crypto_probe': ixp4xx_crypto.c:(.text+0xc60): undefined reference to `npe_names' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xc88): undefined reference to `npe_names' m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `register_chain_var': m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `setup_cipher': ixp4xx_crypto.c:(.text+0x64c): undefined reference to `qmgr_put_entry' m68k-linux-ld: ixp4xx_crypto.c:(.text+0x656): undefined reference to `qmgr_stat_overflow' m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `ixp_crypto_remove': m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `ixp_crypto_probe': ixp4xx_crypto.c:(.text+0xb84): undefined reference to `npe_request' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xb9a): undefined reference to `npe_running' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xbae): undefined reference to `npe_names' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xbbe): undefined reference to `npe_load_firmware' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xbde): undefined reference to `npe_recv_message' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xc1e): undefined reference to `npe_send_message' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xc3c): undefined reference to `npe_recv_message' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xc4a): undefined reference to `npe_names' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xca0): undefined reference to `npe_release' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xd10): undefined reference to `__qmgr_request_queue' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xd44): undefined reference to `qmgr_release_queue' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xd62): undefined reference to `qmgr_set_irq' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xd7e): undefined reference to `qmgr_enable_irq' m68k-linux-ld: ixp4xx_crypto.c:(.text+0xf88): undefined reference to `npe_release' m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `crypto_done_action': m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `ablk_perform': m68k-linux-ld: ixp4xx_crypto.c:(.text+0x1798): undefined reference to `qmgr_stat_overflow' m68k-linux-ld: drivers/crypto/ixp4xx_crypto.o: in function `aead_perform.isra.0': ixp4xx_crypto.c:(.text+0x18dc): undefined reference to `qmgr_stat_full' m68k-linux-ld: ixp4xx_crypto.c:(.text+0x1a86): undefined reference to `qmgr_put_entry' m68k-linux-ld: ixp4xx_crypto.c:(.text+0x1a90): undefined reference to `qmgr_stat_overflow' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org