Re: [PATCH 7/8] mac80211: remove WDS-related code

Wednesday, 11 November 2020

Hi Johannes,

I love your patch! Perhaps something to improve:

[auto build test WARNING on mac80211-next/master]
[also build test WARNING on mac80211/master wireless-drivers-next/master v5.10-rc3
next-20201111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:   
https://github.com/0day-ci/linux/commits/Johannes-Berg/wireless-remove-CO...
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: arm64-randconfig-r013-20201109 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
09ec07827b1128504457a93dee80b2ceee1af600)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        #
https://github.com/0day-ci/linux/commit/c57a74c8fb0ee0e2f65123e27dff3c488...
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review
Johannes-Berg/wireless-remove-CONFIG_WIRELESS_WDS/20201109-175921
        git checkout c57a74c8fb0ee0e2f65123e27dff3c4887fd9c07
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

All warnings (new ones prefixed by >>):

   net/mac80211/iface.c:1015:19: warning: unused variable 'sta'
[-Wunused-variable]
           struct sta_info *sta;
                            ^
...
> net/mac80211/iface.c:1507:10: warning: enumeration value
'NL80211_IFTYPE_WDS' not handled in switch [-Wswitch]            switch
(type) {
                   ^
   2 warnings generated.

vim +/NL80211_IFTYPE_WDS +1507 net/mac80211/iface.c

1fa57d017366fb2 net/mac80211/iface.c           Johannes Berg       2010-06-10  1466  
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1467  /*
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1468   *
Helper function to initialise an interface to a specific type.
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1469   */
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1470 
static void ieee80211_setup_sdata(struct ieee80211_sub_if_data *sdata,
05c914fe330fa8e net/mac80211/iface.c           Johannes Berg       2008-09-11  1471  				 
enum nl80211_iftype type)
f0706e828e96d0f net/mac80211/ieee80211_iface.c Jiri Benc           2007-05-05  1472  {
239281f803e2efd net/mac80211/iface.c           Rostislav Lisovy    2014-11-03  1473 
	static const u8 bssid_wildcard[ETH_ALEN] = {0xff, 0xff, 0xff,
239281f803e2efd net/mac80211/iface.c           Rostislav Lisovy    2014-11-03  1474 
						    0xff, 0xff, 0xff};
239281f803e2efd net/mac80211/iface.c           Rostislav Lisovy    2014-11-03  1475  
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1476  	/*
clear type-dependent union */
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1477 
	memset(&sdata->u, 0, sizeof(sdata->u));
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1478  
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1479  	/*
and set some type-dependent values */
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1480 
	sdata->vif.type = type;
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1481 
	sdata->vif.p2p = false;
60719ffd721f676 net/mac80211/iface.c           Johannes Berg       2008-09-16  1482 
	sdata->wdev.iftype = type;
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1483  
a621fa4d6a7fdf9 net/mac80211/iface.c           Johannes Berg       2010-08-27  1484 
	sdata->control_port_protocol = cpu_to_be16(ETH_P_PAE);
a621fa4d6a7fdf9 net/mac80211/iface.c           Johannes Berg       2010-08-27  1485 
	sdata->control_port_no_encrypt = false;
7f3f96cedd79e36 net/mac80211/iface.c           Markus Theil        2020-03-12  1486 
	sdata->control_port_over_nl80211 = false;
7f3f96cedd79e36 net/mac80211/iface.c           Markus Theil        2020-03-12  1487 
	sdata->control_port_no_preauth = false;
2475b1cc0d5283a net/mac80211/iface.c           Max Stepanov        2013-03-24  1488 
	sdata->encrypt_headroom = IEEE80211_ENCRYPT_HEADROOM;
d3a58df87a2e4c2 net/mac80211/iface.c           Avraham Stern       2014-05-22  1489 
	sdata->vif.bss_conf.idle = true;
db6d9e9e8b48b7a net/mac80211/iface.c           Ben Greear          2019-12-17  1490 
	sdata->vif.bss_conf.txpower = INT_MIN; /* unset */
a621fa4d6a7fdf9 net/mac80211/iface.c           Johannes Berg       2010-08-27  1491  
b53be7920bd9bb1 net/mac80211/iface.c           Simon Wunderlich    2011-11-18  1492 
	sdata->noack_map = 0;
b53be7920bd9bb1 net/mac80211/iface.c           Simon Wunderlich    2011-11-18  1493  
f142c6b906da451 net/mac80211/iface.c           Johannes Berg       2012-06-18  1494  	/*
only monitor/p2p-device differ */
f142c6b906da451 net/mac80211/iface.c           Johannes Berg       2012-06-18  1495  	if
(sdata->dev) {
f142c6b906da451 net/mac80211/iface.c           Johannes Berg       2012-06-18  1496 
		sdata->dev->netdev_ops = &ieee80211_dataif_ops;
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1497 
		sdata->dev->type = ARPHRD_ETHER;
f142c6b906da451 net/mac80211/iface.c           Johannes Berg       2012-06-18  1498  	}
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1499  
35f20c14a103ca2 net/mac80211/iface.c           Johannes Berg       2010-06-10  1500 
	skb_queue_head_init(&sdata->skb_queue);
1fa57d017366fb2 net/mac80211/iface.c           Johannes Berg       2010-06-10  1501 
	INIT_WORK(&sdata->work, ieee80211_iface_work);
04ecd2578e712c3 net/mac80211/iface.c           Johannes Berg       2012-09-11  1502 
	INIT_WORK(&sdata->recalc_smps, ieee80211_recalc_smps_work);
73da7d5bab79ad7 net/mac80211/iface.c           Simon Wunderlich    2013-07-11  1503 
	INIT_WORK(&sdata->csa_finalize_work, ieee80211_csa_finalize_work);
484298ad1afaf24 net/mac80211/iface.c           Michal Kazior       2014-04-09  1504 
	INIT_LIST_HEAD(&sdata->assigned_chanctx_list);
e3afb920227d37f net/mac80211/iface.c           Michal Kazior       2014-04-09  1505 
	INIT_LIST_HEAD(&sdata->reserved_chanctx_list);
35f20c14a103ca2 net/mac80211/iface.c           Johannes Berg       2010-06-10  1506  
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09 @1507 
	switch (type) {
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1508  	case
NL80211_IFTYPE_P2P_GO:
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1509 
		type = NL80211_IFTYPE_AP;
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1510 
		sdata->vif.type = type;
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1511 
		sdata->vif.p2p = true;
fc0561dc6a9c616 net/mac80211/iface.c           Gustavo A. R. Silva 2020-07-07  1512 
		fallthrough;
05c914fe330fa8e net/mac80211/iface.c           Johannes Berg       2008-09-11  1513  	case
NL80211_IFTYPE_AP:
d012a605108a482 net/mac80211/iface.c           Marco Porsch        2012-10-10  1514 
		skb_queue_head_init(&sdata->u.ap.ps.bc_buf);
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1515 
		INIT_LIST_HEAD(&sdata->u.ap.vlans);
ad2d223aa900179 net/mac80211/iface.c           Johannes Berg       2012-12-14  1516 
		sdata->vif.bss_conf.bssid = sdata->vif.addr;
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1517 
		break;
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1518  	case
NL80211_IFTYPE_P2P_CLIENT:
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1519 
		type = NL80211_IFTYPE_STATION;
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1520 
		sdata->vif.type = type;
2ca27bcff7127da net/mac80211/iface.c           Johannes Berg       2010-09-16  1521 
		sdata->vif.p2p = true;
fc0561dc6a9c616 net/mac80211/iface.c           Gustavo A. R. Silva 2020-07-07  1522 
		fallthrough;
05c914fe330fa8e net/mac80211/iface.c           Johannes Berg       2008-09-11  1523  	case
NL80211_IFTYPE_STATION:
ad2d223aa900179 net/mac80211/iface.c           Johannes Berg       2012-12-14  1524 
		sdata->vif.bss_conf.bssid = sdata->u.mgd.bssid;
9c6bd79011b14a8 net/mac80211/iface.c           Johannes Berg       2008-09-11  1525 
		ieee80211_sta_setup_sdata(sdata);
472dbc45dc19662 net/mac80211/iface.c           Johannes Berg       2008-09-11  1526 
		break;
6e0bd6c35b021dc net/mac80211/iface.c           Rostislav Lisovy    2014-11-03  1527  	case
NL80211_IFTYPE_OCB:
239281f803e2efd net/mac80211/iface.c           Rostislav Lisovy    2014-11-03  1528 
		sdata->vif.bss_conf.bssid = bssid_wildcard;
239281f803e2efd net/mac80211/iface.c           Rostislav Lisovy    2014-11-03  1529 
		ieee80211_ocb_setup_sdata(sdata);
6e0bd6c35b021dc net/mac80211/iface.c           Rostislav Lisovy    2014-11-03  1530 
		break;
469002983fc90c2 net/mac80211/iface.c           Johannes Berg       2009-02-15  1531  	case
NL80211_IFTYPE_ADHOC:
ad2d223aa900179 net/mac80211/iface.c           Johannes Berg       2012-12-14  1532 
		sdata->vif.bss_conf.bssid = sdata->u.ibss.bssid;
469002983fc90c2 net/mac80211/iface.c           Johannes Berg       2009-02-15  1533 
		ieee80211_ibss_setup_sdata(sdata);
469002983fc90c2 net/mac80211/iface.c           Johannes Berg       2009-02-15  1534 
		break;
05c914fe330fa8e net/mac80211/iface.c           Johannes Berg       2008-09-11  1535  	case
NL80211_IFTYPE_MESH_POINT:
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1536  		if
(ieee80211_vif_is_mesh(&sdata->vif))
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1537 
			ieee80211_mesh_init_sdata(sdata);
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1538 
		break;
05c914fe330fa8e net/mac80211/iface.c           Johannes Berg       2008-09-11  1539  	case
NL80211_IFTYPE_MONITOR:
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1540 
		sdata->dev->type = ARPHRD_IEEE80211_RADIOTAP;
587e729ecff9594 net/mac80211/iface.c           Johannes Berg       2009-01-30  1541 
		sdata->dev->netdev_ops = &ieee80211_monitorif_ops;
d82121845d44334 net/mac80211/iface.c           Aviya Erenfeld      2016-08-29  1542 
		sdata->u.mntr.flags = MONITOR_FLAG_CONTROL |
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1543  				 
    MONITOR_FLAG_OTHER_BSS;
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1544 
		break;
167e33f4f68cc8e net/mac80211/iface.c           Ayala Beker         2016-09-20  1545  	case
NL80211_IFTYPE_NAN:
167e33f4f68cc8e net/mac80211/iface.c           Ayala Beker         2016-09-20  1546 
		idr_init(&sdata->u.nan.function_inst_ids);
167e33f4f68cc8e net/mac80211/iface.c           Ayala Beker         2016-09-20  1547 
		spin_lock_init(&sdata->u.nan.func_lock);
167e33f4f68cc8e net/mac80211/iface.c           Ayala Beker         2016-09-20  1548 
		sdata->vif.bss_conf.bssid = sdata->vif.addr;
167e33f4f68cc8e net/mac80211/iface.c           Ayala Beker         2016-09-20  1549 
		break;
05c914fe330fa8e net/mac80211/iface.c           Johannes Berg       2008-09-11  1550  	case
NL80211_IFTYPE_AP_VLAN:
98104fdeda63d57 net/mac80211/iface.c           Johannes Berg       2012-06-16  1551  	case
NL80211_IFTYPE_P2P_DEVICE:
ad2d223aa900179 net/mac80211/iface.c           Johannes Berg       2012-12-14  1552 
		sdata->vif.bss_conf.bssid = sdata->vif.addr;
f142c6b906da451 net/mac80211/iface.c           Johannes Berg       2012-06-18  1553 
		break;
05c914fe330fa8e net/mac80211/iface.c           Johannes Berg       2008-09-11  1554  	case
NL80211_IFTYPE_UNSPECIFIED:
2e161f78e5f63a7 net/mac80211/iface.c           Johannes Berg       2010-08-12  1555  	case
NUM_NL80211_IFTYPES:
c7976f5272486e4 net/mac80211/iface.c           Luca Coelho         2017-10-29  1556 
		WARN_ON(1);
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1557 
		break;
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1558  	}
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1559  
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1560 
	ieee80211_debugfs_add_netdev(sdata);
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1561  }
75636525fbfa78f net/mac80211/iface.c           Johannes Berg       2008-07-09  1562  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019