[android-common:android12-5.4 5/9] drivers/dma-buf/heaps/deferred-free-helper.c:23:19: sparse: sparse: symbol 'freelist_waitqueue' was not declared. Should it be static?
8:24 a.m.
Hi John,
First bad commit (maybe != root cause):
tree: https://android.googlesource.com/kernel/common android12-5.4
head: 82c67a98c7494b4e71dcbea03335509e9ccecfa5
commit: e3919bfeb0066ab9b5f9765e5610b95672990e64 [5/9] ANDROID: dma-buf: system_heap: Add
deferred freeing to the system heap
config: i386-randconfig-s001-20210812 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-348-gf0e6938b-dirty
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android12-5.4
git checkout e3919bfeb0066ab9b5f9765e5610b95672990e64
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/dma-buf/heaps/ kernel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> drivers/dma-buf/heaps/deferred-free-helper.c:23:19: sparse:
sparse: symbol 'freelist_waitqueue' was not declared. Should it be static?
> drivers/dma-buf/heaps/deferred-free-helper.c:24:20: sparse: sparse: symbol
'freelist_task' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
8:24 a.m.
New subject: [RFC PATCH android-common] ANDROID: dma-buf: system_heap: freelist_waitqueue can be static
drivers/dma-buf/heaps/deferred-free-helper.c:23:19: warning: symbol
'freelist_waitqueue' was not declared. Should it be static?
drivers/dma-buf/heaps/deferred-free-helper.c:24:20: warning: symbol
'freelist_task' was not declared. Should it be static?
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
deferred-free-helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/heaps/deferred-free-helper.c
b/drivers/dma-buf/heaps/deferred-free-helper.c
index dd09c4b1271cf..fb54d28c917b6 100644
--- a/drivers/dma-buf/heaps/deferred-free-helper.c
+++ b/drivers/dma-buf/heaps/deferred-free-helper.c
@@ -20,8 +20,8 @@
static LIST_HEAD(free_list);
static size_t list_nr_pages;
-wait_queue_head_t freelist_waitqueue;
-struct task_struct *freelist_task;
+static wait_queue_head_t freelist_waitqueue;
+static struct task_struct *freelist_task;
static DEFINE_SPINLOCK(free_list_lock);
void deferred_free(struct deferred_freelist_item *item,
404
days inactive
404
days old
1 comments
1 participants
participants (1)
-
kernel test robot