Hi Hans,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip linus/master v5.12-rc8 next-20210421]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Hans-de-Goede/drm-Add-privacy-sc...
base:
git://anongit.freedesktop.org/drm-intel for-linux-next
config: sparc64-randconfig-p002-20210421 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/62771e46e3031f0e2cea9529f292b6415...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Hans-de-Goede/drm-Add-privacy-screen-class-and-connector-properties/20210422-045141
git checkout 62771e46e3031f0e2cea9529f292b6415810cf9c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/drm_connector.c: In function
'drm_connector_privacy_screen_notifier':
> drivers/gpu/drm/drm_connector.c:2380:44: warning:
'sw_state' is used uninitialized in this function [-Wuninitialized]
2380
| connector->state->privacy_screen_sw_state = sw_state;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
drivers/gpu/drm/drm_connector.c:2375:33: note: 'sw_state' was declared here
2375 | enum drm_privacy_screen_status sw_state, hw_state;
| ^~~~~~~~
> drivers/gpu/drm/drm_connector.c:2381:2: warning:
'hw_state' is used uninitialized in this function [-Wuninitialized]
2381
| drm_object_property_set_value(&connector->base,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2382 | connector->privacy_screen_hw_state_property, hw_state);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_connector.c:2375:43: note: 'hw_state' was declared here
2375 | enum drm_privacy_screen_status sw_state, hw_state;
| ^~~~~~~~
drivers/gpu/drm/drm_connector.c: In function
'drm_connector_attach_privacy_screen_provider':
> drivers/gpu/drm/drm_connector.c:2380:44: warning:
'sw_state' is used uninitialized in this function [-Wuninitialized]
2380
| connector->state->privacy_screen_sw_state = sw_state;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
drivers/gpu/drm/drm_connector.c:2375:33: note: 'sw_state' was declared here
2375 | enum drm_privacy_screen_status sw_state, hw_state;
| ^~~~~~~~
> drivers/gpu/drm/drm_connector.c:2381:2: warning:
'hw_state' is used uninitialized in this function [-Wuninitialized]
2381
| drm_object_property_set_value(&connector->base,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2382 | connector->privacy_screen_hw_state_property, hw_state);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_connector.c:2375:43: note: 'hw_state' was declared here
2375 | enum drm_privacy_screen_status sw_state, hw_state;
| ^~~~~~~~
vim +/sw_state +2380 drivers/gpu/drm/drm_connector.c
2371
2372 static void drm_connector_update_privacy_screen_properties(
2373 struct drm_connector *connector)
2374 {
2375 enum drm_privacy_screen_status sw_state, hw_state;
2376
2377 drm_privacy_screen_get_state(connector->privacy_screen,
2378 &sw_state, &hw_state);
2379
2380 connector->state->privacy_screen_sw_state = sw_state;
2381 drm_object_property_set_value(&connector->base,
2382 connector->privacy_screen_hw_state_property, hw_state);
2383 }
2384
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org