Hi Kate, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210816] [cannot apply to linus/master v5.14-rc6 v5.14-rc5 v5.14-rc4 v5.14-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kate-Hsuan/Intel-platform-driver... base: b9011c7e671dbbf59bb753283ddfd03f0c9eb865 config: x86_64-buildonly-randconfig-r004-20210816 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/30a4d97d4248adef672f46eeb0e32b816... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Kate-Hsuan/Intel-platform-driver-code-movement/20210816-185713 git checkout 30a4d97d4248adef672f46eeb0e32b816b6f531c # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): ld: drivers/mfd/intel_pmc_bxt.o: in function `simplecmd_store': ld: drivers/mfd/intel_pmc_bxt.o: in function `northpeak_store': intel_pmc_bxt.c:(.text+0xb8): undefined reference to `intel_scu_ipc_dev_simple_command' ld: drivers/mfd/intel_pmc_bxt.o: in function `intel_pmc_probe': ld: drivers/mfd/intel_soc_pmic_bxtwc.o: in function `regmap_ipc_byte_reg_write': ld: drivers/mfd/intel_soc_pmic_bxtwc.o: in function `regmap_ipc_byte_reg_read': intel_soc_pmic_bxtwc.c:(.text+0x34e): undefined reference to `intel_scu_ipc_dev_command_with_size' ld: drivers/mfd/intel_soc_pmic_bxtwc.o: in function `bxtwc_probe': Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for INTEL_SCU_IPC Depends on X86 && X86_PLATFORM_DEVICES && X86_PLATFORM_DRIVERS_INTEL Selected by - MFD_INTEL_PMC_BXT && HAS_IOMEM && X86 && X86_PLATFORM_DEVICES && ACPI --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org