[song-md:md-next 15/16] drivers/md/raid10.c:1763:8-9: WARNING: return of 0/1 in function 'raid10_handle_discard' with return type bool
10:30 a.m.
tree: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
head: 5b2374a6c221f28c74913d208bb5376a7ee3bf70
commit: 8f694215ae4c7abf1e6c985803a1aad0db748d07 [15/16] md/raid10: improve raid10 discard
request
config: i386-randconfig-c001-20200921 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
coccinelle warnings: (new ones prefixed by >>)
> drivers/md/raid10.c:1763:8-9: WARNING: return of 0/1 in function
'raid10_handle_discard' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10:30 a.m.
New subject: [PATCH] md/raid10: fix boolreturn.cocci warnings
From: kernel test robot <lkp(a)intel.com>
drivers/md/raid10.c:1763:8-9: WARNING: return of 0/1 in function
'raid10_handle_discard' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 8f694215ae4c ("md/raid10: improve raid10 discard request")
CC: Xiao Ni <xni(a)redhat.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
head: 5b2374a6c221f28c74913d208bb5376a7ee3bf70
commit: 8f694215ae4c7abf1e6c985803a1aad0db748d07 [15/16] md/raid10: improve raid10 discard
request
raid10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1760,7 +1760,7 @@ static bool raid10_handle_discard(struct
raid_end_bio_io(r10_bio);
}
- return 0;
+ return false;
out:
allow_barrier(conf);
return -EAGAIN;
3:48 p.m.
New subject: [PATCH] md/raid10: fix boolreturn.cocci warnings
On 09/22/2020 08:30 AM, kernel test robot wrote:
From: kernel test robot <lkp(a)intel.com>
drivers/md/raid10.c:1763:8-9: WARNING: return of 0/1 in function
'raid10_handle_discard' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 8f694215ae4c ("md/raid10: improve raid10 discard request")
CC: Xiao Ni <xni(a)redhat.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
head: 5b2374a6c221f28c74913d208bb5376a7ee3bf70
commit: 8f694215ae4c7abf1e6c985803a1aad0db748d07 [15/16] md/raid10: improve raid10
discard request
raid10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1760,7 +1760,7 @@ static bool raid10_handle_discard(struct
raid_end_bio_io(r10_bio);
}
- return 0;
+ return false;
Thanks for the patch. But it's not good to return false when
raid10_handle_discard handles discard bio
successfully. I'll send one patch to fix this problem.
Regards
Xiao
728
days inactive
728
days old
2 comments
2 participants
participants (2)
-
kernel test robot -
Xiao Ni