[net:master 21/30] net/netfilter/xt_socket.c:224:3: error: implicit declaration of function 'nf_defrag_ipv6_disable'
8:54 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head: 85d24ad38bc4658ce9a16b85b9c8dc0577d66c71
commit: 75063c9294fb239bbe64eb72141b6871fe526d29 [21/30] netfilter: xt_socket: fix a typo
in socket_mt_destroy()
config: hexagon-randconfig-r045-20220211
(https://download.01.org/0day-ci/archive/20220212/202202120509.FMR7TEL1-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
f6685f774697c85d6a352dcea013f46a99f9fe31)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=...
git remote add net https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
git fetch --no-tags net master
git checkout 75063c9294fb239bbe64eb72141b6871fe526d29
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=hexagon SHELL=/bin/bash net/netfilter/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> net/netfilter/xt_socket.c:224:3: error: implicit declaration of
function 'nf_defrag_ipv6_disable' [-Werror,-Wimplicit-function-declaration]
nf_defrag_ipv6_disable(par->net);
^
net/netfilter/xt_socket.c:224:3: note: did you mean 'nf_defrag_ipv4_disable'?
include/net/netfilter/ipv4/nf_defrag_ipv4.h:7:6: note: 'nf_defrag_ipv4_disable'
declared here
void nf_defrag_ipv4_disable(struct net *net);
^
1 error generated.
vim +/nf_defrag_ipv6_disable +224 net/netfilter/xt_socket.c
218
219 static void socket_mt_destroy(const struct xt_mtdtor_param *par)
220 {
221 if (par->family == NFPROTO_IPV4)
222 nf_defrag_ipv4_disable(par->net);
223 else if (par->family == NFPROTO_IPV6)
224 nf_defrag_ipv6_disable(par->net);
225 }
226
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1:43 p.m.
On Fri, Feb 11, 2022 at 1:55 PM kernel test robot <lkp(a)intel.com> wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head: 85d24ad38bc4658ce9a16b85b9c8dc0577d66c71
commit: 75063c9294fb239bbe64eb72141b6871fe526d29 [21/30] netfilter: xt_socket: fix a typo
in socket_mt_destroy()
config: hexagon-randconfig-r045-20220211
(https://download.01.org/0day-ci/archive/20220212/202202120509.FMR7TEL1-lk...)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
f6685f774697c85d6a352dcea013f46a99f9fe31)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=...
git remote add net https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
git fetch --no-tags net master
git checkout 75063c9294fb239bbe64eb72141b6871fe526d29
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=hexagon SHELL=/bin/bash net/netfilter/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> net/netfilter/xt_socket.c:224:3: error: implicit declaration of function
'nf_defrag_ipv6_disable' [-Werror,-Wimplicit-function-declaration]
nf_defrag_ipv6_disable(par->net);
^
net/netfilter/xt_socket.c:224:3: note: did you mean 'nf_defrag_ipv4_disable'?
include/net/netfilter/ipv4/nf_defrag_ipv4.h:7:6: note:
'nf_defrag_ipv4_disable' declared here
void nf_defrag_ipv4_disable(struct net *net);
^
1 error generated.
I guess something like this is needed ?
diff --git a/net/netfilter/xt_socket.c b/net/netfilter/xt_socket.c
index 662e5eb1cc39e544191b3aab388c3762674d9251..7013f55f05d1ebca3b13d29934d8f6abc1ef36f0
100644
--- a/net/netfilter/xt_socket.c
+++ b/net/netfilter/xt_socket.c
@@ -220,8 +220,10 @@ static void socket_mt_destroy(const struct
xt_mtdtor_param *par)
{
if (par->family == NFPROTO_IPV4)
nf_defrag_ipv4_disable(par->net);
+#if IS_ENABLED(CONFIG_IP6_NF_IPTABLES)
else if (par->family == NFPROTO_IPV6)
nf_defrag_ipv6_disable(par->net);
+#endif
}
static struct xt_match socket_mt_reg[] __read_mostly = {
5:55 a.m.
On Sat, 12 Feb 2022 at 08:14, Eric Dumazet <edumazet(a)google.com> wrote:
On Fri, Feb 11, 2022 at 1:55 PM kernel test robot <lkp(a)intel.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
> head: 85d24ad38bc4658ce9a16b85b9c8dc0577d66c71
> commit: 75063c9294fb239bbe64eb72141b6871fe526d29 [21/30] netfilter: xt_socket: fix a
typo in socket_mt_destroy()
> config: hexagon-randconfig-r045-20220211
(https://download.01.org/0day-ci/archive/20220212/202202120509.FMR7TEL1-lk...)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
f6685f774697c85d6a352dcea013f46a99f9fe31)
> reproduce (this is a W=1 build):
> wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
> chmod +x ~/bin/make.cross
> #
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=...
> git remote add net
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
> git fetch --no-tags net master
> git checkout 75063c9294fb239bbe64eb72141b6871fe526d29
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=hexagon SHELL=/bin/bash net/netfilter/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp(a)intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> net/netfilter/xt_socket.c:224:3: error: implicit declaration of function
'nf_defrag_ipv6_disable' [-Werror,-Wimplicit-function-declaration]
> nf_defrag_ipv6_disable(par->net);
> ^
> net/netfilter/xt_socket.c:224:3: note: did you mean
'nf_defrag_ipv4_disable'?
> include/net/netfilter/ipv4/nf_defrag_ipv4.h:7:6: note:
'nf_defrag_ipv4_disable' declared here
> void nf_defrag_ipv4_disable(struct net *net);
> ^
> 1 error generated.
>
I guess something like this is needed ?
The reported build error was fixed by this patch.
diff --git a/net/netfilter/xt_socket.c b/net/netfilter/xt_socket.c
index 662e5eb1cc39e544191b3aab388c3762674d9251..7013f55f05d1ebca3b13d29934d8f6abc1ef36f0
100644
--- a/net/netfilter/xt_socket.c
+++ b/net/netfilter/xt_socket.c
@@ -220,8 +220,10 @@ static void socket_mt_destroy(const struct
xt_mtdtor_param *par)
{
if (par->family == NFPROTO_IPV4)
nf_defrag_ipv4_disable(par->net);
+#if IS_ENABLED(CONFIG_IP6_NF_IPTABLES)
else if (par->family == NFPROTO_IPV6)
nf_defrag_ipv6_disable(par->net);
+#endif
}
static struct xt_match socket_mt_reg[] __read_mostly = {
Tested-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
--
Linaro LKFT
https://lkft.linaro.org
218
days inactive
221
days old
2 comments
3 participants
participants (3)
-
Eric Dumazet -
kernel test robot -
Naresh Kamboju