tree: https://github.com/morimoto/linux 2022-01-26-v1 head: 05a038a4ac9687be3887060557d4ea520651f286 commit: 05a038a4ac9687be3887060557d4ea520651f286 [15/15] hog config: i386-randconfig-a015-20220124 (https://download.01.org/0day-ci/archive/20220126/202201261942.tXX7V2X8-lk...) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 2a1b7aa016c0f4b5598806205bdfbab1ea2d92c4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/morimoto/linux/commit/05a038a4ac9687be3887060557d4ea52... git remote add morimoto https://github.com/morimoto/linux git fetch --no-tags morimoto 2022-01-26-v1 git checkout 05a038a4ac9687be3887060557d4ea520651f286 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/codecs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): mode = AK4613_INTERFACE_MODE(priv); ^ if (!ak4613_dai_fmt_matching(iface, fmt, width)) ~~~~~~~~~~~~~~~~~~~~~~~ ^ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ sound/soc/codecs/ak4613.c:519:13: note: 'ak4613_dai_fmt_matching' declared here static bool ak4613_dai_fmt_matching(const struct ak4613_interface *iface, ^ if (!ak4613_dai_fmt_matching(iface, fmt, width)) ~~~~~~~~~~~~~~~~~~~~~~~ ^ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:61: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ sound/soc/codecs/ak4613.c:519:13: note: 'ak4613_dai_fmt_matching' declared here static bool ak4613_dai_fmt_matching(const struct ak4613_interface *iface, ^ if (!ak4613_dai_fmt_matching(iface, fmt, width)) ~~~~~~~~~~~~~~~~~~~~~~~ ^ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value' (cond) ? \ ^~~~ sound/soc/codecs/ak4613.c:519:13: note: 'ak4613_dai_fmt_matching' declared here static bool ak4613_dai_fmt_matching(const struct ak4613_interface *iface, ^ 4 errors generated. vim +/AK4613_INTERFACE_MODE +429 sound/soc/codecs/ak4613.c 335 336 static int ak4613_hw_constraints(struct snd_soc_component *component, 337 struct snd_pcm_substream *substream) 338 { 339 struct ak4613_priv *priv = snd_soc_component_get_drvdata(component); 340 struct snd_pcm_runtime *runtime = substream->runtime; 341 static const unsigned int ak4613_rates[] = { 342 32000, 343 44100, 344 48000, 345 64000, 346 88200, 347 96000, 348 176400, 349 192000, 350 }; 351 #define AK4613_CHANNEL_2 0 352 #define AK4613_CHANNEL_4 1 353 #define AK4613_CHANNEL_8 2 354 #define AK4613_CHANNEL_12 3 355 #define AK4613_CHANNEL_NONE -1 356 static const unsigned int ak4613_channels[] = { 357 [AK4613_CHANNEL_2] = 2, 358 [AK4613_CHANNEL_4] = 4, 359 [AK4613_CHANNEL_8] = 8, 360 [AK4613_CHANNEL_12] = 12, 361 }; 362 #define MODE_MAX 4 363 #define SDT_MAX 4 364 #define MASK_LIST(mode, c, p1, p2, p3) \ 365 [AK4613_CONFIG_MODE_##mode] = { \ 366 AK4613_CHANNEL_##c, \ 367 AK4613_CHANNEL_##p1, \ 368 AK4613_CHANNEL_##p2, \ 369 AK4613_CHANNEL_##p3} 370 static const int mask_shift_list[MODE_MAX][SDT_MAX] = { 371 /* 372 * mask shift for 373 * [0] : capture 374 * [1] : playback SDTIx1 375 * [2] : playback SDTIx2 376 * [3] : playback SDTIx3 377 */ 378 MASK_LIST(STEREO, 2, 2, NONE, NONE), 379 MASK_LIST(TDM512, 4, 12, NONE, NONE), 380 MASK_LIST(TDM256, 4, 8, 12, NONE), 381 MASK_LIST(TDM128, 4, 4, 8, 12), 382 }; 383 struct snd_pcm_hw_constraint_list *constraint; 384 unsigned int mask; 385 unsigned int mode; 386 unsigned int fs; 387 int is_play = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; 388 int i, shift, sdti_num; 389 390 constraint = &priv->constraint_rates; 391 constraint->list = ak4613_rates; 392 constraint->mask = 0; 393 constraint->count = 0; 394 395 /* 396 * Slave Mode 397 * Normal: [32kHz, 48kHz] : 256fs,384fs or 512fs 398 * Double: [64kHz, 96kHz] : 256fs 399 * Quad : [128kHz,192kHz]: 128fs 400 * 401 * Master mode 402 * Normal: [32kHz, 48kHz] : 256fs or 512fs 403 * Double: [64kHz, 96kHz] : 256fs 404 * Quad : [128kHz,192kHz]: 128fs 405 */ 406 for (i = 0; i < ARRAY_SIZE(ak4613_rates); i++) { 407 /* minimum fs on each range */ 408 fs = (ak4613_rates[i] <= 96000) ? 256 : 128; 409 410 if (priv->sysclk >= ak4613_rates[i] * fs) 411 constraint->count = i + 1; 412 } 413 414 snd_pcm_hw_constraint_list(runtime, 0, 415 SNDRV_PCM_HW_PARAM_RATE, constraint); 416 417 /* default : STEREO */ 418 mode = AK4613_CONFIG_MODE_STEREO; 419 mask = 0; 420 sdti_num = AK4613_CONFIG_SDTI_get(priv); 421 422 /* update if board supports TDM mode */ 423 if (AK4613_CONFIG_GET(priv, MODE) != AK4613_CONFIG_MODE_STEREO) { 424 if (priv->cnt) { 425 /* 426 * If it was already working, 427 * the constraint is same as working setting. 428 */ 430 } else { 431 /* 432 * It is not yet working, 433 * the constraint is based on board configs. 434 */ 435 mode = AK4613_CONFIG_GET(priv, MODE); 436 mask = (1 << AK4613_CHANNEL_2); /* STEREO is default */ 437 } 438 } 439 440 if (mode >= MODE_MAX || 441 sdti_num >= SDT_MAX) 442 return -EINVAL; 443 444 shift = mask_shift_list[mode][is_play * sdti_num]; 445 if (shift < 0) /* in case of AK4613_CHANNEL_NONE */ 446 return -EINVAL; 447 448 mask |= 1 << shift; 449 printk("----mask %x\n", mask); 450 constraint = &priv->constraint_channels; 451 constraint->list = ak4613_channels; 452 constraint->mask = mask; 453 constraint->count = sizeof(ak4613_channels); 454 snd_pcm_hw_constraint_list(runtime, 0, 455 SNDRV_PCM_HW_PARAM_CHANNELS, constraint); 456 457 return 0; 458 } 459 460 static int ak4613_dai_startup(struct snd_pcm_substream *substream, 461 struct snd_soc_dai *dai) 462 { 463 struct snd_soc_component *component = dai->component; 464 struct ak4613_priv *priv = snd_soc_component_get_drvdata(component); 465 int ret = 0; 466 467 mutex_lock(&priv->lock); 468 ret = ak4613_hw_constraints(component, substream); 469 if (ret == 0) 470 priv->cnt++; 471 mutex_unlock(&priv->lock); 472 473 return ret; 474 } 475 476 static int ak4613_dai_set_sysclk(struct snd_soc_dai *codec_dai, 477 int clk_id, unsigned int freq, int dir) 478 { 479 struct snd_soc_component *component = codec_dai->component; 480 struct ak4613_priv *priv = snd_soc_component_get_drvdata(component); 481 482 priv->sysclk = freq; 483 484 return 0; 485 } 486 487 static int ak4613_dai_set_fmt(struct snd_soc_dai *dai, unsigned int format) 488 { 489 struct snd_soc_component *component = dai->component; 490 struct ak4613_priv *priv = snd_soc_component_get_drvdata(component); 491 unsigned int fmt; 492 493 fmt = format & SND_SOC_DAIFMT_FORMAT_MASK; 494 switch (fmt) { 495 case SND_SOC_DAIFMT_LEFT_J: 496 case SND_SOC_DAIFMT_I2S: 497 priv->fmt = fmt; 498 break; 499 default: 500 return -EINVAL; 501 } 502 503 fmt = format & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK; 504 switch (fmt) { 505 case SND_SOC_DAIFMT_CBC_CFC: 506 break; 507 default: 508 /* 509 * SUPPORTME 510 * 511 * "clock provider" is not yet supperted 512 */ 513 return -EINVAL; 514 } 515 516 return 0; 517 } 518 519 static bool ak4613_dai_fmt_matching(const struct ak4613_interface *iface, 520 unsigned int fmt, unsigned int width, unsigned int channel) 521 { 522 if ((iface->fmt == fmt) && 523 (iface->width == width)) 524 return true; 525 526 return false; 527 } 528 529 static int ak4613_dai_hw_params(struct snd_pcm_substream *substream, 530 struct snd_pcm_hw_params *params, 531 struct snd_soc_dai *dai) 532 { 533 struct snd_soc_component *component = dai->component; 534 struct ak4613_priv *priv = snd_soc_component_get_drvdata(component); 535 struct device *dev = component->dev; 536 unsigned int width = params_width(params); 537 unsigned int channel = params_channels(params); 538 unsigned int fmt = priv->fmt; 539 unsigned int rate; 540 int i, ret; 541 u8 ctrl2; 542 543 rate = params_rate(params); 544 switch (rate) { 545 case 32000: 546 case 44100: 547 case 48000: 548 ctrl2 = DFS_NORMAL_SPEED; 549 break; 550 case 64000: 551 case 88200: 552 case 96000: 553 ctrl2 = DFS_DOUBLE_SPEED; 554 break; 555 case 176400: 556 case 192000: 557 ctrl2 = DFS_QUAD_SPEED; 558 break; 559 default: 560 return -EINVAL; 561 } 562 priv->rate = rate; 563 564 /* 565 * FIXME 566 * 567 * It doesn't have all TDM suppert 568 */ 569 ret = -EINVAL; 570 571 mutex_lock(&priv->lock); 572 if (priv->cnt > 1) { 573 ret = 0; 574 } else { 575 const struct ak4613_interface *iface; 576 577 for (i = ARRAY_SIZE(ak4613_iface) - 1; i >= 0; i--) { 578 iface = ak4613_iface + i; 580 continue; 581 priv->ctrl1 = (iface->dif << 3); 582 ret = 0; 583 break; 584 } 585 } 586 mutex_unlock(&priv->lock); 587 588 if (ret < 0) 589 goto hw_params_end; 590 591 snd_soc_component_update_bits(component, CTRL1, FMT_MASK, priv->ctrl1); 592 snd_soc_component_update_bits(component, CTRL2, DFS_MASK, ctrl2); 593 594 snd_soc_component_update_bits(component, ICTRL, ICTRL_MASK, priv->ic); 595 snd_soc_component_update_bits(component, OCTRL, OCTRL_MASK, priv->oc); 596 597 hw_params_end: 598 if (ret < 0) 599 dev_warn(dev, "unsupported data width/format combination\n"); 600 601 return ret; 602 } 603 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org