[dhowells-fs:fscache-iter-2 42/68] fs/fscache/cookie.c:34:14: sparse: sparse: symbol 'fscache_lru_cookie_timeout' was not declared. Should it be static?
6:31 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
fscache-iter-2
head: d45090b191774b11ecfe2421f5619827aa08ad00
commit: 4bd5274decc61468104b84b1c1bc72817700e63b [42/68] cachefiles: Automatically close a
file that's not in use after a while
config: i386-randconfig-s002-20210713 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/com...
git remote add dhowells-fs
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs fscache-iter-2
git checkout 4bd5274decc61468104b84b1c1bc72817700e63b
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash fs/fscache/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> fs/fscache/cookie.c:34:14: sparse: sparse: symbol
'fscache_lru_cookie_timeout' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
6:32 p.m.
New subject: [RFC PATCH dhowells-fs] cachefiles: fscache_lru_cookie_timeout can be static
fs/fscache/cookie.c:34:14: warning: symbol 'fscache_lru_cookie_timeout' was not
declared. Should it be static?
Fixes: 4bd5274decc6 ("cachefiles: Automatically close a file that's not in use
after a while")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
cookie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c
index c6c3ce8be80d7..618b040e156b2 100644
--- a/fs/fscache/cookie.c
+++ b/fs/fscache/cookie.c
@@ -31,7 +31,7 @@ static DEFINE_SPINLOCK(fscache_cookie_lru_lock);
static DEFINE_TIMER(fscache_cookie_lru_timer, fscache_cookie_lru_timed_out);
static DECLARE_WORK(fscache_cookie_lru_work, fscache_cookie_lru_worker);
static const char fscache_cookie_stages[FSCACHE_COOKIE_STAGE__NR] =
"-LCAIFMWRD";
-unsigned int fscache_lru_cookie_timeout = 10 * HZ;
+static unsigned int fscache_lru_cookie_timeout = 10 * HZ;
void fscache_print_cookie(struct fscache_cookie *cookie, char prefix)
{
434
days inactive
434
days old
1 comments
1 participants
participants (1)
-
kernel test robot