[tip:perf/core 12/17] arch/arm64/kvm/arm.c:499:15: warning: no previous prototype for function 'kvm_arch_vcpu_get_ip'
11:26 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
head: a9f4a6e92b3b319296fb078da2615f618f6cd80c
commit: e1bfc24577cc65c95dc519d7621a9c985b97e567 [12/17] KVM: Move x86's perf guest
info callbacks to generic KVM
config: arm64-buildonly-randconfig-r004-20211122 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
c133fb321f7ca6083ce15b6aa5bf89de6600e649)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
#
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=e1...
git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
git fetch --no-tags tip perf/core
git checkout e1bfc24577cc65c95dc519d7621a9c985b97e567
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> arch/arm64/kvm/arm.c:499:15: warning: no previous prototype for
function 'kvm_arch_vcpu_get_ip' [-Wmissing-prototypes]
unsigned long
kvm_arch_vcpu_get_ip(struct kvm_vcpu *vcpu)
^
arch/arm64/kvm/arm.c:499:1: note: declare 'static' if the function is not
intended to be used outside of this translation unit
unsigned long kvm_arch_vcpu_get_ip(struct kvm_vcpu *vcpu)
^
static
1 warning generated.
vim +/kvm_arch_vcpu_get_ip +499 arch/arm64/kvm/arm.c
498
499 unsigned long kvm_arch_vcpu_get_ip(struct kvm_vcpu *vcpu)
500 {
501 return *vcpu_pc(vcpu);
502 }
503
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
6:42 a.m.
+Peter, Marc
On Mon, Nov 22, 2021, kernel test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
perf/core
head: a9f4a6e92b3b319296fb078da2615f618f6cd80c
commit: e1bfc24577cc65c95dc519d7621a9c985b97e567 [12/17] KVM: Move x86's perf guest
info callbacks to generic KVM
All warnings (new ones prefixed by >>):
>> arch/arm64/kvm/arm.c:499:15: warning: no previous prototype for function
'kvm_arch_vcpu_get_ip' [-Wmissing-prototypes]
unsigned long kvm_arch_vcpu_get_ip(struct kvm_vcpu *vcpu)
^
arch/arm64/kvm/arm.c:499:1: note: declare 'static' if the function is not
intended to be used outside of this translation unit
unsigned long kvm_arch_vcpu_get_ip(struct kvm_vcpu *vcpu)
^
static
1 warning generated.
Argh, the declaration is behind CONFIG_GUEST_PERF_EVENTS=y so that architectures
that don't support GUEST_PERF_EVENTS at all didn't need to provide
implementations.
There are a few ways to solve this, none of which I particularly love. I think my
first choice would be to wrap arm's implementation with an #ifdef. Stubbing out a
getter like this feels all kinds of wrong, and moving the declaration outside of
CONFIG_GUEST_PERF_EVENTS=y will set someone up to try and use the helper when it's
not available.
---
arch/arm64/kvm/arm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 8129ee1ed3a4..e3b46951a92d 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -496,10 +496,12 @@ bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu)
return vcpu_mode_priv(vcpu);
}
+#ifdef CONFIG_GUEST_PERF_EVENTS
unsigned long kvm_arch_vcpu_get_ip(struct kvm_vcpu *vcpu)
{
return *vcpu_pc(vcpu);
}
+#endif
/* Just ensure a guest exit from a particular CPU */
static void exit_vm_noop(void *info)
--
302
days inactive
302
days old
1 comments
2 participants
participants (2)
-
kernel test robot -
Sean Christopherson