3:15 a.m.
The function prototype for ima_add_kexec_buffer() is present
in 'linux/ima.h'. But this header file is not included in
ima_kexec.c where the function is implemented. This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:
security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
Include the header file 'linux/ima.h' in ima_kexec.c to fix
the compiler warning.
Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com>
---
security/integrity/ima/ima_kexec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
index 667887665823..f799cc278a9a 100644
--- a/security/integrity/ima/ima_kexec.c
+++ b/security/integrity/ima/ima_kexec.c
@@ -11,6 +11,7 @@
#include <linux/vmalloc.h>
#include <linux/kexec.h>
#include <linux/of.h>
+#include <linux/ima.h>
#include "ima.h"
#ifdef CONFIG_IMA_KEXEC
--
2.25.1
3:15 a.m.
New subject: [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update'
The function prototype for ima_post_key_create_or_update() is present
in 'linux/ima.h'. But this header file is not included in
ima_asymmetric_keys.c where the function is implemented. This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:
security/integrity/ima/ima_asymmetric_keys.c:29:6: warning: no previous
prototype for 'ima_post_key_create_or_update' [-Wmissing-prototypes]
Include the header file 'linux/ima.h' in ima_asymmetric_keys.c to
fix the compiler warning.
Fixes: 88e70da170e8 (IMA: Define an IMA hook to measure keys)
Cc: stable(a)vger.kernel.org
Signed-off-by: Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com>
---
security/integrity/ima/ima_asymmetric_keys.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/ima/ima_asymmetric_keys.c
b/security/integrity/ima/ima_asymmetric_keys.c
index 1fb0b0e09559..c985418698a4 100644
--- a/security/integrity/ima/ima_asymmetric_keys.c
+++ b/security/integrity/ima/ima_asymmetric_keys.c
@@ -11,6 +11,7 @@
#include <keys/asymmetric-type.h>
#include <linux/user_namespace.h>
+#include <linux/ima.h>
#include "ima.h"
/**
--
2.25.1
3:36 a.m.
New subject: [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update'
On Thu, Jun 10, 2021 at 12:16 PM Lakshmi Ramasubramanian
<nramas(a)linux.microsoft.com> wrote:
The function prototype for ima_post_key_create_or_update() is present
in 'linux/ima.h'. But this header file is not included in
ima_asymmetric_keys.c where the function is implemented. This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:
security/integrity/ima/ima_asymmetric_keys.c:29:6: warning: no previous
prototype for 'ima_post_key_create_or_update' [-Wmissing-prototypes]
Include the header file 'linux/ima.h' in ima_asymmetric_keys.c to
fix the compiler warning.
Fixes: 88e70da170e8 (IMA: Define an IMA hook to measure keys)
Cc: stable(a)vger.kernel.org
Signed-off-by: Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com>
---
security/integrity/ima/ima_asymmetric_keys.c | 1 +
1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh(a)kernel.org>
11:24 a.m.
New subject: [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update'
Hi Lakshmi,
On Thu, 2021-06-10 at 10:15 -0700, Lakshmi Ramasubramanian wrote:
The function prototype for ima_post_key_create_or_update() is
present
in 'linux/ima.h'. But this header file is not included in
ima_asymmetric_keys.c where the function is implemented. This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:
security/integrity/ima/ima_asymmetric_keys.c:29:6: warning: no previous
prototype for 'ima_post_key_create_or_update' [-Wmissing-prototypes]
Include the header file 'linux/ima.h' in ima_asymmetric_keys.c to
fix the compiler warning.
Fixes: 88e70da170e8 (IMA: Define an IMA hook to measure keys)
Cc: stable(a)vger.kernel.org
Signed-off-by: Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com>
Roberto posted an equivalent patch "[PATCH 4/5] ima: Include header
defining ima_post_key_create_or_update()" earlier this week.
Compiler warnings don't meet the requirements for stable -
Documentation/process/stable-kernel-rules.rst.
thanks,
Mimi
3:34 a.m.
On Thu, Jun 10, 2021 at 12:16 PM Lakshmi Ramasubramanian
<nramas(a)linux.microsoft.com> wrote:
The function prototype for ima_add_kexec_buffer() is present
in 'linux/ima.h'. But this header file is not included in
ima_kexec.c where the function is implemented. This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:
security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
Include the header file 'linux/ima.h' in ima_kexec.c to fix
the compiler warning.
Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com>
---
security/integrity/ima/ima_kexec.c | 1 +
1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh(a)kernel.org>
1:41 a.m.
On Thu, 2021-06-10 at 10:15 -0700, Lakshmi Ramasubramanian wrote:
The function prototype for ima_add_kexec_buffer() is present
in 'linux/ima.h'. But this header file is not included in
ima_kexec.c where the function is implemented. This results
in the following compiler warning when "-Wmissing-prototypes" flag
is turned on:
security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
Include the header file 'linux/ima.h' in ima_kexec.c to fix
the compiler warning.
Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Lakshmi Ramasubramanian <nramas(a)linux.microsoft.com>
Thanks!
Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-
integrity.git next-integrity-testing and next-integrity branches.
Mimi
466
days inactive
467
days old
5 comments
3 participants
participants (3)
-
Lakshmi Ramasubramanian -
Mimi Zohar -
Rob Herring