[linux-review:UPDATE-20200417-054402/Sahitya-Tummala/f2fs-prevent-meta-updates-while-checkpoint-is-in-progress/20200327-044221 1/1] fs/f2fs/gc.c:1444:7: error: implicit declaration of function 'fatal_signal_pending'; did you mean 'local_softirq_pending'?
5:32 p.m.
tree:
https://github.com/0day-ci/linux/commits/UPDATE-20200417-054402/Sahitya-T...
head: 6f5d43888de06d19b134a1470fb0174889b8059c
commit: 6f5d43888de06d19b134a1470fb0174889b8059c [1/1] f2fs: prevent meta updates while
checkpoint is in progress
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
git checkout 6f5d43888de06d19b134a1470fb0174889b8059c
# save the attached .config to linux build tree
make ARCH=x86_64
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/f2fs/gc.c: In function 'free_segment_range':
> fs/f2fs/gc.c:1444:7: error: implicit declaration of function
'fatal_signal_pending'; did you mean 'local_softirq_pending'?
[-Werror=implicit-function-declaration]
if (fatal_signal_pending(current))
^~~~~~~~~~~~~~~~~~~~
local_softirq_pending
cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/6f5d43888de06d19b134a1470fb017488...
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 6f5d43888de06d19b134a1470fb0174889b8059c
vim +1444 fs/f2fs/gc.c
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1401
6f5d43888de06d Jaegeuk Kim 2020-04-16 1402 static int free_segment_range(struct
f2fs_sb_info *sbi,
6f5d43888de06d Jaegeuk Kim 2020-04-16 1403 unsigned int secs, bool gc_only)
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1404 {
6f5d43888de06d Jaegeuk Kim 2020-04-16 1405 unsigned int segno, next_inuse, start, end;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1406 struct cp_control cpc = { CP_RESIZE, 0, 0, 0
};
6f5d43888de06d Jaegeuk Kim 2020-04-16 1407 int gc_mode, gc_type;
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1408 int err = 0;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1409 int type;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1410
6f5d43888de06d Jaegeuk Kim 2020-04-16 1411 /* Force block allocation for GC */
6f5d43888de06d Jaegeuk Kim 2020-04-16 1412 MAIN_SECS(sbi) -= secs;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1413 start = MAIN_SECS(sbi) *
sbi->segs_per_sec;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1414 end = MAIN_SEGS(sbi) - 1;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1415
6f5d43888de06d Jaegeuk Kim 2020-04-16 1416
mutex_lock(&DIRTY_I(sbi)->seglist_lock);
6f5d43888de06d Jaegeuk Kim 2020-04-16 1417 for (gc_mode = 0; gc_mode <
MAX_GC_POLICY; gc_mode++)
6f5d43888de06d Jaegeuk Kim 2020-04-16 1418 if (SIT_I(sbi)->last_victim[gc_mode]
>= start)
6f5d43888de06d Jaegeuk Kim 2020-04-16 1419 SIT_I(sbi)->last_victim[gc_mode] = 0;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1420
6f5d43888de06d Jaegeuk Kim 2020-04-16 1421 for (gc_type = BG_GC; gc_type <= FG_GC;
gc_type++)
6f5d43888de06d Jaegeuk Kim 2020-04-16 1422 if (sbi->next_victim_seg[gc_type] >=
start)
6f5d43888de06d Jaegeuk Kim 2020-04-16 1423 sbi->next_victim_seg[gc_type] =
NULL_SEGNO;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1424
mutex_unlock(&DIRTY_I(sbi)->seglist_lock);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1425
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1426 /* Move out cursegs from the target range
*/
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1427 for (type = CURSEG_HOT_DATA; type <
NR_CURSEG_TYPE; type++)
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1428 allocate_segment_for_resize(sbi, type,
start, end);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1429
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1430 /* do GC to move out valid blocks in the
range */
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1431 for (segno = start; segno <= end; segno
+= sbi->segs_per_sec) {
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1432 struct gc_inode_list gc_list = {
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1433 .ilist = LIST_HEAD_INIT(gc_list.ilist),
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1434 .iroot = RADIX_TREE_INIT(gc_list.iroot,
GFP_NOFS),
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1435 };
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1436
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1437 do_garbage_collect(sbi, segno,
&gc_list, FG_GC);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1438 put_gc_inode(&gc_list);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1439
6f5d43888de06d Jaegeuk Kim 2020-04-16 1440 if (!gc_only &&
get_valid_blocks(sbi, segno, true)) {
6f5d43888de06d Jaegeuk Kim 2020-04-16 1441 err = -EAGAIN;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1442 goto out;
6f5d43888de06d Jaegeuk Kim 2020-04-16 1443 }
6f5d43888de06d Jaegeuk Kim 2020-04-16 @1444 if (fatal_signal_pending(current))
6f5d43888de06d Jaegeuk Kim 2020-04-16 1445 return -ERESTARTSYS;
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1446 }
6f5d43888de06d Jaegeuk Kim 2020-04-16 1447 if (gc_only)
6f5d43888de06d Jaegeuk Kim 2020-04-16 1448 goto out;
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1449
6f5d43888de06d Jaegeuk Kim 2020-04-16 1450 err = f2fs_write_checkpoint(sbi, &cpc);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1451 if (err)
6f5d43888de06d Jaegeuk Kim 2020-04-16 1452 goto out;
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1453
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1454 next_inuse = find_next_inuse(FREE_I(sbi),
end + 1, start);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1455 if (next_inuse <= end) {
dcbb4c10e6d969 Joe Perches 2019-06-18 1456 f2fs_err(sbi, "segno %u should be free
but still inuse!",
dcbb4c10e6d969 Joe Perches 2019-06-18 1457 next_inuse);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1458 f2fs_bug_on(sbi, 1);
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1459 }
6f5d43888de06d Jaegeuk Kim 2020-04-16 1460 out:
6f5d43888de06d Jaegeuk Kim 2020-04-16 1461 MAIN_SECS(sbi) -= secs;
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1462 return err;
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1463 }
04f0b2eaa3b3ee Qiuyang Sun 2019-06-05 1464
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
883
days inactive
883
days old
0 comments
1 participants
participants (1)
-
kbuild test robot