Hi Leonard,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on 3a62c333497b164868fdcd241842a1dd4e331825]
url:
https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initial-supp...
base: 3a62c333497b164868fdcd241842a1dd4e331825
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/ed738605a859a09457d1ab0570d8cf8bc...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20210825-053714
git checkout ed738605a859a09457d1ab0570d8cf8bcfe3f536
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> net/ipv4/tcp_authopt.c:208:30: warning: no previous prototype for
'tcp_authopt_lookup_send' [-Wmissing-prototypes]
208 | struct
tcp_authopt_key_info *tcp_authopt_lookup_send(struct tcp_authopt_info *info,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/rbtree.h:22,
from include/linux/mm_types.h:10,
from include/linux/mmzone.h:21,
from include/linux/gfp.h:6,
from include/linux/mm.h:10,
from include/linux/bvec.h:14,
from include/linux/skbuff.h:17,
from include/linux/tcp.h:17,
from include/net/tcp.h:20,
from net/ipv4/tcp_authopt.c:4:
net/ipv4/tcp_authopt.c: In function 'tcp_authopt_clone_keys':
net/ipv4/tcp_authopt.c:468:87: error: 'sk' undeclared (first use in this
function); did you mean 's8'?
468 | hlist_for_each_entry_rcu(old_key, &old_info->head, node,
lockdep_sock_is_held(sk)) {
|
^~
include/linux/rcupdate.h:318:22: note: in definition of macro
'RCU_LOCKDEP_WARN'
318 | if ((c) && debug_lockdep_rcu_enabled() &&
!__warned) { \
| ^
include/linux/rculist.h:706:14: note: in expansion of macro '__list_check_rcu'
706 | for (__list_check_rcu(dummy, ## cond, 0), \
| ^~~~~~~~~~~~~~~~
net/ipv4/tcp_authopt.c:468:9: note: in expansion of macro
'hlist_for_each_entry_rcu'
468 | hlist_for_each_entry_rcu(old_key, &old_info->head, node,
lockdep_sock_is_held(sk)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
net/ipv4/tcp_authopt.c:468:87: note: each undeclared identifier is reported only once
for each function it appears in
468 | hlist_for_each_entry_rcu(old_key, &old_info->head, node,
lockdep_sock_is_held(sk)) {
|
^~
include/linux/rcupdate.h:318:22: note: in definition of macro
'RCU_LOCKDEP_WARN'
318 | if ((c) && debug_lockdep_rcu_enabled() &&
!__warned) { \
| ^
include/linux/rculist.h:706:14: note: in expansion of macro '__list_check_rcu'
706 | for (__list_check_rcu(dummy, ## cond, 0), \
| ^~~~~~~~~~~~~~~~
net/ipv4/tcp_authopt.c:468:9: note: in expansion of macro
'hlist_for_each_entry_rcu'
468 | hlist_for_each_entry_rcu(old_key, &old_info->head, node,
lockdep_sock_is_held(sk)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~
net/ipv4/tcp_authopt.c: In function 'tcp_authopt_shash_traffic_key':
net/ipv4/tcp_authopt.c:542:42: warning: variable 'daddr' set but not used
[-Wunused-but-set-variable]
542 | struct in6_addr *daddr;
| ^~~~~
net/ipv4/tcp_authopt.c:541:42: warning: variable 'saddr' set but not used
[-Wunused-but-set-variable]
541 | struct in6_addr *saddr;
| ^~~~~
net/ipv4/tcp_authopt.c: At top level:
net/ipv4/tcp_authopt.c:940:5: warning: no previous prototype for
'__tcp_authopt_calc_mac' [-Wmissing-prototypes]
940 | int __tcp_authopt_calc_mac(struct sock *sk,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/tcp_authopt_lookup_send +208 net/ipv4/tcp_authopt.c
207
208 struct tcp_authopt_key_info *tcp_authopt_lookup_send(struct
tcp_authopt_info *info,
209 const struct sock *addr_sk,
210 int send_id)
211 {
212 struct tcp_authopt_key_info *result = NULL;
213 struct tcp_authopt_key_info *key;
214
215 hlist_for_each_entry_rcu(key, &info->head, node, 0) {
216 if (send_id >= 0 && key->send_id != send_id)
217 continue;
218 if (key->flags & TCP_AUTHOPT_KEY_ADDR_BIND) {
219 if (addr_sk->sk_family == AF_INET) {
220 struct sockaddr_in *key_addr = (struct sockaddr_in *)&key->addr;
221 const struct in_addr *daddr =
222 (const struct in_addr *)&addr_sk->sk_daddr;
223
224 if (WARN_ON(key_addr->sin_family != AF_INET))
225 continue;
226 if (memcmp(daddr, &key_addr->sin_addr, sizeof(*daddr)))
227 continue;
228 }
229 if (addr_sk->sk_family == AF_INET6) {
230 struct sockaddr_in6 *key_addr = (struct sockaddr_in6 *)&key->addr;
231 const struct in6_addr *daddr = &addr_sk->sk_v6_daddr;
232
233 if (WARN_ON(key_addr->sin6_family != AF_INET6))
234 continue;
235 if (memcmp(daddr, &key_addr->sin6_addr, sizeof(*daddr)))
236 continue;
237 }
238 }
239 if (result && net_ratelimit())
240 pr_warn("ambiguous tcp authentication keys configured for send\n");
241 result = key;
242 }
243
244 return result;
245 }
246
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org