tree:
https://github.com/cminyard/linux-ipmi ipmi-wdt-rework
head: e25cca1514b717a229931e182000c21bb5a74db3
commit: 8fbe2d52d47664f9391872afdea91875734d49fc [6/14] watchdog: Add functions to set the
timeout and pretimeout
config: i386-randconfig-r001-20200621 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce (this is a W=1 build):
git checkout 8fbe2d52d47664f9391872afdea91875734d49fc
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/hwmon/fschmd.c:697:12: error: conflicting types for
'watchdog_set_timeout'
static int watchdog_set_timeout(struct
fschmd_data *data, int timeout)
^~~~~~~~~~~~~~~~~~~~
In file included from drivers/hwmon/fschmd.c:34:0:
include/linux/watchdog.h:205:5: note: previous declaration of
'watchdog_set_timeout' was here
int watchdog_set_timeout(struct watchdog_device *wdd, unsigned int timeout);
^~~~~~~~~~~~~~~~~~~~
vim +/watchdog_set_timeout +697 drivers/hwmon/fschmd.c
569ff1022662a8 Hans de Goede 2007-10-11 691
569ff1022662a8 Hans de Goede 2007-10-11 692
569ff1022662a8 Hans de Goede 2007-10-11 693 /*
97950c3d423e47 Hans de Goede 2009-01-07 694 * Watchdog routines
97950c3d423e47 Hans de Goede 2009-01-07 695 */
97950c3d423e47 Hans de Goede 2009-01-07 696
97950c3d423e47 Hans de Goede 2009-01-07 @697 static int watchdog_set_timeout(struct
fschmd_data *data, int timeout)
97950c3d423e47 Hans de Goede 2009-01-07 698 {
97950c3d423e47 Hans de Goede 2009-01-07 699 int ret, resolution;
97950c3d423e47 Hans de Goede 2009-01-07 700 int kind = data->kind + 1; /* 0-x array
index -> 1-x module param */
97950c3d423e47 Hans de Goede 2009-01-07 701
97950c3d423e47 Hans de Goede 2009-01-07 702 /* 2 second or 60 second resolution? */
97950c3d423e47 Hans de Goede 2009-01-07 703 if (timeout <= 510 || kind == fscpos ||
kind == fscscy)
97950c3d423e47 Hans de Goede 2009-01-07 704 resolution = 2;
97950c3d423e47 Hans de Goede 2009-01-07 705 else
97950c3d423e47 Hans de Goede 2009-01-07 706 resolution = 60;
97950c3d423e47 Hans de Goede 2009-01-07 707
97950c3d423e47 Hans de Goede 2009-01-07 708 if (timeout < resolution || timeout >
(resolution * 255))
97950c3d423e47 Hans de Goede 2009-01-07 709 return -EINVAL;
97950c3d423e47 Hans de Goede 2009-01-07 710
97950c3d423e47 Hans de Goede 2009-01-07 711 mutex_lock(&data->watchdog_lock);
97950c3d423e47 Hans de Goede 2009-01-07 712 if (!data->client) {
97950c3d423e47 Hans de Goede 2009-01-07 713 ret = -ENODEV;
97950c3d423e47 Hans de Goede 2009-01-07 714 goto leave;
97950c3d423e47 Hans de Goede 2009-01-07 715 }
97950c3d423e47 Hans de Goede 2009-01-07 716
97950c3d423e47 Hans de Goede 2009-01-07 717 if (resolution == 2)
97950c3d423e47 Hans de Goede 2009-01-07 718 data->watchdog_control &=
~FSCHMD_WDOG_CONTROL_RESOLUTION;
97950c3d423e47 Hans de Goede 2009-01-07 719 else
97950c3d423e47 Hans de Goede 2009-01-07 720 data->watchdog_control |=
FSCHMD_WDOG_CONTROL_RESOLUTION;
97950c3d423e47 Hans de Goede 2009-01-07 721
97950c3d423e47 Hans de Goede 2009-01-07 722 data->watchdog_preset =
DIV_ROUND_UP(timeout, resolution);
97950c3d423e47 Hans de Goede 2009-01-07 723
97950c3d423e47 Hans de Goede 2009-01-07 724 /* Write new timeout value */
c69ab2b78efbe3 Hans de Goede 2009-03-30 725 i2c_smbus_write_byte_data(data->client,
c69ab2b78efbe3 Hans de Goede 2009-03-30 726 FSCHMD_REG_WDOG_PRESET[data->kind],
data->watchdog_preset);
97950c3d423e47 Hans de Goede 2009-01-07 727 /* Write new control register, do not
trigger! */
c69ab2b78efbe3 Hans de Goede 2009-03-30 728 i2c_smbus_write_byte_data(data->client,
c69ab2b78efbe3 Hans de Goede 2009-03-30 729 FSCHMD_REG_WDOG_CONTROL[data->kind],
97950c3d423e47 Hans de Goede 2009-01-07 730 data->watchdog_control &
~FSCHMD_WDOG_CONTROL_TRIGGER);
97950c3d423e47 Hans de Goede 2009-01-07 731
97950c3d423e47 Hans de Goede 2009-01-07 732 ret = data->watchdog_preset *
resolution;
97950c3d423e47 Hans de Goede 2009-01-07 733
97950c3d423e47 Hans de Goede 2009-01-07 734 leave:
97950c3d423e47 Hans de Goede 2009-01-07 735 mutex_unlock(&data->watchdog_lock);
97950c3d423e47 Hans de Goede 2009-01-07 736 return ret;
97950c3d423e47 Hans de Goede 2009-01-07 737 }
97950c3d423e47 Hans de Goede 2009-01-07 738
:::::: The code at line 697 was first introduced by commit
:::::: 97950c3d423e474ef887749b238ee67731b532fe hwmon: (fschmd) Add watchdog support
:::::: TO: Hans de Goede <hdegoede(a)redhat.com>
:::::: CC: Jean Delvare <khali(a)linux-fr.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org