5:35 a.m.
Hi Johan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on usb/usb-testing v5.12-rc8 next-20210421]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Johan-Hovold/serial-extend-compi...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-randconfig-a014-20210421 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
d87b9b81ccb95217181ce75515c6c68bbb408ca4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/c010530fa587261662c6abdb59ade9946...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Johan-Hovold/serial-extend-compile-test-coverage/20210421-234950
git checkout c010530fa587261662c6abdb59ade994645dcfa8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/tty/serial/serial_txx9.c:987:12: warning: no previous
prototype for function 'early_serial_txx9_setup' [-Wmissing-prototypes]
int __init early_serial_txx9_setup(struct uart_port *port)
^
drivers/tty/serial/serial_txx9.c:987:1: note: declare 'static' if the function
is not intended to be used outside of this translation unit
int __init early_serial_txx9_setup(struct uart_port *port)
^
static
1 warning generated.
vim +/early_serial_txx9_setup +987 drivers/tty/serial/serial_txx9.c
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 986
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 @987 int __init
early_serial_txx9_setup(struct uart_port *port)
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 988 {
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 989 if
(port->line >= ARRAY_SIZE(serial_txx9_ports))
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 990 return
-ENODEV;
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 991
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 992
serial_txx9_ports[port->line].port = *port;
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 993
serial_txx9_ports[port->line].port.ops = &serial_txx9_pops;
37a6c7d0096bb5 drivers/serial/serial_txx9.c Atsushi Nemoto 2007-10-16 994
serial_txx9_ports[port->line].port.flags |=
37a6c7d0096bb5 drivers/serial/serial_txx9.c Atsushi Nemoto 2007-10-16 995
UPF_BOOT_AUTOCONF | UPF_FIXED_PORT;
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 996 return 0;
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 997 }
^1da177e4c3f41 drivers/serial/serial_txx9.c Linus Torvalds 2005-04-16 998
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
5:11 p.m.
New subject: [PATCH] serial: extend compile-test coverage
On Thu, Apr 22, 2021 at 3:20 AM kernel test robot <lkp(a)intel.com> wrote:
I love your patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on usb/usb-testing v5.12-rc8 next-20210421]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Johan-Hovold/serial-extend-compi...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-randconfig-a014-20210421 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
d87b9b81ccb95217181ce75515c6c68bbb408ca4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/c010530fa587261662c6abdb59ade9946...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Johan-Hovold/serial-extend-compile-test-coverage/20210421-234950
git checkout c010530fa587261662c6abdb59ade994645dcfa8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/serial_txx9.c:987:12: warning: no previous prototype for
function 'early_serial_txx9_setup' [-Wmissing-prototypes]
int __init early_serial_txx9_setup(struct uart_port *port)
^
drivers/tty/serial/serial_txx9.c:987:1: note: declare 'static' if the function
is not intended to be used outside of this translation unit
int __init early_serial_txx9_setup(struct uart_port *port)
^
static
1 warning generated.
This function is called from arch/mips/txx9/generic/setup.c, and does
have a forward declaration in arch/mips/include/asm/txx9/generic.h.
Unfortunately the latter cannot be included from the driver, unless
the || COMPILE_TEST is dropped again.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like
that.
-- Linus Torvalds
5:37 p.m.
New subject: [PATCH] serial: extend compile-test coverage
On Thu, Apr 22, 2021 at 09:11:50AM +0200, Geert Uytterhoeven wrote:
On Thu, Apr 22, 2021 at 3:20 AM kernel test robot
<lkp(a)intel.com> wrote:
> >> drivers/tty/serial/serial_txx9.c:987:12: warning: no
previous prototype for function 'early_serial_txx9_setup' [-Wmissing-prototypes]
> int __init early_serial_txx9_setup(struct uart_port *port)
> ^
> drivers/tty/serial/serial_txx9.c:987:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
> int __init early_serial_txx9_setup(struct uart_port *port)
> ^
> static
> 1 warning generated.
This function is called from arch/mips/txx9/generic/setup.c, and does
have a forward declaration in arch/mips/include/asm/txx9/generic.h.
Unfortunately the latter cannot be included from the driver, unless
the || COMPILE_TEST is dropped again.
Thanks, Geert. I was just about to send a v2 without the txx9 hunk.
Johan
5:40 p.m.
New subject: [PATCH] serial: extend compile-test coverage
Hi Johan,
On Thu, Apr 22, 2021 at 9:37 AM Johan Hovold <johan(a)kernel.org> wrote:
On Thu, Apr 22, 2021 at 09:11:50AM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 22, 2021 at 3:20 AM kernel test robot <lkp(a)intel.com> wrote:
> > >> drivers/tty/serial/serial_txx9.c:987:12: warning: no previous
prototype for function 'early_serial_txx9_setup' [-Wmissing-prototypes]
> > int __init early_serial_txx9_setup(struct uart_port *port)
> > ^
> > drivers/tty/serial/serial_txx9.c:987:1: note: declare 'static' if
the function is not intended to be used outside of this translation unit
> > int __init early_serial_txx9_setup(struct uart_port *port)
> > ^
> > static
> > 1 warning generated.
>
> This function is called from arch/mips/txx9/generic/setup.c, and does
> have a forward declaration in arch/mips/include/asm/txx9/generic.h.
> Unfortunately the latter cannot be included from the driver, unless
> the || COMPILE_TEST is dropped again.
Thanks, Geert. I was just about to send a v2 without the txx9 hunk.
well, I guess apart from this (W=1!) warning, this driver still
compile-tests fine.
Do we consider hard-to-fix W=1 warnings to be legitimate blockers
for enabling compile-testing?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like
that.
-- Linus Torvalds
5:52 p.m.
New subject: [PATCH] serial: extend compile-test coverage
On Thu, Apr 22, 2021 at 09:40:38AM +0200, Geert Uytterhoeven wrote:
Hi Johan,
On Thu, Apr 22, 2021 at 9:37 AM Johan Hovold <johan(a)kernel.org> wrote:
> On Thu, Apr 22, 2021 at 09:11:50AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Apr 22, 2021 at 3:20 AM kernel test robot <lkp(a)intel.com> wrote:
> > > >> drivers/tty/serial/serial_txx9.c:987:12: warning: no previous
prototype for function 'early_serial_txx9_setup' [-Wmissing-prototypes]
> > > int __init early_serial_txx9_setup(struct uart_port *port)
> > > ^
> > > drivers/tty/serial/serial_txx9.c:987:1: note: declare 'static'
if the function is not intended to be used outside of this translation unit
> > > int __init early_serial_txx9_setup(struct uart_port *port)
> > > ^
> > > static
> > > 1 warning generated.
> >
> > This function is called from arch/mips/txx9/generic/setup.c, and does
> > have a forward declaration in arch/mips/include/asm/txx9/generic.h.
> > Unfortunately the latter cannot be included from the driver, unless
> > the || COMPILE_TEST is dropped again.
>
> Thanks, Geert. I was just about to send a v2 without the txx9 hunk.
well, I guess apart from this (W=1!) warning, this driver still
compile-tests fine.
Do we consider hard-to-fix W=1 warnings to be legitimate blockers
for enabling compile-testing?
Since the build bots have enabled them (and people have turned it into a
crusade to suppress every W=1 warning by any means) I think it's
reasonable to not introduce new ones knowingly.
And I'm not too motivated right now to try to work around this one
myself. The idea here was just to enable COMPILE_TEST for drivers that
did not have any build-time dependencies.
Johan
5:54 p.m.
New subject: [PATCH] serial: extend compile-test coverage
Hi Johan,
On Thu, Apr 22, 2021 at 9:52 AM Johan Hovold <johan(a)kernel.org> wrote:
On Thu, Apr 22, 2021 at 09:40:38AM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 22, 2021 at 9:37 AM Johan Hovold <johan(a)kernel.org> wrote:
> > On Thu, Apr 22, 2021 at 09:11:50AM +0200, Geert Uytterhoeven wrote:
> > > On Thu, Apr 22, 2021 at 3:20 AM kernel test robot <lkp(a)intel.com>
wrote:
> > > > >> drivers/tty/serial/serial_txx9.c:987:12: warning: no
previous prototype for function 'early_serial_txx9_setup' [-Wmissing-prototypes]
> > > > int __init early_serial_txx9_setup(struct uart_port *port)
> > > > ^
> > > > drivers/tty/serial/serial_txx9.c:987:1: note: declare
'static' if the function is not intended to be used outside of this translation
unit
> > > > int __init early_serial_txx9_setup(struct uart_port *port)
> > > > ^
> > > > static
> > > > 1 warning generated.
> > >
> > > This function is called from arch/mips/txx9/generic/setup.c, and does
> > > have a forward declaration in arch/mips/include/asm/txx9/generic.h.
> > > Unfortunately the latter cannot be included from the driver, unless
> > > the || COMPILE_TEST is dropped again.
> >
> > Thanks, Geert. I was just about to send a v2 without the txx9 hunk.
>
> well, I guess apart from this (W=1!) warning, this driver still
> compile-tests fine.
> Do we consider hard-to-fix W=1 warnings to be legitimate blockers
> for enabling compile-testing?
Since the build bots have enabled them (and people have turned it into a
crusade to suppress every W=1 warning by any means) I think it's
reasonable to not introduce new ones knowingly.
And I'm not too motivated right now to try to work around this one
myself. The idea here was just to enable COMPILE_TEST for drivers that
did not have any build-time dependencies.
OK.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like
that.
-- Linus Torvalds
516
days inactive
517
days old
5 comments
3 participants
participants (3)
-
Geert Uytterhoeven -
Johan Hovold -
kernel test robot