On Thu, 31 Dec 2020 07:22:22 +0800, kernel test robot wrote:
> Hi Timon,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on regulator/for-next]
> [also build test ERROR on pinctrl-samsung/for-next krzk/for-next v5.11-rc1
next-20201223]
> [cannot apply to robh/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
>
https://git-scm.com/docs/git-format-patch]
>
> url:
https://github.com/0day-ci/linux/commits/Timon-Baetz/extcon-max8997-Add-C...
> base:
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
for-next
> config: arm-randconfig-r004-20201230 (attached as .config)
> compiler: clang version 12.0.0 (
https://github.com/llvm/llvm-project
3c0d36f977d9e012b245c796ddc8596ac3af659b)
> reproduce (this is a W=1 build):
> wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> #
https://github.com/0day-ci/linux/commit/3a597219bbfc1f9a0b65b9662b7b95bbb...
> git remote add linux-review
https://github.com/0day-ci/linux
> git fetch --no-tags linux-review
Timon-Baetz/extcon-max8997-Add-CHGINS-and-CHGRM-interrupt-handling/20201231-045812
> git checkout 3a597219bbfc1f9a0b65b9662b7b95bbb7cf728f
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp(a)intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration
of function 'devm_extcon_register_notifier_all'
[-Werror,-Wimplicit-function-declaration]
> ret = devm_extcon_register_notifier_all(&pdev->dev,
charger->edev,
> ^
> drivers/power/supply/max8997_charger.c:261:9: note: did you mean
'devm_extcon_register_notifier'?
> include/linux/extcon.h:263:19: note: 'devm_extcon_register_notifier'
declared here
> static inline int devm_extcon_register_notifier(struct device *dev,
> ^
> 1 error generated.
This is failing because CONFIG_EXTCON is not set and *_all() don't have
stub implementations in extcon.h. Should I add a fix for it in this
series?
It is not problem of your patchset, so up to you. After your changes
the driver still can work fine without CONFIG_EXTCON and CONFIG_REGULATOR.
Best regards,
Krzysztof