Hi Maarten,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next tip/perf/core v5.7-rc3 next-20200430]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/perf-core-Only...
base:
git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-debian-10.3 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/cpumask.h:14,
from arch/x86/include/asm/cpumask.h:5,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:22,
from include/linux/mutex.h:19,
from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from drivers/gpu/drm/i915/i915_drv.c:30:
drivers/gpu/drm/i915/i915_vma.h: In function 'i915_vma_pin':
> include/linux/dma-resv.h:80:28: error: implicit declaration of
function 'lockdep_is_held'; did you mean 'lockdep_assert_held'?
[-Werror=implicit-function-declaration]
#define dma_resv_held(obj)
lockdep_is_held(&(obj)->lock.base)
^
include/asm-generic/bug.h:151:27: note: in definition of macro 'WARN_ONCE'
int __ret_warn_once = !!(condition); \
^~~~~~~~~
drivers/gpu/drm/i915/i915_vma.h:245:2: note: in expansion of macro
'WARN_ON_ONCE'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~
drivers/gpu/drm/i915/i915_vma.h:245:28: note: in expansion of macro
'dma_resv_held'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +80 include/linux/dma-resv.h
786d7257e537da0 include/linux/reservation.h Maarten Lankhorst 2013-06-27 79
52791eeec1d9f4a include/linux/dma-resv.h Christian König 2019-08-11 @80 #define
dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
52791eeec1d9f4a include/linux/dma-resv.h Christian König 2019-08-11 81 #define
dma_resv_assert_held(obj) lockdep_assert_held(&(obj)->lock.base)
04a5faa8cbe5a8e include/linux/reservation.h Maarten Lankhorst 2014-07-01 82
:::::: The code at line 80 was first introduced by commit
:::::: 52791eeec1d9f4a7e7fe08aaba0b1553149d93bc dma-buf: rename reservation_object to
dma_resv
:::::: TO: Christian König <christian.koenig(a)amd.com>
:::::: CC: Christian König <christian.koenig(a)amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org