Hi Matti, [FYI, it's a private test report for your RFC patch.] url: https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Extend-regulator... base: a38fd8748464831584a19438cbb3082b5a2dab15 config: x86_64-randconfig-m001-20210309 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; smatch warnings: drivers/regulator/irq_helpers.c:344 regulator_irq_helper() error: potentially dereferencing uninitialized 'h'. vim +/h +344 drivers/regulator/irq_helpers.c e78e28e8268177 Matti Vaittinen 2021-03-10 336 void *regulator_irq_helper(struct device *dev, e78e28e8268177 Matti Vaittinen 2021-03-10 337 const struct regulator_irq_desc *d, int irq, e78e28e8268177 Matti Vaittinen 2021-03-10 338 int irq_flags, int common_errs, int *per_rdev_errs, e78e28e8268177 Matti Vaittinen 2021-03-10 339 struct regulator_dev **rdev, int rdev_amount) e78e28e8268177 Matti Vaittinen 2021-03-10 340 { e78e28e8268177 Matti Vaittinen 2021-03-10 341 struct regulator_irq *h; e78e28e8268177 Matti Vaittinen 2021-03-10 342 int ret; e78e28e8268177 Matti Vaittinen 2021-03-10 343 e78e28e8268177 Matti Vaittinen 2021-03-10 @344 if (!rdev_amount || !d || !d->map_event || !h->desc.name) ^ "h" isn't initialized at this point. e78e28e8268177 Matti Vaittinen 2021-03-10 345 return ERR_PTR(-EINVAL); e78e28e8268177 Matti Vaittinen 2021-03-10 346 e78e28e8268177 Matti Vaittinen 2021-03-10 347 if (irq <= 0) { e78e28e8268177 Matti Vaittinen 2021-03-10 348 dev_err(dev, "No IRQ\n"); e78e28e8268177 Matti Vaittinen 2021-03-10 349 return ERR_PTR(-EINVAL); e78e28e8268177 Matti Vaittinen 2021-03-10 350 } e78e28e8268177 Matti Vaittinen 2021-03-10 351 e78e28e8268177 Matti Vaittinen 2021-03-10 352 h = devm_kzalloc(dev, sizeof(*h), GFP_KERNEL); e78e28e8268177 Matti Vaittinen 2021-03-10 353 if (!h) e78e28e8268177 Matti Vaittinen 2021-03-10 354 return ERR_PTR(-ENOMEM); e78e28e8268177 Matti Vaittinen 2021-03-10 355 e78e28e8268177 Matti Vaittinen 2021-03-10 356 h->irq = irq; e78e28e8268177 Matti Vaittinen 2021-03-10 357 h->desc = *d; e78e28e8268177 Matti Vaittinen 2021-03-10 358 e78e28e8268177 Matti Vaittinen 2021-03-10 359 ret = init_rdev_state(dev, h, rdev, common_errs, per_rdev_errs, e78e28e8268177 Matti Vaittinen 2021-03-10 360 rdev_amount); e78e28e8268177 Matti Vaittinen 2021-03-10 361 if (ret) e78e28e8268177 Matti Vaittinen 2021-03-10 362 return ERR_PTR(ret); e78e28e8268177 Matti Vaittinen 2021-03-10 363 e78e28e8268177 Matti Vaittinen 2021-03-10 364 init_rdev_errors(h); e78e28e8268177 Matti Vaittinen 2021-03-10 365 e78e28e8268177 Matti Vaittinen 2021-03-10 366 if (h->desc.irq_off_ms) e78e28e8268177 Matti Vaittinen 2021-03-10 367 INIT_DELAYED_WORK(&h->isr_work, regulator_notifier_isr_work); e78e28e8268177 Matti Vaittinen 2021-03-10 368 e78e28e8268177 Matti Vaittinen 2021-03-10 369 ret = request_threaded_irq(h->irq, NULL, regulator_notifier_isr, e78e28e8268177 Matti Vaittinen 2021-03-10 370 IRQF_ONESHOT | irq_flags, h->desc.name, h); e78e28e8268177 Matti Vaittinen 2021-03-10 371 if (ret) e78e28e8268177 Matti Vaittinen 2021-03-10 372 return ERR_PTR(ret); e78e28e8268177 Matti Vaittinen 2021-03-10 373 e78e28e8268177 Matti Vaittinen 2021-03-10 374 return h; e78e28e8268177 Matti Vaittinen 2021-03-10 375 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ kbuild mailing list -- kbuild(a)lists.01.org To unsubscribe send an email to kbuild-leave(a)lists.01.org