Hi "Uwe,
I love your patch! Yet something to improve:
[auto build test ERROR on e73f0f0ee7541171d89f2e2491130c7771ba58d3]
url:
https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/bus-Make-remove...
base: e73f0f0ee7541171d89f2e2491130c7771ba58d3
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/574fac06c264e69608e3c21bc6594c5b5...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Uwe-Kleine-K-nig/bus-Make-remove-callback-return-void/20210713-154310
git checkout 574fac06c264e69608e3c21bc6594c5b5abe1ad4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/nubus/bus.c:46:13: error: initialization of 'void
(*)(struct device *)' from incompatible pointer type 'int (*)(struct device
*)' [-Werror=incompatible-pointer-types]
46 | .remove =
nubus_device_remove,
| ^~~~~~~~~~~~~~~~~~~
drivers/nubus/bus.c:46:13: note: (near initialization for
'nubus_bus_type.remove')
cc1: some warnings being treated as errors
--
> drivers/zorro/zorro-driver.c:166:13: error: initialization of
'void (*)(struct device *)' from incompatible pointer type 'int (*)(struct
device *)' [-Werror=incompatible-pointer-types]
166 | .remove =
zorro_device_remove,
| ^~~~~~~~~~~~~~~~~~~
drivers/zorro/zorro-driver.c:166:13: note: (near initialization for
'zorro_bus_type.remove')
cc1: some warnings being treated as errors
vim +46 drivers/nubus/bus.c
7f86c765a6a2bb Finn Thain 2018-01-13 41
7f86c765a6a2bb Finn Thain 2018-01-13 42 struct bus_type nubus_bus_type = {
7f86c765a6a2bb Finn Thain 2018-01-13 43 .name = "nubus",
7f86c765a6a2bb Finn Thain 2018-01-13 44 .match = nubus_bus_match,
7f86c765a6a2bb Finn Thain 2018-01-13 45 .probe = nubus_device_probe,
7f86c765a6a2bb Finn Thain 2018-01-13 @46 .remove = nubus_device_remove,
7f86c765a6a2bb Finn Thain 2018-01-13 47 };
7f86c765a6a2bb Finn Thain 2018-01-13 48 EXPORT_SYMBOL(nubus_bus_type);
7f86c765a6a2bb Finn Thain 2018-01-13 49
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org