Hi Oded, I love your patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on linux/master linus/master v5.10-rc4 next-20201118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Oded-Gabbay/habanalabs-print-CS-... base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 93c69b2d17372463ae33b79b3002c22a208945b3 config: x86_64-randconfig-a013-20201118 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/71112c9df0288d0689aa5c7fbdd396f2b... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Oded-Gabbay/habanalabs-print-CS-type-when-it-is-stuck/20201118-215554 git checkout 71112c9df0288d0689aa5c7fbdd396f2b099daa4 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): case CS_TYPE_COLLECTIVE_WAIT: ^ 1 error generated. vim +/CS_TYPE_COLLECTIVE_WAIT +400 drivers/misc/habanalabs/common/command_submission.c 366 367 static void cs_timedout(struct work_struct *work) 368 { 369 struct hl_device *hdev; 370 int rc; 371 struct hl_cs *cs = container_of(work, struct hl_cs, 372 work_tdr.work); 373 rc = cs_get_unless_zero(cs); 374 if (!rc) 375 return; 376 377 if ((!cs->submitted) || (cs->completed)) { 378 cs_put(cs); 379 return; 380 } 381 382 /* Mark the CS is timed out so we won't try to cancel its TDR */ 383 cs->timedout = true; 384 385 hdev = cs->ctx->hdev; 386 387 switch (cs->type) { 388 case CS_TYPE_SIGNAL: 389 dev_err(hdev->dev, 390 "Signal command submission %llu has not finished in time!\n", 391 cs->sequence); 392 break; 393 394 case CS_TYPE_WAIT: 395 dev_err(hdev->dev, 396 "Wait command submission %llu has not finished in time!\n", 397 cs->sequence); 398 break; 399 401 dev_err(hdev->dev, 402 "Collective Wait command submission %llu has not finished in time!\n", 403 cs->sequence); 404 break; 405 406 default: 407 dev_err(hdev->dev, 408 "Command submission %llu has not finished in time!\n", 409 cs->sequence); 410 break; 411 } 412 413 cs_put(cs); 414 415 if (hdev->reset_on_lockup) 416 hl_device_reset(hdev, false, false); 417 } 418 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org