tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-maple head: 5cb7f190822d09757b30cd9539e57eef72552d1f commit: 261cd621bd0477d43de460dea6c7bf7fa81824be [29/42] netfs: Implement buffered writes through netfs_file_write_iter() config: hexagon-randconfig-r005-20220216 (https://download.01.org/0day-ci/archive/20220217/202202170638.sSxMPQ6J-lk...) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0e628a783b935c70c80815db6c061ec84f884af5) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/ammarfaizi2/linux-block/commit/261cd621bd0477d43de460d... git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-maple git checkout 261cd621bd0477d43de460dea6c7bf7fa81824be # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/netfs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): unsigned int psize = min(PAGE_SIZE - offset, size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:45:19: note: expanded from macro 'min' #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:20:28: note: expanded from macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ target->from = min(target->from, folio_pos(folio) + offset); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:45:19: note: expanded from macro 'min' #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:20:28: note: expanded from macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ target->to = max(target->to, folio_pos(folio) + offset + len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:52:19: note: expanded from macro 'max' #define max(x, y) __careful_cmp(x, y, >) ^~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~~~~~~~ include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:20:28: note: expanded from macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ 3 warnings generated. vim +28 fs/netfs/buffered_write.c 18 19 static size_t copy_folio_from_iter_atomic(struct folio *folio, 20 unsigned int offset, size_t size, 21 struct iov_iter *i) 22 { 23 size_t copied = 0, n; 24 25 do { 26 unsigned int index = offset / PAGE_SIZE; 27 unsigned int poffset = offset % PAGE_SIZE; 29 30 n = copy_page_from_iter_atomic(folio_file_page(folio, index), 31 poffset, psize, i); 32 copied += n; 33 if (n < psize) 34 break; 35 size -= n; 36 } while (size); 37 return copied; 38 } 39 40 /* 41 * Initialise a new dirty folio group. We have to round it out to any crypto 42 * alignment. 43 */ 44 static void netfs_init_dirty_region(struct netfs_i_context *ctx, 45 struct netfs_dirty_region *region, 46 struct file *file, 47 loff_t start, size_t len) 48 { 49 region->from = start; 50 region->to = start + len; 51 region->debug_id = atomic_inc_return(&netfs_region_debug_ids); 52 53 if (file && ctx->ops->init_dirty_region) 54 ctx->ops->init_dirty_region(region, file); 55 56 trace_netfs_ref_region(region->debug_id, refcount_read(&region->ref), 57 netfs_region_trace_new); 58 } 59 60 /* 61 * Return true if two dirty regions are compatible such that b can be merged 62 * onto the end of a. 63 */ 64 bool netfs_are_regions_mergeable(struct netfs_i_context *ctx, 65 struct netfs_dirty_region *a, 66 struct netfs_dirty_region *b) 67 { 68 if (!netfs_mas_is_valid(a) || !netfs_mas_is_valid(b)) 69 return a == b; 70 if (b->waiting_on_wb != a->waiting_on_wb) 71 return false; 72 if (b->from != a->to && 73 !test_bit(NETFS_ICTX_NEW_CONTENT, &ctx->flags) && 74 b->from < ctx->zero_point) 75 return false; 76 if (ctx->ops->are_regions_mergeable) 77 return ctx->ops->are_regions_mergeable(ctx, a, b); 78 return true; 79 } 80 81 /* 82 * Subsume the modifications into an existing target region. Returns true if 83 * we need to update the dirty_regions tree. 84 */ 85 static bool netfs_subsume_into_existing(struct netfs_i_context *ctx, 86 struct folio *folio, 87 struct ma_state *mas, 88 struct netfs_dirty_region **_target, 89 struct netfs_dirty_region **_to_put, 90 pgoff_t *_first, pgoff_t *_last, 91 size_t offset, size_t len) 92 { 93 struct netfs_dirty_region *target = *_target, *prev; 94 97 trace_netfs_dirty(ctx, target, NULL, *_first, *_last, 98 netfs_dirty_trace_modified); 99 100 /* We might have bridged to the previous region also. */ 101 prev = mas_prev(mas, *_first - 1); 102 if (!netfs_mas_is_valid(prev)) 103 return false; 104 105 if (prev->to != target->from || 106 prev->waiting_on_wb != target->waiting_on_wb) 107 return false; 108 109 *_first = mas->index; 110 prev->to = target->to; 111 *_to_put = target; 112 trace_netfs_dirty(ctx, prev, NULL, *_first, *_last, 113 netfs_dirty_trace_merged_prev); 114 return true; 115 } 116 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org