Hi Jan,
I love your patch! Yet something to improve:
[auto build test ERROR on ext4/dev]
[also build test ERROR on ext3/for_next linus/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Speedup-orphan-fil...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: x86_64-randconfig-a011-20210617 (attached as .config)
compiler: clang version 13.0.0 (
https://github.com/llvm/llvm-project
64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/6b60fad4c555893cdd03e91dbfe31aa6f...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Jan-Kara/ext4-Speedup-orphan-file-handling/20210617-034806
git checkout 6b60fad4c555893cdd03e91dbfe31aa6fa9c25e7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> fs/ext4/orphan.c:195:9: error: implicit declaration of function
'dquot_quota_on_mount' [-Werror,-Wimplicit-function-declaration]
return dquot_quota_on_mount(sb, EXT4_SB(sb)->s_qf_names[type],
^
fs/ext4/orphan.c:195:9: note: did you mean 'ext4_quota_on_mount'?
fs/ext4/orphan.c:193:12: note: 'ext4_quota_on_mount' declared here
static int ext4_quota_on_mount(struct super_block *sb, int type)
^
> fs/ext4/orphan.c:195:47: error: no member named
's_qf_names' in 'struct ext4_sb_info'
return
dquot_quota_on_mount(sb, EXT4_SB(sb)->s_qf_names[type],
~~~~~~~~~~~ ^
> fs/ext4/orphan.c:196:19: error: no member named
's_jquota_fmt' in 'struct ext4_sb_info'
EXT4_SB(sb)->s_jquota_fmt, type);
~~~~~~~~~~~ ^
3 errors generated.
vim +/dquot_quota_on_mount +195 fs/ext4/orphan.c
192
193 static int ext4_quota_on_mount(struct super_block *sb, int type)
194 {
195 return dquot_quota_on_mount(sb,
EXT4_SB(sb)->s_qf_names[type],
196 EXT4_SB(sb)->s_jquota_fmt, type);
197 }
198
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org