Hi Jeff, url: https://github.com/0day-ci/linux/commits/Jeff-Layton/errseq-overlayfs-acc... base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next config: i386-randconfig-m021-20201213 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; smatch warnings: fs/overlayfs/super.c:272 ovl_sync_fs() error: uninitialized symbol 'upper_sb'. vim +/upper_sb +272 fs/overlayfs/super.c e8d4bfe3a715372 Chengguang Xu 2017-11-29 260 /* Sync real dirty inodes in upper filesystem (if it exists) */ e593b2bf513dd4d Amir Goldstein 2017-01-23 261 static int ovl_sync_fs(struct super_block *sb, int wait) e593b2bf513dd4d Amir Goldstein 2017-01-23 262 { ad204488d3046b3 Miklos Szeredi 2017-11-10 263 struct ovl_fs *ofs = sb->s_fs_info; e593b2bf513dd4d Amir Goldstein 2017-01-23 264 struct super_block *upper_sb; e593b2bf513dd4d Amir Goldstein 2017-01-23 265 int ret; e593b2bf513dd4d Amir Goldstein 2017-01-23 266 08f4c7c86d4cf12 Miklos Szeredi 2020-06-04 267 if (!ovl_upper_mnt(ofs)) e593b2bf513dd4d Amir Goldstein 2017-01-23 268 return 0; e8d4bfe3a715372 Chengguang Xu 2017-11-29 269 89bd90a6b2a9bc4 Jeff Layton 2020-12-13 270 if (!ovl_should_sync(ofs)) { 89bd90a6b2a9bc4 Jeff Layton 2020-12-13 271 /* Propagate errors from upper to overlayfs */ 89bd90a6b2a9bc4 Jeff Layton 2020-12-13 @272 ret = errseq_check(&upper_sb->s_wb_err, ofs->err_mark); ^^^^^^^^^^^^^^^^^^^ Uninitialized. 89bd90a6b2a9bc4 Jeff Layton 2020-12-13 273 errseq_set(&sb->s_wb_err, ret); 89bd90a6b2a9bc4 Jeff Layton 2020-12-13 274 return ret; 89bd90a6b2a9bc4 Jeff Layton 2020-12-13 275 } 89bd90a6b2a9bc4 Jeff Layton 2020-12-13 276 e8d4bfe3a715372 Chengguang Xu 2017-11-29 277 /* 32b1924b210a70d Konstantin Khlebnikov 2020-04-09 278 * Not called for sync(2) call or an emergency sync (SB_I_SKIP_SYNC). 32b1924b210a70d Konstantin Khlebnikov 2020-04-09 279 * All the super blocks will be iterated, including upper_sb. e8d4bfe3a715372 Chengguang Xu 2017-11-29 280 * e8d4bfe3a715372 Chengguang Xu 2017-11-29 281 * If this is a syncfs(2) call, then we do need to call e8d4bfe3a715372 Chengguang Xu 2017-11-29 282 * sync_filesystem() on upper_sb, but enough if we do it when being e8d4bfe3a715372 Chengguang Xu 2017-11-29 283 * called with wait == 1. e8d4bfe3a715372 Chengguang Xu 2017-11-29 284 */ e8d4bfe3a715372 Chengguang Xu 2017-11-29 285 if (!wait) e593b2bf513dd4d Amir Goldstein 2017-01-23 286 return 0; e593b2bf513dd4d Amir Goldstein 2017-01-23 287 08f4c7c86d4cf12 Miklos Szeredi 2020-06-04 288 upper_sb = ovl_upper_mnt(ofs)->mnt_sb; e8d4bfe3a715372 Chengguang Xu 2017-11-29 289 e593b2bf513dd4d Amir Goldstein 2017-01-23 290 down_read(&upper_sb->s_umount); e8d4bfe3a715372 Chengguang Xu 2017-11-29 291 ret = sync_filesystem(upper_sb); e593b2bf513dd4d Amir Goldstein 2017-01-23 292 up_read(&upper_sb->s_umount); e8d4bfe3a715372 Chengguang Xu 2017-11-29 293 e593b2bf513dd4d Amir Goldstein 2017-01-23 294 return ret; e593b2bf513dd4d Amir Goldstein 2017-01-23 295 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ kbuild mailing list -- kbuild(a)lists.01.org To unsubscribe send an email to kbuild-leave(a)lists.01.org