On Mon, Mar 9, 2020 at 1:32 AM Jani Nikula <jani.nikula(a)linux.intel.com> wrote:
On Fri, 06 Mar 2020, Nick Desaulniers <ndesaulniers(a)google.com> wrote:
> Based on the tree, I think this report was meant to go to Jani (cc'ed)?
It baffles me that the build bot burns resources on building random
branches in my personal repositories.
But in this case, it seems it caught a build breakage even further
upstream, which is valuable, right?
That said, this builds on GCC 8 just fine. Is clang not able to do this?
Places that require integer constant expressions can be very subtle.
See this recent example in i915 for example:
Sometimes reproducing also depends on some configs. In this case,
it's not as I've fetched your branch and can repro on defconfig.
This is definitely our bug:
Sad trombone. Pretty much blocks what I thought was a nice cleanup
from
illegible macros to plain C code.
BR,
Jani.
>
> On Thu, Mar 5, 2020 at 5:31 PM kbuild test robot <lkp(a)intel.com> wrote:
>>
>> tree:
git://people.freedesktop.org/~jani/drm device-info-inheritance-v3
>> head: 6e8df0961b60ee4c69a95e9304bcb14e85ba4803
>> commit: c8b57de4e93bccfcabe9e32bb4fe8219d3633049 [3/19] drm/i915: store color
info in const structs instead of macros
>> config: x86_64-allyesconfig (attached as .config)
>> compiler: clang version 11.0.0 (git://gitmirror/llvm_project
f70e7dc17d78a83265a89158ee549f1147d7d500)
>> reproduce:
>> # FIXME the reproduce steps for clang is not ready yet
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp(a)intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> >> drivers/gpu/drm/i915/i915_pci.c:212:2: error: initializer element is
not a compile-time constant
>> I830_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro
'I830_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:217:2: error: initializer element is not a
compile-time constant
>> I845_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro
'I845_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:222:2: error: initializer element is not a
compile-time constant
>> I830_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:189:11: note: expanded from macro
'I830_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:228:2: error: initializer element is not a
compile-time constant
>> I845_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:207:11: note: expanded from macro
'I845_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:247:2: error: initializer element is not a
compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro
'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:258:2: error: initializer element is not a
compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro
'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:271:2: error: initializer element is not a
compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro
'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:282:2: error: initializer element is not a
compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro
'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:296:2: error: initializer element is not a
compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro
'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:303:2: error: initializer element is not a
compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro
'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:310:2: error: initializer element is not a
compile-time constant
>> GEN3_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:242:11: note: expanded from macro
'GEN3_FEATURES'
>> .color = i9xx_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:333:2: error: initializer element is not a
compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro
'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:341:2: error: initializer element is not a
compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro
'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:352:2: error: initializer element is not a
compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro
'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:359:2: error: initializer element is not a
compile-time constant
>> GEN4_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:328:11: note: expanded from macro
'GEN4_FEATURES'
>> .color = i965_colors, \
>> ^~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:384:2: error: initializer element is not a
compile-time constant
>> GEN5_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro
'GEN5_FEATURES'
>> .color = ilk_colors, \
>> ^~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:389:2: error: initializer element is not a
compile-time constant
>> GEN5_FEATURES,
>> ^~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_pci.c:379:11: note: expanded from macro
'GEN5_FEATURES'
>> .color = ilk_colors, \
>>
>> vim +212 drivers/gpu/drm/i915/i915_pci.c
>>
>> da1184cd41d4c6b Matthew Auld 2019-10-18 172
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 173 #define I830_FEATURES \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 174 GEN(2), \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 175 .is_mobile = 1, \
>> 8d8b00318593e28 Jani Nikula 2019-09-11 176 .pipe_mask = BIT(PIPE_A)
| BIT(PIPE_B), \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 177 .display.has_overlay =
1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 178
.display.cursor_needs_physical = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 179
.display.overlay_needs_physical = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 180 .display.has_gmch = 1,
\
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 181
.gpu_reset_clobbers_display = true, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 182 .hws_needs_physical = 1,
\
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 183
.unfenced_needs_alignment = 1, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 184 .engine_mask =
BIT(RCS0), \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 185 .has_snoop = true, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 186 .has_coherent_ggtt =
false, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 187 I9XX_PIPE_OFFSETS, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 188 I9XX_CURSOR_OFFSETS, \
>> c8b57de4e93bccf Jani Nikula 2020-03-05 189 .color = i9xx_colors, \
>> 2411ccdddd53007 Jani Nikula 2020-03-05 190 .page_sizes =
GEN_DEFAULT_PAGE_SIZES, \
>> 980a85a19e6db48 Jani Nikula 2020-03-05 191 .memory_regions =
GEN_DEFAULT_REGIONS
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 192
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 193 #define I845_FEATURES \
>> bc76298e68e791f Chris Wilson 2018-02-15 194 GEN(2), \
>> 8d8b00318593e28 Jani Nikula 2019-09-11 195 .pipe_mask =
BIT(PIPE_A), \
>> d53db442db36fdb José Roberto de Souza 2018-11-30 196 .display.has_overlay =
1, \
>> d53db442db36fdb José Roberto de Souza 2018-11-30 197
.display.overlay_needs_physical = 1, \
>> b2ae318acdcaf1c Rodrigo Vivi 2019-02-04 198 .display.has_gmch = 1,
\
>> 55277e1f3107c0b Chris Wilson 2019-01-03 199
.gpu_reset_clobbers_display = true, \
>> 3177659a41cc436 Carlos Santa 2016-08-17 200 .hws_needs_physical = 1,
\
>> f4ce766f28cd0ef Chris Wilson 2017-03-25 201
.unfenced_needs_alignment = 1, \
>> 8a68d464366efb5 Chris Wilson 2019-03-05 202 .engine_mask =
BIT(RCS0), \
>> 5d95c24867aea8a Chris Wilson 2017-09-06 203 .has_snoop = true, \
>> 900ccf30f9e112b Chris Wilson 2018-07-20 204 .has_coherent_ggtt =
false, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 205 I845_PIPE_OFFSETS, \
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 206 I845_CURSOR_OFFSETS, \
>> c8b57de4e93bccf Jani Nikula 2020-03-05 207 .color = i9xx_colors, \
>> 2411ccdddd53007 Jani Nikula 2020-03-05 208 .page_sizes =
GEN_DEFAULT_PAGE_SIZES, \
>> 980a85a19e6db48 Jani Nikula 2020-03-05 209 .memory_regions =
GEN_DEFAULT_REGIONS
>> 0eec8dc7f628a8d Carlos Santa 2016-08-17 210
>> 31409fff1a392fa Lucas De Marchi 2019-12-24 211 static const struct
intel_device_info i830_info = {
>> 37fbbd49054b624 Ville Syrjälä 2019-03-05 @212 I830_FEATURES,
>> c5cb21c17a169ee Chris Wilson 2018-02-15 213 PLATFORM(INTEL_I830),
>> 42f5551d276921d Chris Wilson 2016-06-24 214 };
>> 42f5551d276921d Chris Wilson 2016-06-24 215
>>
>> :::::: The code at line 212 was first introduced by commit
>> :::::: 37fbbd49054b624400a65cf1a39f152a7f3f4749 drm/i915: Populate
pipe_offsets[] & co. accurately
>>
>> :::::: TO: Ville Syrjälä <ville.syrjala(a)linux.intel.com>
>> :::::: CC: Ville Syrjälä <ville.syrjala(a)linux.intel.com>
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>>
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>>
>> --
>> You received this message because you are subscribed to the Google Groups
"Clang Built Linux" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email
to clang-built-linux+unsubscribe(a)googlegroups.com.
>> To view this discussion on the web visit
https://groups.google.com/d/msgid/clang-built-linux/202003060916.RI5pROBS....
--
Jani Nikula, Intel Open Source Graphics Center