Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master linux/master linus/master v5.9-rc5 next-20200918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Gleixner/sched-Migrate-di...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
848785df48835eefebe0c4eb5da7690690b0a8b7
config: sh-rsk7264_defconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
cc1: warning: arch/sh/include/mach-rsk: No such file or directory
[-Wmissing-include-dirs]
cc1: warning: arch/sh/include/mach-rsk: No such file or directory
[-Wmissing-include-dirs]
In file included from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/numa_balancing.h:10,
from include/trace/events/sched.h:8,
from kernel/sched/core.c:10:
kernel/sched/sched.h: In function 'rq_pin_lock':
> kernel/sched/sched.h:1224:18: error: 'struct rq' has no
member named 'balance_callback'
1224 |
SCHED_WARN_ON(rq->balance_callback);
| ^~
include/asm-generic/bug.h:157:27: note: in definition of macro 'WARN_ONCE'
157 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
kernel/sched/sched.h:1224:2: note: in expansion of macro 'SCHED_WARN_ON'
1224 | SCHED_WARN_ON(rq->balance_callback);
| ^~~~~~~~~~~~~
--
cc1: warning: arch/sh/include/mach-rsk: No such file or directory
[-Wmissing-include-dirs]
cc1: warning: arch/sh/include/mach-rsk: No such file or directory
[-Wmissing-include-dirs]
In file included from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from kernel/sched/sched.h:5,
from kernel/sched/fair.c:23:
kernel/sched/sched.h: In function 'rq_pin_lock':
> kernel/sched/sched.h:1224:18: error: 'struct rq' has no
member named 'balance_callback'
1224 |
SCHED_WARN_ON(rq->balance_callback);
| ^~
include/asm-generic/bug.h:157:27: note: in definition of macro 'WARN_ONCE'
157 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
kernel/sched/sched.h:1224:2: note: in expansion of macro 'SCHED_WARN_ON'
1224 | SCHED_WARN_ON(rq->balance_callback);
| ^~~~~~~~~~~~~
kernel/sched/fair.c: At top level:
kernel/sched/fair.c:5364:6: warning: no previous prototype for
'init_cfs_bandwidth' [-Wmissing-prototypes]
5364 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
| ^~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11113:6: warning: no previous prototype for
'free_fair_sched_group' [-Wmissing-prototypes]
11113 | void free_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11115:5: warning: no previous prototype for
'alloc_fair_sched_group' [-Wmissing-prototypes]
11115 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11120:6: warning: no previous prototype for
'online_fair_sched_group' [-Wmissing-prototypes]
11120 | void online_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11122:6: warning: no previous prototype for
'unregister_fair_sched_group' [-Wmissing-prototypes]
11122 | void unregister_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
cc1: warning: arch/sh/include/mach-rsk: No such file or directory
[-Wmissing-include-dirs]
cc1: warning: arch/sh/include/mach-rsk: No such file or directory
[-Wmissing-include-dirs]
In file included from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from kernel/sched/sched.h:5,
from kernel/sched/rt.c:6:
kernel/sched/sched.h: In function 'rq_pin_lock':
> kernel/sched/sched.h:1224:18: error: 'struct rq' has no
member named 'balance_callback'
1224 |
SCHED_WARN_ON(rq->balance_callback);
| ^~
include/asm-generic/bug.h:157:27: note: in definition of macro 'WARN_ONCE'
157 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
kernel/sched/sched.h:1224:2: note: in expansion of macro 'SCHED_WARN_ON'
1224 | SCHED_WARN_ON(rq->balance_callback);
| ^~~~~~~~~~~~~
kernel/sched/rt.c: At top level:
kernel/sched/rt.c:253:6: warning: no previous prototype for
'free_rt_sched_group' [-Wmissing-prototypes]
253 | void free_rt_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:255:5: warning: no previous prototype for
'alloc_rt_sched_group' [-Wmissing-prototypes]
255 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:668:6: warning: no previous prototype for
'sched_rt_bandwidth_account' [-Wmissing-prototypes]
668 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
#
https://github.com/0day-ci/linux/commit/f1fee7de063e0f3f8b3b418491cde1317...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Thomas-Gleixner/sched-Migrate-disable-support-for-RT/20200917-185532
git checkout f1fee7de063e0f3f8b3b418491cde13178356a82
vim +1224 kernel/sched/sched.h
1205
1206 /*
1207 * Lockdep annotation that avoids accidental unlocks; it's like a
1208 * sticky/continuous lockdep_assert_held().
1209 *
1210 * This avoids code that has access to 'struct rq *rq' (basically
everything in
1211 * the scheduler) from accidentally unlocking the rq if they do not also have a
1212 * copy of the (on-stack) 'struct rq_flags rf'.
1213 *
1214 * Also see Documentation/locking/lockdep-design.rst.
1215 */
1216 static inline void rq_pin_lock(struct rq *rq, struct rq_flags *rf)
1217 {
1218 rf->cookie = lockdep_pin_lock(&rq->lock);
1219
1220 #ifdef CONFIG_SCHED_DEBUG
1221 rq->clock_update_flags &= (RQCF_REQ_SKIP|RQCF_ACT_SKIP);
1222 rf->clock_update_flags = 0;
1223
1224 SCHED_WARN_ON(rq->balance_callback);
1225 #endif
1226 }
1227
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org