Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on next-20220116]
[cannot apply to v5.16]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/marek-vasut-gmail-com/PCI-rcar-F...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm-randconfig-c002-20220116
(
https://download.01.org/0day-ci/archive/20220117/202201170248.g8zqyL3O-lk...)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/f784bebf4a058d633fc77579892309b12...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
marek-vasut-gmail-com/PCI-rcar-Finish-transition-to-L1-state-in-rcar_pcie_config_access/20220116-102631
git checkout f784bebf4a058d633fc77579892309b12dd33edb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=arm SHELL=/bin/bash drivers/pci/controller/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/pci/controller/pcie-rcar-host.c:109:6: warning: no
previous prototype for 'rcar_pci_write_reg_workaround' [-Wmissing-prototypes]
109 | void rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val,
unsigned int reg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pci/controller/pcie-rcar-host.c:121:5: warning: no
previous prototype for 'rcar_pci_read_reg_workaround' [-Wmissing-prototypes]
121 | u32 rcar_pci_read_reg_workaround(struct rcar_pcie *pcie, unsigned int
reg)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/cc0JJaba.s: Assembler messages:
/tmp/cc0JJaba.s:1425: Error: selected processor does not support `isb' in ARM mode
/tmp/cc0JJaba.s:1486: Error: selected processor does not support `isb' in ARM mode
/tmp/cc0JJaba.s:2594: Error: selected processor does not support `isb' in ARM mode
/tmp/cc0JJaba.s:2622: Error: symbol `rcar_pci_read_reg_workaround_start' is already
defined
/tmp/cc0JJaba.s:2624: Error: selected processor does not support `isb' in ARM mode
vim +/rcar_pci_write_reg_workaround +109 drivers/pci/controller/pcie-rcar-host.c
108
109 void rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32
val, unsigned int reg)
110 {
111 #ifdef CONFIG_ARM
112 asm volatile(
113 " str %0, [%1]\n"
114 " isb\n"
115 ::"r"(val), "r"(pcie->base + reg):"memory");
116 #else
117 rcar_pci_write_reg(pcie, val, reg);
118 #endif
119 }
120
121 u32 rcar_pci_read_reg_workaround(struct rcar_pcie *pcie, unsigned
int reg)
122 {
123 #ifdef CONFIG_ARM
124 u32 val;
125
126 asm volatile(
127 "rcar_pci_read_reg_workaround_start:\n"
128 "1: ldr %0, [%1]\n"
129 " isb\n"
130 : "=r"(val):"r"(pcie->base + reg):"memory");
131
132 return val;
133 #else
134 return rcar_pci_read_reg(pcie, reg);
135 #endif
136 }
137
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org