tree:
git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.4.y
head: 32ec4c2fa3f011cd238179516e0b459a7109c2d3
commit: 565198c2c4ef2ebea9215501288966460bc335fd [3569/9558] phy: cadence-torrent:
Implement PHY configure APIs
compiler: m68k-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
> drivers/phy/cadence/phy-cadence-torrent.c:595:9: warning:
Identical condition 'ret', second condition is always false
[identicalConditionAfterEarlyExit]
return ret;
^
drivers/phy/cadence/phy-cadence-torrent.c:591:6: note: first condition
if (ret)
^
drivers/phy/cadence/phy-cadence-torrent.c:595:9: note: second condition
return ret;
^
git remote add ti
git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.4.y
git checkout 565198c2c4ef2ebea9215501288966460bc335fd
vim +/ret +595 drivers/phy/cadence/phy-cadence-torrent.c
561
562 /* Configure link rate as required. */
563 static int cdns_torrent_dp_set_rate(struct cdns_torrent_phy *cdns_phy,
564 struct phy_configure_opts_dp *dp)
565 {
566 u32 ret;
567
568 ret = cdns_torrent_dp_set_power_state(cdns_phy, dp->lanes,
569 POWERSTATE_A3);
570 if (ret)
571 return ret;
572 ret = cdns_torrent_dp_set_pll_en(cdns_phy, dp, false);
573 if (ret)
574 return ret;
575 ndelay(200);
576
577 ret = cdns_torrent_dp_configure_rate(cdns_phy, dp);
578 if (ret)
579 return ret;
580 ndelay(200);
581
582 ret = cdns_torrent_dp_set_pll_en(cdns_phy, dp, true);
583 if (ret)
584 return ret;
585 ret = cdns_torrent_dp_set_power_state(cdns_phy, dp->lanes,
586 POWERSTATE_A2);
587 if (ret)
588 return ret;
589 ret = cdns_torrent_dp_set_power_state(cdns_phy, dp->lanes,
590 POWERSTATE_A0);
591 if (ret)
592 return ret;
593 ndelay(900);
594
595 return ret;
596 }
597
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org