tree: https://github.com/jpirko/linux_mlxsw linecards head: 420093481d1127af592411fb8b759713182acc9c commit: fad324f26145b7917eaee575b01cd9121353cc39 [44/102] devlink: add support to create line card and expose to user config: x86_64-randconfig-m001-20210622 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; New smatch warnings: net/core/devlink.c:9601 devlink_linecard_create() warn: inconsistent returns '&devlink->lock'. Old smatch warnings: net/core/devlink.c:6634 devlink_fmsg_prepare_skb() error: uninitialized symbol 'err'. vim +9601 net/core/devlink.c fad324f26145b7 Jiri Pirko 2020-12-28 9581 struct devlink_linecard *devlink_linecard_create(struct devlink *devlink, fad324f26145b7 Jiri Pirko 2020-12-28 9582 unsigned int linecard_index) fad324f26145b7 Jiri Pirko 2020-12-28 9583 { fad324f26145b7 Jiri Pirko 2020-12-28 9584 struct devlink_linecard *linecard; fad324f26145b7 Jiri Pirko 2020-12-28 9585 fad324f26145b7 Jiri Pirko 2020-12-28 9586 mutex_lock(&devlink->lock); fad324f26145b7 Jiri Pirko 2020-12-28 9587 if (devlink_linecard_index_exists(devlink, linecard_index)) { fad324f26145b7 Jiri Pirko 2020-12-28 9588 mutex_unlock(&devlink->lock); fad324f26145b7 Jiri Pirko 2020-12-28 9589 return ERR_PTR(-EEXIST); fad324f26145b7 Jiri Pirko 2020-12-28 9590 } fad324f26145b7 Jiri Pirko 2020-12-28 9591 fad324f26145b7 Jiri Pirko 2020-12-28 9592 linecard = kzalloc(sizeof(*linecard), GFP_KERNEL); fad324f26145b7 Jiri Pirko 2020-12-28 9593 if (!linecard) fad324f26145b7 Jiri Pirko 2020-12-28 9594 return ERR_PTR(-ENOMEM); mutex_unlock(&devlink->lock); before returning fad324f26145b7 Jiri Pirko 2020-12-28 9595 fad324f26145b7 Jiri Pirko 2020-12-28 9596 linecard->devlink = devlink; fad324f26145b7 Jiri Pirko 2020-12-28 9597 linecard->index = linecard_index; fad324f26145b7 Jiri Pirko 2020-12-28 9598 list_add_tail(&linecard->list, &devlink->linecard_list); fad324f26145b7 Jiri Pirko 2020-12-28 9599 devlink_linecard_notify(linecard, DEVLINK_CMD_LINECARD_NEW); fad324f26145b7 Jiri Pirko 2020-12-28 9600 mutex_unlock(&devlink->lock); fad324f26145b7 Jiri Pirko 2020-12-28 @9601 return linecard; fad324f26145b7 Jiri Pirko 2020-12-28 9602 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org