Hi Jakub, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethernet-more-net... base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5f3b8acee9fee04ece54376a4f842847000a97f3 config: sparc64-randconfig-s032-20211013 (attached as .config) compiler: sparc64-linux-gcc (GCC) 11.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/6ead16677b0e7c54f6a7679276c70ffa1... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jakub-Kicinski/ethernet-more-netdev-dev_addr-write-removals/20211014-045931 git checkout 6ead16677b0e7c54f6a7679276c70ffa1bbc17f3 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/net/ethernet/qlogic/qed/qed_l2.c: In function 'qed_req_bulletin_update_mac': 2861 | ret = qed_vf_pf_bulletin_update_mac(p_hwfn, mac); | ^~~ In file included from drivers/net/ethernet/qlogic/qed/qed_sriov.h:10, from drivers/net/ethernet/qlogic/qed/qed_l2.c:39: drivers/net/ethernet/qlogic/qed/qed_vf.h:1262:53: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const u8 *' {aka 'const unsigned char *'} 1262 | u8 *p_mac) | ~~~~^~~~~ sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse: expected unsigned char [usertype] *p_mac drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse: got unsigned char const [usertype] *mac vim +2861 drivers/net/ethernet/qlogic/qed/qed_l2.c cee4d26448c100 Manish Chopra 2015-10-26 2850 6ead16677b0e7c Jakub Kicinski 2021-10-13 2851 static int qed_req_bulletin_update_mac(struct qed_dev *cdev, const u8 *mac) 809c45a091d93e Shahed Shaikh 2018-04-19 2852 { 809c45a091d93e Shahed Shaikh 2018-04-19 2853 int i, ret; 809c45a091d93e Shahed Shaikh 2018-04-19 2854 809c45a091d93e Shahed Shaikh 2018-04-19 2855 if (IS_PF(cdev)) 809c45a091d93e Shahed Shaikh 2018-04-19 2856 return 0; 809c45a091d93e Shahed Shaikh 2018-04-19 2857 809c45a091d93e Shahed Shaikh 2018-04-19 2858 for_each_hwfn(cdev, i) { 809c45a091d93e Shahed Shaikh 2018-04-19 2859 struct qed_hwfn *p_hwfn = &cdev->hwfns[i]; 809c45a091d93e Shahed Shaikh 2018-04-19 2860 809c45a091d93e Shahed Shaikh 2018-04-19 @2861 ret = qed_vf_pf_bulletin_update_mac(p_hwfn, mac); 809c45a091d93e Shahed Shaikh 2018-04-19 2862 if (ret) 809c45a091d93e Shahed Shaikh 2018-04-19 2863 return ret; 809c45a091d93e Shahed Shaikh 2018-04-19 2864 } 809c45a091d93e Shahed Shaikh 2018-04-19 2865 809c45a091d93e Shahed Shaikh 2018-04-19 2866 return 0; 809c45a091d93e Shahed Shaikh 2018-04-19 2867 } 809c45a091d93e Shahed Shaikh 2018-04-19 2868 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org