Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on ljones-mfd/for-mfd-next rockchip/for-next keystone/next arm64/for-next/core arm-soc/for-next shawnguo/for-next v5.7-rc1 next-20200414] [cannot apply to xlnx/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Michael-Tretter/soc-xilinx-vcu-p... base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: x86_64-randconfig-a002-20200414 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from include/linux/err.h:5:0, from include/linux/clk.h:12, from drivers/soc/xilinx/xlnx_vcu.c:9: drivers/soc/xilinx/xlnx_vcu.c: In function 'xvcu_reset': drivers/soc/xilinx/xlnx_vcu.c:540:11: error: 'struct xvcu_device' has no member named 'reset_gpio' if (!xvcu->reset_gpio) ^ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ if (!xvcu->reset_gpio) ^~ drivers/soc/xilinx/xlnx_vcu.c:540:11: error: 'struct xvcu_device' has no member named 'reset_gpio' if (!xvcu->reset_gpio) ^ include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ if (!xvcu->reset_gpio) ^~ drivers/soc/xilinx/xlnx_vcu.c:540:11: error: 'struct xvcu_device' has no member named 'reset_gpio' if (!xvcu->reset_gpio) ^ include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value' (cond) ? \ ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~~~~~~~~~~~ if (!xvcu->reset_gpio) ^~ drivers/soc/xilinx/xlnx_vcu.c:543:2: error: implicit declaration of function 'gpiod_set_value'; did you mean 'bitmap_set_value8'? [-Werror=implicit-function-declaration] gpiod_set_value(xvcu->reset_gpio, 0); ^~~~~~~~~~~~~~~ bitmap_set_value8 drivers/soc/xilinx/xlnx_vcu.c:543:22: error: 'struct xvcu_device' has no member named 'reset_gpio' gpiod_set_value(xvcu->reset_gpio, 0); ^~ drivers/soc/xilinx/xlnx_vcu.c:545:2: error: implicit declaration of function 'usleep_range'; did you mean 'sort_range'? [-Werror=implicit-function-declaration] usleep_range(60, 120); ^~~~~~~~~~~~ sort_range drivers/soc/xilinx/xlnx_vcu.c:546:22: error: 'struct xvcu_device' has no member named 'reset_gpio' gpiod_set_value(xvcu->reset_gpio, 1); ^~ At top level: drivers/soc/xilinx/xlnx_vcu.c:538:13: warning: 'xvcu_reset' defined but not used [-Wunused-function] static void xvcu_reset(struct xvcu_device *xvcu) ^~~~~~~~~~ cc1: some warnings being treated as errors vim +/if +540 drivers/soc/xilinx/xlnx_vcu.c 537 538 static void xvcu_reset(struct xvcu_device *xvcu) 539 { 541 return; 542 543 gpiod_set_value(xvcu->reset_gpio, 0); 544 /* min 2 clock cycle of vcu pll_ref, slowest freq is 33.33KHz */ 545 usleep_range(60, 120); 546 gpiod_set_value(xvcu->reset_gpio, 1); 547 usleep_range(60, 120); 548 } 549 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org